Date: Sat, 14 Sep 2024 08:33:33 +0000
To: Dominique Devienne <ddevienne@gmail.com>, Adrian Klaver <adrian.klaver@aklaver.com>
From: Dan Kortschak <dan+pgsql@kortschak.io>
Cc: Vincent Veyron <vv.lists@wanadoo.fr>, pgsql-general@postgresql.org
Subject: Re: re-novice coming back to pgsql: porting an SQLite update statement to postgres
Message-ID: <5c86256a4e83b1af73da22faab54889564e93129.camel@kortschak.io>
In-Reply-To: <21078220628bcebca0395a52d42b558ed965bbc0.camel@kortschak.io>
References: <1aea530e4c96109b91fdde53a29e38beb625dc77.camel@kortschak.io> <20240723221121.51f2b3872d0ebfc36a6fa8ff@wanadoo.fr> <2f11b2ba-3182-492a-ab46-23cfa5ec913c@aklaver.com> <CAFCRh-8d-gsERdu-6W2fb0d6HLi8_bPkS7zVqm0J4ZakpvJQYw@mail.gmail.com> <735913e4c9601a2a7ad57d2253d74451c42ba899.camel@kortschak.io> <21078220628bcebca0395a52d42b558ed965bbc0.camel@kortschak.io>
Feedback-ID: 18519778:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/5c86256a4e83b1af73da22faab54889564e93129.camel%40kortschak.io>
Precedence: bulk

On Wed, 2024-07-24 at 00:23 +0000, Dan Kortschak wrote:
> On 7/23/24 13:11, Vincent Veyron wrote:
> > On Mon, 15 Jul 2024 20:31:13 +0000
> >=20
> > This is the goto page for anything SQL :
> > https://www.postgresql.org/docs/current/sql-commands.html
> >=20
> > For DateTime types :
> > https://www.postgresql.org/docs/current/datatype-datetime.html
> >=20
> > For JSON types :
> > https://www.postgresql.org/docs/current/datatype-json.html
>=20
> Thanks, I will work through those.

I've had a chance to attack this. The first part of the problem was
that I could not figure out how to get the multiple statement
transaction that I using in SQLite to work with PostgreSQL. The
solution was to use the host language's Postres binding transaction
functions and send the statements separately.

The first part, to ensure the JSON array exist is solved with

=09update
=09=09events
=09set=20
=09=09datastr =3D jsonb_set(datastr, '{amend}', '[]')
=09where
=09=09starttime < $3 and
=09=09endtime > $2 and
=09=09not datastr::jsonb ? 'amend' and
=09=09bucketrow =3D (
=09=09=09select rowid from buckets where id =3D $1
=09=09);

I'm still having difficulties with the second part which is to update
the contents of the amend array in the JSON.

So far I'm able to append the relevant details to the append array, but
I'm unable to correctly select the corrects elements from the $6
argument, which is in the form
[{"start":<RFC3339>,"end":<RFC3339>,"data":<object>}, ...]. The first
update statement gives me broadly what I want, but includes elements of
the array that it shouldn't.

=09update
=09=09events
=09set
=09=09datastr =3D jsonb_set(
=09=09=09datastr,
=09=09=09'{amend}',
=09=09=09datastr->'amend' || jsonb_build_object(
=09=09=09=09'time', $2::TEXT,
=09=09=09=09'msg', $3::TEXT,
=09=09=09=09'replace', (
=09=09=09=09=09-- This select is for comparison with the code below.
=09=09=09=09=09select * from jsonb($6::TEXT)
=09=09=09=09)
=09=09=09)
=09=09)
=09where
=09=09starttime < $5 and
=09=09endtime > $4 and
=09=09bucketrow =3D (
=09=09=09select rowid from buckets where id =3D $1
=09=09);

If I filter on the start and end time, I end up with no element coming
through at all and the "replace" field ends up null.

=09update
=09=09events
=09set
=09=09datastr =3D jsonb_set(
=09=09=09datastr,
=09=09=09'{amend}',
=09=09=09datastr->'amend' || jsonb_build_object(
=09=09=09=09'time', $2::TEXT,
=09=09=09=09'msg', $3::TEXT,
=09=09=09=09'replace', (
=09=09=09=09=09select *
=09=09=09=09=09from
=09=09=09=09=09=09jsonb($6::TEXT) as replacement
=09=09=09=09=09where
=09=09=09=09=09=09(replacement->>'start')::TIMESTAMP WITH TIME ZONE < endti=
me and
=09=09=09=09=09=09(replacement->>'end')::TIMESTAMP WITH TIME ZONE > startti=
me
=09=09=09=09)
=09=09=09)
=09=09)
=09where
=09=09starttime < $5 and
=09=09endtime > $4 and
=09=09bucketrow =3D (
=09=09=09select rowid from buckets where id =3D $1
=09=09);

Can anyone suggest what I might be missing? One thing that occurs to me
is that due to the host language the timezone in starttime and endtime
is the local timezone, while the timezone in the elements of the $6
argument are in UTC. I've tried forcing the timezones to match and this
does not appear to be the issue.

This can be seen in the case of output from the first, non-filtering
update statement above:

=09{
=09=09...
=09=09"start": "2023-06-13T05:24:50+09:30",
=09=09"end": "2023-06-13T05:24:55+09:30",
=09=09"data": {
=09=09=09...
=09=09=09"amend": [
=09=09=09=09{
=09=09=09=09=09"endtime": "2023-06-13T05:24:55+09:30",
=09=09=09=09=09"msg": "testing",
=09=09=09=09=09"replace": [
=09=09=09=09=09=09{
=09=09=09=09=09=09=09"data": {
=09=09=09=09=09=09=09=09...
=09=09=09=09=09=09=09},
=09=09=09=09=09=09=09"end": "2023-06-12T19:54:51Z",
=09=09=09=09=09=09=09"start": "2023-06-12T19:54:39Z"
=09=09=09=09=09=09}
=09=09=09=09=09],
=09=09=09=09=09"starttime": "2023-06-13T05:24:50+09:30",
=09=09=09=09=09...
=09=09=09=09}
=09=09=09]
=09=09}
=09},

(I'm hoping there's not a dumb logic error in the statement; it's
equivalent works with SQLite, and mapped all to UTC we have
starttime=3D2023-06-12T19:54:50Z endtime=3D2023-06-12T19:54:55Z start=3D202=
3-
06-12T19:54:39Z and end=3D2023-06-12T19:54:51Z which is an overlap).