From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christophe Pettus <xof@thebuild.com>
cc: Corbin Cavolt <ccavolt@pm.me>,
        "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
Subject: Re: Error Building Postgres 17.0 from Source
In-reply-to: <4A3CC287-BAC9-4786-B4F9-FFF5B2CA78F9@thebuild.com>
References: <flI4M-03G-AFcIh3h-Nrcn0ewqMm0gLllRgRrlcxlnCzniOqhLM0JJcpGnFUVcxV-QWkkCjJNYHOivVLcq_KDea4utfBXsKxlTojQ0oQ6tc=@pm.me> <AB8C9440-3A53-48C3-84E4-CFBAD30773BD@thebuild.com> <676935.1728068724@sss.pgh.pa.us> <4A3CC287-BAC9-4786-B4F9-FFF5B2CA78F9@thebuild.com>
Comments: In-reply-to Christophe Pettus <xof@thebuild.com>
	message dated "Fri, 04 Oct 2024 12:08:11 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <680038.1728070459.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 04 Oct 2024 15:34:19 -0400
Message-ID: <680039.1728070459@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/680039.1728070459%40sss.pgh.pa.us>
Precedence: bulk

Christophe Pettus <xof@thebuild.com> writes:
> On Oct 4, 2024, at 12:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, that's what it looks like.  I'm a bit confused though because
>> 16.x should have failed the same way: building our docs without local
>> DTDs has failed for well over a year now [1]. =


> To add confusion to the fire, I was successfully building pre-17 version=
s ("make world") locally on MacOS fine without having to install the docum=
entation tools.  It wasn't until 17 that it failed (and installing the doc=
 tools as recommended fixed it).

If you had a locally installed copy of the required DTDs, it should've
worked, but otherwise I don't see how ... oh, wait.  Were you building
from a source tarball?  If so, the difference is that up to v16 we
included prebuilt HTML docs in the tarballs, but as of v17 we don't.
So "make world" now triggers a local docs build where before it
didn't.

You can restore things to the status quo ante if you also download
the now-separate docs tarball, eg

https://ftp.postgresql.org/pub/source/v17.0/postgresql-17.0-docs.tar.gz

and unpack that into the same place as the main source tarball.

			regards, tom lane