Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhVx-00011v-1M for pgsql-general@arkaria.postgresql.org; Mon, 12 Sep 2022 11:22:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oXhVv-0002Sa-Jh for pgsql-general@arkaria.postgresql.org; Mon, 12 Sep 2022 11:22:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhVu-0002SR-Kz for pgsql-general@lists.postgresql.org; Mon, 12 Sep 2022 11:22:07 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXhVq-000178-Ak for pgsql-general@lists.postgresql.org; Mon, 12 Sep 2022 11:22:05 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0FD7E5C0067; Mon, 12 Sep 2022 07:22:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 12 Sep 2022 07:22:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1662981721; x= 1663068121; bh=AEiM9myDrf4OU8As3nPQvdQFaedvqu4m6vHEl3TL86E=; b=R 0bBDUXzUhzrif63xwpbOcSzg1rkJAAWnPa2Stm68v/sZZoWHBOYL4dFTO+OuKt3s 92F/Mo287rnP8xhTqMuduDtKpCfcQBc3umT2BjCJNqfb/0R1Panb+WpCVqyepwAx 0VtlgnRQ/x/PtcZWzwyY2nleA6w3bXDFJfTzv1cZPKPur8dPJPUut9ObGuwkbzpz nY6urYSokok4PNEQ4y3kfbeHQK4OH96J9rgWB9nXnZo/z1SKRhv155MIZfztlOXI 1CVDxWK+chdUKBicU88i4CXdNCNkZvmXmgUQEX2dN8tc1YH6enFOu7SY1GfXICC8 nh/WX8ocBvI9j7uyLrnlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduvddggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Sep 2022 07:21:59 -0400 (EDT) Message-ID: <6b1946ab-b6ff-8f0c-22d9-2456b04dd1b3@enterprisedb.com> Date: Mon, 12 Sep 2022 13:21:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: lippq client library and openssl initialization: PQinitOpenSSL() Content-Language: en-US To: Daniel Gustafsson , Tom Lane Cc: Sebastien Flaesch , "pgsql-general@lists.postgresql.org" References: <816006.1662908880@sss.pgh.pa.us> <9A09E47E-68EB-45DF-A934-FB76F2086D20@yesql.se> <1206133.1662932104@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11.09.22 23:43, Daniel Gustafsson wrote: >> On 11 Sep 2022, at 23:35, Tom Lane wrote: >> >> Daniel Gustafsson writes: >>> On 11 Sep 2022, at 17:08, Tom Lane wrote: >>>> Don't believe so. The HAVE_CRYPTO_LOCK stuff is all obsolete and >>>> not compiled if you built against 1.1.0. The only thing left that >>>> will happen if you don't call PQinitOpenSSL is an extra call to >>>> OPENSSL_init_ssl, which should be harmless as far as I can see >>>> from the OpenSSL docs. >> >>> To the best of my knowledge, thats entirely correct. >> >> Should we document these functions as obsolete when using >> OpenSSL >= 1.1.0 ? > > Given that 1.1.0+ is very common, it's probably not a bad idea to document them > as obsolete but harmless. Unless you beat me to it I can propose a patch. AFAICT, RHEL 7 ships with an older version. I think that's still pretty widespread.