Message-ID: <77a63548783dd4007ee479a4c5ed300629aaa776.camel@cybertec.at>
Subject: Re: Latest patches break one of our unit-test, related to RLS
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Dominique Devienne <ddevienne@gmail.com>, pgsql-general@postgresql.org
Date: Fri, 12 Sep 2025 14:45:56 +0200
In-Reply-To: <CAFCRh-93hsRvoJqQCwXq06=AJJJ_s783gVsGHKc-QjgOO6jGVg@mail.gmail.com>
References: 
	<CAFCRh-8NwJd0jq6P=R3qhHyqU7hw0BTor3W0SvUcii24et+zAw@mail.gmail.com>
	 <CAFCRh-93hsRvoJqQCwXq06=AJJJ_s783gVsGHKc-QjgOO6jGVg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/77a63548783dd4007ee479a4c5ed300629aaa776.camel%40cybertec.at>
Precedence: bulk

On Fri, 2025-09-12 at 14:22 +0200, Dominique Devienne wrote:
> On Thu, Sep 4, 2025 at 5:03=E2=80=AFPM Dominique Devienne <ddevienne@gmai=
l.com> wrote:
> > OK with 16.9 and 17.5 (we cannot test on beta2 anymore)
> > KO with 16.10 and 17.6 (and beta3 too, released at the same time)
>=20
> I've tracked down the regression to this particular query, FWIW:
>=20
> select rolname, rolsuper, rolinherit, rolcreaterole,
>        rolcreatedb, rolcanlogin, rolreplication, rolbypassrls,
>        oid, shobj_description(oid, 'pg_authid')
>   from pg_roles
>  where rolname SIMILAR TO $1 AND pg_has_role(oid, 'SET')
>  order by rolname
>=20
> In 17.5, returns 3 rows.
> In 17.6, returns 0 rows.

That must be commit e3ffc3e91d.

That commit fixed a bug in the conversion from SIMILAR TO
expressions to POSIX regular expressions.

You don't show us that data that match the pattern in 17.5, but
not in 17.6.  Unless you show us a counterexample, I'd say that
the behavior in 17.6 is correct.

Minor releases shouldn't change the behavior EXCEPT when the
behavior is buggy.

Yours,
Laurenz Albe