Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWpFj-0000Qo-39 for pgsql-hackers@arkaria.postgresql.org; Fri, 31 May 2019 21:39:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hWpFh-0001Kp-Lu for pgsql-hackers@arkaria.postgresql.org; Fri, 31 May 2019 21:39:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWpFh-0001Ki-DU for pgsql-hackers@lists.postgresql.org; Fri, 31 May 2019 21:39:53 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWpFe-0000MW-Mp for pgsql-hackers@lists.postgresql.org; Fri, 31 May 2019 21:39:53 +0000 Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x4VLdiXH008669; Fri, 31 May 2019 17:39:44 -0400 From: Tom Lane To: =?koi8-r?B?9MHSwdPP1yDnxc/Sx8nKIPfJ1MHM2MXXyd4=?= cc: pgsql-hackers@lists.postgresql.org Subject: Re: compiling PL/pgSQL plugin with C++ In-reply-to: <74481.1559252788@sss.pgh.pa.us> References: <51937.1559231664@sss.pgh.pa.us> <74481.1559252788@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Thu, 30 May 2019 17:46:28 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <81722.1559338784.1@sss.pgh.pa.us> Date: Fri, 31 May 2019 17:39:44 -0400 Message-ID: <81723.1559338784@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I wrote: > There are various other minor issues, but they generally look > fixable with little consequence. I've now pushed your patch and additional minor fixes, and we've expanded cpluspluscheck's coverage so we don't miss such issues in future. regards, tom lane