Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iHDgH-0002EM-2D for pgsql-hackers@arkaria.postgresql.org; Sun, 06 Oct 2019 21:03:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iHDgF-0002uL-20 for pgsql-hackers@arkaria.postgresql.org; Sun, 06 Oct 2019 21:03:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iHDgE-0002u3-MV for pgsql-hackers@lists.postgresql.org; Sun, 06 Oct 2019 21:03:02 +0000 Received: from lungold.riddles.org.uk ([82.68.208.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iHDg7-0004xU-UH for pgsql-hackers@lists.postgresql.org; Sun, 06 Oct 2019 21:03:01 +0000 Received: from [192.168.127.1] (port=44774 helo=caithnard.riddles.org.uk) by lungold.riddles.org.uk with esmtp (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1iHDg1-000DJa-Gy; Sun, 06 Oct 2019 21:02:49 +0000 Received: from localhost ([127.0.0.1]:23720 helo=caithnard.riddles.org.uk) by caithnard.riddles.org.uk with esmtp (Exim 4.92.1 (FreeBSD)) (envelope-from ) id 1iHDg1-0004Ug-Cc; Sun, 06 Oct 2019 21:02:49 +0000 From: Andrew Gierth To: Tom Lane Cc: Justin Pryzby , pgsql-hackers@lists.postgresql.org Subject: Re: v12 and pg_restore -f- In-Reply-To: <28770.1570394593@sss.pgh.pa.us> (Tom Lane's message of "Sun, 06 Oct 2019 16:43:13 -0400") Message-ID: <875zl11tla.fsf@news-spur.riddles.org.uk> References: <20191006190839.GE18030@telsasoft.com> <28770.1570394593@sss.pgh.pa.us> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (berkeley-unix) Date: Sun, 06 Oct 2019 22:02:49 +0100 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk >>>>> "Tom" == Tom Lane writes: Tom> Perhaps we could change the back branches so that they interpret Tom> "-f -" as "write to stdout", but without enforcing that you use Tom> that syntax. We should definitely do that. Tom> Alternatively, we could revert the v12 behavior change. On the Tom> whole that might be the wiser course. I do not think the costs and Tom> benefits of this change were all that carefully thought through. Failing to specify -d is a _really fricking common_ mistake for inexperienced users, who may not realize that the fact that they're seeing a ton of SQL on their terminal is not the normal result. Seriously, this comes up on a regular basis on IRC (which is why I suggested initially that we should do something about it). -- Andrew (irc:RhodiumToad)