Message-ID: <88e3b55a-8ef8-4b53-8d71-6bfde1a07bc1@oss.nttdata.com>
Date: Thu, 20 Mar 2025 00:34:59 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Disabling vacuum truncate for autovacuum
To: Nathan Bossart <nathandbossart@gmail.com>, Robert Treat <rob@xzilla.net>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Gurjeet Singh
 <gurjeet@singh.im>, Andres Freund <andres@anarazel.de>,
 Will Storey <will@summercat.com>, Robert Haas <robertmhaas@gmail.com>,
 Postgres Hackers <pgsql-hackers@postgresql.org>
References: <CA+TgmoZMXN19eorKdeiiFCv3AJFVaUAfkzRuamnt8A9U8uJSqg@mail.gmail.com>
 <Z7Tl2d7HrG1AQEOc@nathan>
 <CABwTF4XPc1_y=khhjErd=Oz8R20ZH05KigiAnMjjA+028QbohQ@mail.gmail.com>
 <Z8H-tHaYZ37lVZHb@nathan>
 <28773a66-fb88-41cf-a7ec-4216e6c91c94@oss.nttdata.com>
 <Z9ROT9v4rHjDYWNX@nathan>
 <CABwTF4WFp-oNSm6utik6g-1HZBxijTJBcuX7BKD8MYqza+KMnw@mail.gmail.com>
 <6f2f2167f4be09e6ca9251c8f69dfe01809d68be.camel@cybertec.at>
 <CABV9wwNagobmRMCxs0dKqWmKXaQTUQj+oOOTw=fsPAgbBfVhew@mail.gmail.com>
 <Z9g8a4HGLUcSo96v@nathan> <Z9ohFZtDaZnkch7u@nathan>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <Z9ohFZtDaZnkch7u@nathan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/88e3b55a-8ef8-4b53-8d71-6bfde1a07bc1%40oss.nttdata.com>
Precedence: bulk


On 2025/03/19 10:42, Nathan Bossart wrote:
> On Mon, Mar 17, 2025 at 10:14:51AM -0500, Nathan Bossart wrote:
>> Thank you all for the discussion.  I've attempted to address the
>> outstanding feedback into the new version of the patch.
> 
> Here is a new version of the patch with tests and some other light edits.
> I feel like this is committable, but I'll wait for a couple more days for
> any other feedback or objections.

+# - Default Behavior -
+
+#vacuum_truncate = on			# enable truncation after vacuum

Since there's no existing GUC category that fits to vacuum_truncate,
I'm fine with adding a new category like "Vacuuming" and placing
vacuum_truncate there.

However, if we do this, ISTM that the new category should also be added to
guc_tables.h, and vacuum_truncate should be assigned to it in guc_tables.c.
Additionally, the documentation should be updated to include
the new category, with vacuum_truncate placed under it. Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION