public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: g l <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: 回复: are the 2 if-statements in join_is_legal() removable?
Date: Sun, 11 May 2025 11:31:39 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <SY6P282MB3797A6DF372EAB398EFA5D6EDA94A@SY6P282MB3797.AUSP282.PROD.OUTLOOK.COM>
References: <SY6P282MB3797B4D591EE5A3953F40C9EDA95A@SY6P282MB3797.AUSP282.PROD.OUTLOOK.COM>
	<[email protected]>
	<SY6P282MB3797A6DF372EAB398EFA5D6EDA94A@SY6P282MB3797.AUSP282.PROD.OUTLOOK.COM>

g l <[email protected]> writes:
> Then I run the core regression tests with "make installcheck-parallel
> " for v18beta1 as the document dictates. When the regression test is done, only the last 2 log entries are found in logfile, the first 2 entries are not printed at all. I run core regression also with v14.15 and v17.2, the results are the same. What test suite do I need to run to cover the first 2 branches, or could you please show me a example query that can cover them? Thank you very much.

The coverage.postgresql.org results are, I believe, for check-world
not just the core tests.  You might try contrib/postgres_fdw first,
as that tends to be the non-core test with the most planner coverage.

In any case, the fact that a few of these lines are not reached by
test cases doesn't constitute a bug, and it most certainly doesn't
mean it'd be safe to remove them.  Most of the logic in join_is_legal
comes in symmetrical pairs of cases for the two possible orderings
of the two input relations.  It's just coincidental which of a pair
of cases will be exercised by a given phrasing of a SQL query.
So I don't feel that we're particularly short on coverage here:
one or the other code path is fully exercised in each case,
according to the coverage.postgresql.org results.

			regards, tom lane

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: 回复: are the 2 if-statements in join_is_legal() removable?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox