Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEZzH-00014B-GX for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Jul 2022 17:29:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oEZzG-00043s-4P for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Jul 2022 17:29:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEZzF-00040I-NK for pgsql-hackers@lists.postgresql.org; Thu, 21 Jul 2022 17:29:21 +0000 Received: from mout-b-203.mailbox.org ([195.10.208.52]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEZzC-0005Un-HV for pgsql-hackers@lists.postgresql.org; Thu, 21 Jul 2022 17:29:21 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-203.mailbox.org (Postfix) with ESMTPS id 4Lpfgv0htMz9svb; Thu, 21 Jul 2022 19:29:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aboutsource.net; s=MBO0001; t=1658424555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O6mW70MctkMRCmXrgzoMevxv0NCxvhO2XkO6Go0a47o=; b=WWmNCC4kAz38rUZXMUq13tj8YdVXzYX2//hTidIkZq/1SIUGsKWwbEvHXOu981yqC5t/p6 Qf9oH6s9OMgrrvAjFzePvv5rNKX+vYkab79iexFCErucQkCWbogT/eGdAreICRhTS3L6DY mGZHksPerbIGlSmdmp+TXlgZI6Ef9BbtAwMWvPGn5eCfBixlr5fuxoRm1XEhpGzQNHPRvu 1GIKKsXszggiJm8N4DpYVpt+mDAc0YKeLSs467LJb6irmwjdKaH90sCKE3WR2lhZfXZv3R rBQJq8G0AOdbU4+dlzYgbrrlew8QzNNJ5P3bRCVcnP3BG3ORu6Ft90A5gVKPwA== Content-Type: multipart/mixed; boundary="------------N0IOwqGWj2nRYoHfV6Y67J7D" Message-ID: <89a4a463-0075-7f6c-e8e4-12a6e1d84eee@aboutsource.net> Date: Thu, 21 Jul 2022 19:29:12 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] Introduce array_shuffle() and array_sample() Content-Language: de-DE To: Dean Rasheed Cc: Tom Lane , Robert Haas , Andrew Dunstan , John Naylor , Thomas Munro , PostgreSQL Hackers References: <9d160a44-7675-51e8-60cf-6d64b76db831@aboutsource.net> <5ef15c6f-e108-53af-3d82-587fac394f1a@aboutsource.net> <463181.1658097987@sss.pgh.pa.us> <5b7a1ee9-f942-2502-3a0c-e9fc12511139@aboutsource.net> <469954.1658100033@sss.pgh.pa.us> <687490.1658152096@sss.pgh.pa.us> <1708d95a-629e-5ac5-deab-d20a8d0b2b0e@aboutsource.net> <809171.1658176490@sss.pgh.pa.us> <817328.1658178181@sss.pgh.pa.us> <0b5dea2b-37fa-6c81-ea9d-0341ab6f87d6@aboutsource.net> <091a9f69-1e5d-6558-41a7-2607a5fc9ff7@aboutsource.net> <1064800.1658240423@sss.pgh.pa.us> <7e7cf274-09cb-00cf-1715-979f011e40b0@aboutsource.net> From: Martin Kalcher In-Reply-To: X-Rspamd-Queue-Id: 4Lpfgv0htMz9svb List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------N0IOwqGWj2nRYoHfV6Y67J7D Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 21.07.22 um 10:41 schrieb Dean Rasheed: > > It's important to mark these new functions as VOLATILE, not IMMUTABLE, > otherwise they won't work as expected in queries. See > https://www.postgresql.org/docs/current/xfunc-volatility.html > > It would be better to use pg_prng_uint64_range() rather than rand() to > pick elements. Partly, that's because it uses a higher quality PRNG, > with a larger internal state, and it ensures that the results are > unbiased across the range. But more importantly, it interoperates with > setseed(), allowing predictable sequences of "random" numbers to be > generated -- something that's useful in writing repeatable regression > tests. > > Assuming these new functions are made to interoperate with setseed(), > which I think they should be, then they also need to be marked as > PARALLEL RESTRICTED, rather than PARALLEL SAFE. See > https://www.postgresql.org/docs/current/parallel-safety.html, which > explains why setseed() and random() are parallel restricted. > Here is an updated patch that marks the functions VOLATILE PARALLEL RESTRICTED and uses pg_prng_uint64_range() rather than rand(). --------------N0IOwqGWj2nRYoHfV6Y67J7D Content-Type: text/x-patch; charset=UTF-8; name="0001-Introduce-array_shuffle-and-array_sample.patch" Content-Disposition: attachment; filename="0001-Introduce-array_shuffle-and-array_sample.patch" Content-Transfer-Encoding: base64 RnJvbSAyNjY3NjgwMmYwNWQwMGMzMWUwYjJkNTk5N2Y2MTczNGFhNDIxZmNhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gS2FsY2hlciA8bWFydGluLmthbGNoZXJA YWJvdXRzb3VyY2UubmV0PgpEYXRlOiBTdW4sIDE3IEp1bCAyMDIyIDE4OjA2OjA0ICswMjAw ClN1YmplY3Q6IFtQQVRDSF0gSW50cm9kdWNlIGFycmF5X3NodWZmbGUoKSBhbmQgYXJyYXlf c2FtcGxlKCkKCiogYXJyYXlfc2h1ZmZsZSgpIHNodWZmbGVzIHRoZSBlbGVtZW50cyBvZiBh biBhcnJheS4KKiBhcnJheV9zYW1wbGUoKSBjaG9vc2VzIG4gZWxlbWVudHMgZnJvbSBhbiBh cnJheSBieSByYW5kb20uCgpTaHVmZmxpbmcgb2YgYXJyYXlzIGNhbiBhbHJlYWR5IGJlIGFj Y29tcGxpc2hlZCB3aXRoIFNRTAp1c2luZyB1bm5lc3QoKSBhbmQgYXJyYXlfYWdnKG9yZGVy IGJ5IHJhbmRvbSgpKS4gQnV0IHRoYXQgaXMKdmVyeSBzbG93IGNvbXBhcmVkIHRvIHRoZSBu ZXcgZnVuY3Rpb25zLiBJbiBhZGRpdGlvbiB0aGUgbmV3IGZ1bmN0aW9ucwphcmUgZGltZW5z aW9uIGF3YXJlLgotLS0KIGRvYy9zcmMvc2dtbC9mdW5jLnNnbWwgICAgICAgICAgICAgICB8 ICAzNSArKysrKwogc3JjL2JhY2tlbmQvdXRpbHMvYWR0L2FycmF5ZnVuY3MuYyAgIHwgMTg5 ICsrKysrKysrKysrKysrKysrKysrKysrKysrLQogc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19w cm9jLmRhdCAgICAgIHwgICA2ICsKIHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvYXJyYXlz Lm91dCB8ICA2MCArKysrKysrKysKIHNyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2FycmF5cy5zcWwg ICAgICB8ICAxNyArKysKIDUgZmlsZXMgY2hhbmdlZCwgMzA2IGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvZnVuYy5zZ21sIGIvZG9j L3NyYy9zZ21sL2Z1bmMuc2dtbAppbmRleCBiNjc4M2I3YWQwLi42Yjk2ODk3MjQ0IDEwMDY0 NAotLS0gYS9kb2Mvc3JjL3NnbWwvZnVuYy5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9mdW5j LnNnbWwKQEAgLTE5Mzk1LDYgKzE5Mzk1LDQxIEBAIFNFTEVDVCBOVUxMSUYodmFsdWUsICco bm9uZSknKSAuLi4KICAgICAgICA8L3BhcmE+PC9lbnRyeT4KICAgICAgIDwvcm93PgogCisg ICAgICA8cm93PgorICAgICAgIDxlbnRyeSByb2xlPSJmdW5jX3RhYmxlX2VudHJ5Ij48cGFy YSByb2xlPSJmdW5jX3NpZ25hdHVyZSI+CisgICAgICAgIDxpbmRleHRlcm0+CisgICAgICAg ICA8cHJpbWFyeT5hcnJheV9zYW1wbGU8L3ByaW1hcnk+CisgICAgICAgIDwvaW5kZXh0ZXJt PgorICAgICAgICA8ZnVuY3Rpb24+YXJyYXlfc2FtcGxlPC9mdW5jdGlvbj4gKCA8cGFyYW1l dGVyPmFycmF5PC9wYXJhbWV0ZXI+IDx0eXBlPmFueWFycmF5PC90eXBlPiwgPHBhcmFtZXRl cj5uPC9wYXJhbWV0ZXI+IDx0eXBlPmludGVnZXI8L3R5cGU+ICkKKyAgICAgICAgPHJldHVy bnZhbHVlPmFueWFycmF5PC9yZXR1cm52YWx1ZT4KKyAgICAgICA8L3BhcmE+CisgICAgICAg PHBhcmE+CisgICAgICAgIFJldHVybnMgPHBhcmFtZXRlcj5uPC9wYXJhbWV0ZXI+IHJhbmRv bWx5IGNob3NlbiBlbGVtZW50cyBmcm9tIDxwYXJhbWV0ZXI+YXJyYXk8L3BhcmFtZXRlcj4u CisgICAgICAgIFRoZSBvcmRlciBvZiB0aGUgZWxlbWVudHMgaW4gcmVzdWx0aW5nIGFycmF5 IGlzIHVuc3BlY2lmaWVkLgorICAgICAgIDwvcGFyYT4KKyAgICAgICA8cGFyYT4KKyAgICAg ICAgPGxpdGVyYWw+YXJyYXlfc2FtcGxlKEFSUkFZW1sxLDJdLFszLDRdLFs1LDZdXSwgMik8 L2xpdGVyYWw+CisgICAgICAgIDxyZXR1cm52YWx1ZT57ezUsNn0sezMsNH19PC9yZXR1cm52 YWx1ZT4KKyAgICAgICA8L3BhcmE+PC9lbnRyeT4KKyAgICAgIDwvcm93PgorCisgICAgICA8 cm93PgorICAgICAgIDxlbnRyeSByb2xlPSJmdW5jX3RhYmxlX2VudHJ5Ij48cGFyYSByb2xl PSJmdW5jX3NpZ25hdHVyZSI+CisgICAgICAgIDxpbmRleHRlcm0+CisgICAgICAgICA8cHJp bWFyeT5hcnJheV9zaHVmZmxlPC9wcmltYXJ5PgorICAgICAgICA8L2luZGV4dGVybT4KKyAg ICAgICAgPGZ1bmN0aW9uPmFycmF5X3NodWZmbGU8L2Z1bmN0aW9uPiAoIDx0eXBlPmFueWFy cmF5PC90eXBlPiApCisgICAgICAgIDxyZXR1cm52YWx1ZT5hbnlhcnJheTwvcmV0dXJudmFs dWU+CisgICAgICAgPC9wYXJhPgorICAgICAgIDxwYXJhPgorICAgICAgICBTaHVmZmxlcyB0 aGUgZmlyc3QgZGltZW5zaW9uIG9mIHRoZSBhcnJheS4KKyAgICAgICA8L3BhcmE+CisgICAg ICAgPHBhcmE+CisgICAgICAgIDxsaXRlcmFsPmFycmF5X3NodWZmbGUoQVJSQVlbWzEsMl0s WzMsNF0sWzUsNl1dKTwvbGl0ZXJhbD4KKyAgICAgICAgPHJldHVybnZhbHVlPnt7NSw2fSx7 Myw0fSx7MSwyfX08L3JldHVybnZhbHVlPgorICAgICAgIDwvcGFyYT48L2VudHJ5PgorICAg ICAgPC9yb3c+CisKICAgICAgIDxyb3c+CiAgICAgICAgPGVudHJ5IHJvbGU9ImZ1bmNfdGFi bGVfZW50cnkiPjxwYXJhIHJvbGU9ImZ1bmNfc2lnbmF0dXJlIj4KICAgICAgICAgPGluZGV4 dGVybSBpZD0iZnVuY3Rpb24tYXJyYXktdG8tc3RyaW5nIj4KZGlmZiAtLWdpdCBhL3NyYy9i YWNrZW5kL3V0aWxzL2FkdC9hcnJheWZ1bmNzLmMgYi9zcmMvYmFja2VuZC91dGlscy9hZHQv YXJyYXlmdW5jcy5jCmluZGV4IGZiMTY3ZjIyNmEuLjY0ZGE5ODAzNDggMTAwNjQ0Ci0tLSBh L3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9hcnJheWZ1bmNzLmMKKysrIGIvc3JjL2JhY2tlbmQv dXRpbHMvYWR0L2FycmF5ZnVuY3MuYwpAQCAtMzQsNyArMzQsNyBAQAogI2luY2x1ZGUgInV0 aWxzL21lbXV0aWxzLmgiCiAjaW5jbHVkZSAidXRpbHMvc2VsZnVuY3MuaCIKICNpbmNsdWRl ICJ1dGlscy90eXBjYWNoZS5oIgotCisjaW5jbHVkZSAiY29tbW9uL3BnX3BybmcuaCIKIAog LyoKICAqIEdVQyBwYXJhbWV0ZXIKQEAgLTY4NzIsMyArNjg3MiwxOTAgQEAgdHJpbV9hcnJh eShQR19GVU5DVElPTl9BUkdTKQogCiAJUEdfUkVUVVJOX0RBVFVNKHJlc3VsdCk7CiB9CisK Ky8qCisgKiBQcm9kdWNlIGFycmF5IHdpdGggbWF4IG4gcmFuZG9tIGl0ZW1zIGZyb20gZ2l2 ZW4gYXJyYXkgaW4gcmFuZG9tIG9yZGVyLgorICoKKyAqIGFycmF5OiBhcnJheSBvYmplY3Qg dG8gZXhhbWluZSAobXVzdCBub3QgYmUgTlVMTCkKKyAqIG46IG1heCBudW1iZXIgb2YgaXRl bXMKKyAqIGVsbXR5cCwgZWxtbGVuLCBlbG1ieXZhbCwgZWxtYWxpZ246IGluZm8gZm9yIHRo ZSBkYXRhdHlwZSBvZiB0aGUgaXRlbXMKKyAqCisgKiBOT1RFOiBpdCB3b3VsZCBiZSBjbGVh bmVyIHRvIGxvb2sgdXAgdGhlIGVsbWxlbi9lbG1idmFsL2VsbWFsaWduIGluZm8KKyAqIGZy b20gdGhlIHN5c3RlbSBjYXRhbG9ncywgZ2l2ZW4gdGhlIGVsbXR5cGUuICBIb3dldmVyLCB0 aGUgY2FsbGVyIGlzCisgKiBpbiBhIGJldHRlciBwb3NpdGlvbiB0byBjYWNoZSB0aGlzIGlu Zm8gYWNyb3NzIG11bHRpcGxlIHVzZXMsIG9yIGV2ZW4KKyAqIHRvIGhhcmQtd2lyZSB2YWx1 ZXMgaWYgdGhlIGVsZW1lbnQgdHlwZSBpcyBoYXJkLXdpcmVkLgorICovCitzdGF0aWMgQXJy YXlUeXBlICoKK2FycmF5X3NodWZmbGVfbihBcnJheVR5cGUgKmFycmF5LCBpbnQgbiwKKwkJ CQlPaWQgZWxtdHlwLCBpbnQgZWxtbGVuLCBib29sIGVsbWJ5dmFsLCBjaGFyIGVsbWFsaWdu KQoreworCUFycmF5VHlwZSAgKnJlc3VsdDsKKwlpbnQJCQluZGltLAorCQkJICAgKmRpbXMs CisJCQkgICAqbGJzLAorCQkJCXJkaW1zW01BWERJTV0sCisJCQkJbmVsbSwKKwkJCQluaXRl bSwKKwkJCQlpLAorCQkJCWosCisJCQkJazsKKwlEYXR1bQkJZWxtLAorCQkJICAgKmVsbXMs CisJCQkgICAqcmVsbXM7CisJYm9vbAkJbnVsLAorCQkJICAgKm51bHMsCisJCQkgICAqcm51 bHM7CisKKwluZGltID0gQVJSX05ESU0oYXJyYXkpOworCWRpbXMgPSBBUlJfRElNUyhhcnJh eSk7CisJbGJzID0gQVJSX0xCT1VORChhcnJheSk7CisKKwlpZiAobmRpbSA8IDEgfHwgZGlt c1swXSA8IDEgfHwgbiA8IDEpCisJCXJldHVybiBjb25zdHJ1Y3RfZW1wdHlfYXJyYXkoZWxt dHlwKTsKKworCWRlY29uc3RydWN0X2FycmF5KGFycmF5LCBlbG10eXAsIGVsbWxlbiwgZWxt Ynl2YWwsIGVsbWFsaWduLAorCQkJCQkgICZyZWxtcywgJnJudWxzLCAmbmVsbSk7CisKKwkv KiBDYWxjdWxhdGUgbnVtYmVyIG9mIGVsZW1lbnRzIHBlciBpdGVtLiAqLworCW5lbG0gPSAo bmRpbSA+IDEpID8gQXJyYXlHZXROSXRlbXMobmRpbSAtIDEsIGRpbXMgKyAxKSA6IDE7CisJ ZWxtcyA9IHJlbG1zOworCW51bHMgPSBybnVsczsKKwluaXRlbSA9IGRpbXNbMF07CisJbiA9 IE1pbihuLCBuaXRlbSk7CisKKwkvKgorCSAqIFNodWZmbGUgYXJyYXkgdXNpbmcgRmlzaGVy LVlhdGVzIGFsZ29yaXRobS4gU3dhcCBoZWFkIHdpdGggYW4gcmFuZG9tbHkKKwkgKiBjaG9z ZW4gaXRlbSBhbmQgaW5jcmVtZW50IGhlYWQuCisJICovCisJZm9yIChpID0gMDsgaSA8IG47 IGkrKykKKwl7CisJCWsgPSAoaW50KSBwZ19wcm5nX3VpbnQ2NF9yYW5nZSgmcGdfZ2xvYmFs X3Bybmdfc3RhdGUsIDAsIG5pdGVtIC0gaSAtIDEpICogbmVsbTsKKworCQkvKiBTd2FwIGFs bCBlbGVtZW50cyBpbiBoZWFkIHdpdGggZWxlbWVudHMgaW4gaXRlbSBrLiAqLworCQlmb3Ig KGogPSAwOyBqIDwgbmVsbTsgaisrKQorCQl7CisJCQllbG0gPSAqZWxtczsKKwkJCW51bCA9 ICpudWxzOworCQkJKmVsbXMgPSBlbG1zW2tdOworCQkJKm51bHMgPSBudWxzW2tdOworCQkJ ZWxtc1trXSA9IGVsbTsKKwkJCW51bHNba10gPSBudWw7CisJCQllbG1zKys7CisJCQludWxz Kys7CisJCX0KKwl9CisKKwltZW1jcHkocmRpbXMsIGRpbXMsIG5kaW0gKiBzaXplb2YoaW50 KSk7CisJcmRpbXNbMF0gPSBuOworCisJcmVzdWx0ID0gY29uc3RydWN0X21kX2FycmF5KHJl bG1zLCBybnVscywgbmRpbSwgcmRpbXMsIGxicywKKwkJCQkJCQkJZWxtdHlwLCBlbG1sZW4s IGVsbWJ5dmFsLCBlbG1hbGlnbik7CisKKwlwZnJlZShyZWxtcyk7CisJcGZyZWUocm51bHMp OworCisJcmV0dXJuIHJlc3VsdDsKK30KKworLyoKKyAqIFNodWZmbGUgdGhlIGVsZW1lbnRz IG9mIGFuIGFycmF5LgorICovCitEYXR1bQorYXJyYXlfc2h1ZmZsZShQR19GVU5DVElPTl9B UkdTKQoreworCUFycmF5VHlwZSAgKmFycmF5LAorCQkJICAgKnJlc3VsdDsKKwlpbnQxNgkJ ZWxtbGVuOworCWJvb2wJCWVsbWJ5dmFsOworCWNoYXIJCWVsbWFsaWduOworCU9pZAkJCWVs bXR5cDsKKwlUeXBlQ2FjaGVFbnRyeSAqdHlwZW50cnk7CisJaW50CQkJbjsKKworCWFycmF5 ID0gUEdfR0VUQVJHX0FSUkFZVFlQRV9QKDApOworCisJLyogUmV0dXJuIGVtcHR5IGFycmF5 IGltbWVkaWF0ZWx5LiAqLworCWlmIChBUlJfTkRJTShhcnJheSkgPCAxKQorCQlQR19SRVRV Uk5fQVJSQVlUWVBFX1AoYXJyYXkpOworCisJbiA9IEFSUl9ESU1TKGFycmF5KVswXTsKKwor CS8qIFRoZXJlIGlzIG5vIHBvaW50IGluIHNodWZmbGluZyBhcnJheXMgd2l0aCBsZXNzIHRo ZW4gdHdvIGl0ZW1zLiAqLworCWlmIChuIDwgMikKKwkJUEdfUkVUVVJOX0FSUkFZVFlQRV9Q KGFycmF5KTsKKworCWVsbXR5cCA9IEFSUl9FTEVNVFlQRShhcnJheSk7CisJdHlwZW50cnkg PSAoVHlwZUNhY2hlRW50cnkgKikgZmNpbmZvLT5mbGluZm8tPmZuX2V4dHJhOworCWlmICh0 eXBlbnRyeSA9PSBOVUxMIHx8IHR5cGVudHJ5LT50eXBlX2lkICE9IGVsbXR5cCkKKwl7CisJ CXR5cGVudHJ5ID0gbG9va3VwX3R5cGVfY2FjaGUoZWxtdHlwLCAwKTsKKwkJZmNpbmZvLT5m bGluZm8tPmZuX2V4dHJhID0gKHZvaWQgKikgdHlwZW50cnk7CisJfQorCWVsbWxlbiA9IHR5 cGVudHJ5LT50eXBsZW47CisJZWxtYnl2YWwgPSB0eXBlbnRyeS0+dHlwYnl2YWw7CisJZWxt YWxpZ24gPSB0eXBlbnRyeS0+dHlwYWxpZ247CisKKwlyZXN1bHQgPSBhcnJheV9zaHVmZmxl X24oYXJyYXksIG4sCisJCQkJCQkJIGVsbXR5cCwgZWxtbGVuLCBlbG1ieXZhbCwgZWxtYWxp Z24pOworCisJUEdfRlJFRV9JRl9DT1BZKGFycmF5LCAwKTsKKworCVBHX1JFVFVSTl9BUlJB WVRZUEVfUChyZXN1bHQpOworfQorCisvKgorICogQ2hvb3NlIE4gcmFuZG9tIGVsZW1lbnRz IGZyb20gYW4gYXJyYXkuCisgKi8KK0RhdHVtCithcnJheV9zYW1wbGUoUEdfRlVOQ1RJT05f QVJHUykKK3sKKwlBcnJheVR5cGUgICphcnJheSwKKwkJCSAgICpyZXN1bHQ7CisJaW50MTYJ CWVsbWxlbjsKKwlib29sCQllbG1ieXZhbDsKKwljaGFyCQllbG1hbGlnbjsKKwlPaWQJCQll bG10eXA7CisJVHlwZUNhY2hlRW50cnkgKnR5cGVudHJ5OworCWludAkJCW47CisKKwlhcnJh eSA9IFBHX0dFVEFSR19BUlJBWVRZUEVfUCgwKTsKKwluID0gUEdfR0VUQVJHX0lOVDMyKDEp OworCisJaWYgKG4gPCAwKQorCQllcmVwb3J0KEVSUk9SLAorCQkJCShlcnJjb2RlKEVSUkNP REVfSU5WQUxJRF9QQVJBTUVURVJfVkFMVUUpLAorCQkJCSBlcnJtc2coInNlY29uZCBwYXJh bWV0ZXIgbXVzdCBub3QgYmUgbmVnYXRpdmUiKSkpOworCisJZWxtdHlwID0gQVJSX0VMRU1U WVBFKGFycmF5KTsKKworCS8qIFJldHVybiBhbiBlbXB0eSBhcnJheSBpZiB0aGUgcmVxdWVz dGVkIHNhbXBsZSBzaXplIGlzIHplcm8uICovCisJaWYgKG4gPT0gMCkKKwl7CisJCVBHX0ZS RUVfSUZfQ09QWShhcnJheSwgMCk7CisJCVBHX1JFVFVSTl9BUlJBWVRZUEVfUChjb25zdHJ1 Y3RfZW1wdHlfYXJyYXkoZWxtdHlwKSk7CisJfQorCisJLyoKKwkgKiBSZXR1cm4gdGhlIG9y aWdpbmFsIGFycmF5IGlmIGl0cyBzaXplIGlzIGxlc3MgdGhhbiBvciBlcXVhbCB0byB0aGUK KwkgKiByZXF1ZXN0ZWQgc2FtcGxlIHNpemUuCisJICovCisJaWYgKEFSUl9ORElNKGFycmF5 KSA8IDEgfHwgQVJSX0RJTVMoYXJyYXkpWzBdIDw9IG4pCisJCVBHX1JFVFVSTl9BUlJBWVRZ UEVfUChhcnJheSk7CisKKwl0eXBlbnRyeSA9IChUeXBlQ2FjaGVFbnRyeSAqKSBmY2luZm8t PmZsaW5mby0+Zm5fZXh0cmE7CisJaWYgKHR5cGVudHJ5ID09IE5VTEwgfHwgdHlwZW50cnkt PnR5cGVfaWQgIT0gZWxtdHlwKQorCXsKKwkJdHlwZW50cnkgPSBsb29rdXBfdHlwZV9jYWNo ZShlbG10eXAsIDApOworCQlmY2luZm8tPmZsaW5mby0+Zm5fZXh0cmEgPSAodm9pZCAqKSB0 eXBlbnRyeTsKKwl9CisJZWxtbGVuID0gdHlwZW50cnktPnR5cGxlbjsKKwllbG1ieXZhbCA9 IHR5cGVudHJ5LT50eXBieXZhbDsKKwllbG1hbGlnbiA9IHR5cGVudHJ5LT50eXBhbGlnbjsK KworCXJlc3VsdCA9IGFycmF5X3NodWZmbGVfbihhcnJheSwgbiwKKwkJCQkJCQkgZWxtdHlw LCBlbG1sZW4sIGVsbWJ5dmFsLCBlbG1hbGlnbik7CisKKwlQR19GUkVFX0lGX0NPUFkoYXJy YXksIDApOworCisJUEdfUkVUVVJOX0FSUkFZVFlQRV9QKHJlc3VsdCk7Cit9CmRpZmYgLS1n aXQgYS9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0IGIvc3JjL2luY2x1ZGUvY2F0 YWxvZy9wZ19wcm9jLmRhdAppbmRleCAyZTQxZjRkOWU4Li45OTMzZDEwZjZkIDEwMDY0NAot LS0gYS9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2MuZGF0CisrKyBiL3NyYy9pbmNsdWRl L2NhdGFsb2cvcGdfcHJvYy5kYXQKQEAgLTE2ODEsNiArMTY4MSwxMiBAQAogICBwcm9uYW1l ID0+ICdhcnJheWNvbnRqb2luc2VsJywgcHJvdm9sYXRpbGUgPT4gJ3MnLCBwcm9yZXR0eXBl ID0+ICdmbG9hdDgnLAogICBwcm9hcmd0eXBlcyA9PiAnaW50ZXJuYWwgb2lkIGludGVybmFs IGludDIgaW50ZXJuYWwnLAogICBwcm9zcmMgPT4gJ2FycmF5Y29udGpvaW5zZWwnIH0sCit7 IG9pZCA9PiAnODQ2NCcsIGRlc2NyID0+ICdzaHVmZmxlIGFycmF5JywKKyAgcHJvbmFtZSA9 PiAnYXJyYXlfc2h1ZmZsZScsIHByb3ZvbGF0aWxlID0+ICd2JywgcHJvcGFyYWxsZWwgPT4g J3InLCBwcm9pc3N0cmljdCA9PiAndCcsCisgIHByb3JldHR5cGUgPT4gJ2FueWFycmF5Jywg cHJvYXJndHlwZXMgPT4gJ2FueWFycmF5JywgcHJvc3JjID0+ICdhcnJheV9zaHVmZmxlJyB9 LAoreyBvaWQgPT4gJzg0NjUnLCBkZXNjciA9PiAndGFrZSBzYW1wbGVzIGZyb20gYXJyYXkn LAorICBwcm9uYW1lID0+ICdhcnJheV9zYW1wbGUnLCBwcm92b2xhdGlsZSA9PiAndicsIHBy b3BhcmFsbGVsID0+ICdyJywgcHJvaXNzdHJpY3QgPT4gJ3QnLAorICBwcm9yZXR0eXBlID0+ ICdhbnlhcnJheScsIHByb2FyZ3R5cGVzID0+ICdhbnlhcnJheSBpbnQ0JywgcHJvc3JjID0+ ICdhcnJheV9zYW1wbGUnIH0sCiAKIHsgb2lkID0+ICc3NjQnLCBkZXNjciA9PiAnbGFyZ2Ug b2JqZWN0IGltcG9ydCcsCiAgIHByb25hbWUgPT4gJ2xvX2ltcG9ydCcsIHByb3ZvbGF0aWxl ID0+ICd2JywgcHJvcGFyYWxsZWwgPT4gJ3UnLApkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVn cmVzcy9leHBlY3RlZC9hcnJheXMub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9h cnJheXMub3V0CmluZGV4IGNlNmYzYTY1ZjkuLjFlYjdlZjM3Y2YgMTAwNjQ0Ci0tLSBhL3Ny Yy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvYXJyYXlzLm91dAorKysgYi9zcmMvdGVzdC9yZWdy ZXNzL2V4cGVjdGVkL2FycmF5cy5vdXQKQEAgLTI0NDUsMyArMjQ0NSw2MyBAQCBTRUxFQ1Qg dHJpbV9hcnJheShBUlJBWVsxLCAyLCAzXSwgLTEpOyAtLSBmYWlsCiBFUlJPUjogIG51bWJl ciBvZiBlbGVtZW50cyB0byB0cmltIG11c3QgYmUgYmV0d2VlbiAwIGFuZCAzCiBTRUxFQ1Qg dHJpbV9hcnJheShBUlJBWVsxLCAyLCAzXSwgMTApOyAtLSBmYWlsCiBFUlJPUjogIG51bWJl ciBvZiBlbGVtZW50cyB0byB0cmltIG11c3QgYmUgYmV0d2VlbiAwIGFuZCAzCistLSBhcnJh eV9zaHVmZmxlCitTRUxFQ1QgYXJyYXlfYWdnKGEgb3JkZXIgYnkgYSkKK0ZST00KKyhTRUxF Q1QgdW5uZXN0KGFycmF5X3NodWZmbGUoJ3tOVUxMLDEsMiwzLDQsNX0nOjppbnRbXSkpKSB2 KGEpOworICAgIGFycmF5X2FnZyAgICAgCistLS0tLS0tLS0tLS0tLS0tLS0KKyB7MSwyLDMs NCw1LE5VTEx9CisoMSByb3cpCisKK1NFTEVDVCBhcnJheV9kaW1zKGFycmF5X3NodWZmbGUo J3t7MSwyLDN9LHs0LDUsNn19Jzo6aW50W11bXSkpOworIGFycmF5X2RpbXMgCistLS0tLS0t LS0tLS0KKyBbMToyXVsxOjNdCisoMSByb3cpCisKK1NFTEVDVCBhcnJheV9kaW1zKGFycmF5 X3NodWZmbGUoJ1stMToxXT17MSwyLDN9Jzo6aW50W10pKTsKKyBhcnJheV9kaW1zIAorLS0t LS0tLS0tLS0tCisgWy0xOjFdCisoMSByb3cpCisKK1NFTEVDVCAoYXJyYXlfc2h1ZmZsZSgn e3sxLDJ9LHszLDR9LHs1LDZ9fSc6OmludFtdW10pKVsxOl1bMV0gPEAgJ3sxLDMsNX0nOjpp bnRbXTsKKyA/Y29sdW1uPyAKKy0tLS0tLS0tLS0KKyB0CisoMSByb3cpCisKKy0tIGFycmF5 X3NhbXBsZQorU0VMRUNUIGNhcmRpbmFsaXR5KGFycmF5X3NhbXBsZSgne05VTEwsMSwyLDMs NCw1fSc6OmludFtdLCAzKSk7CisgY2FyZGluYWxpdHkgCistLS0tLS0tLS0tLS0tCisgICAg ICAgICAgIDMKKygxIHJvdykKKworU0VMRUNUIGFycmF5X3NhbXBsZSgnezEsMiwzLDQsNX0n OjppbnRbXSwgMykgPEAgJ3sxLDIsMyw0LDV9Jzo6aW50W107CisgP2NvbHVtbj8gCistLS0t LS0tLS0tCisgdAorKDEgcm93KQorCitTRUxFQ1QgYXJyYXlfc2FtcGxlKCd7MSwyLDMsNCw1 fSc6OmludFtdLCAxMCkgPEAgJ3sxLDIsMyw0LDV9Jzo6aW50W107CisgP2NvbHVtbj8gCist LS0tLS0tLS0tCisgdAorKDEgcm93KQorCitTRUxFQ1QgYXJyYXlfZGltcyhhcnJheV9zYW1w bGUoJ3t7MSwyfSx7Myw0fSx7NCw1fSx7Niw3fX0nOjppbnRbXVtdLCAzKSk7CisgYXJyYXlf ZGltcyAKKy0tLS0tLS0tLS0tLQorIFsxOjNdWzE6Ml0KKygxIHJvdykKKworU0VMRUNUIGFy cmF5X2RpbXMoYXJyYXlfc2FtcGxlKCdbLTE6MV09ezEsMiwzfSc6OmludFtdLCAyKSk7Cisg YXJyYXlfZGltcyAKKy0tLS0tLS0tLS0tLQorIFstMTowXQorKDEgcm93KQorCitTRUxFQ1Qg YXJyYXlfc2FtcGxlKCd7MSwyLDMsNCw1fSc6OmludFtdLCAtMSk7IC0tIGZhaWwKK0VSUk9S OiAgc2Vjb25kIHBhcmFtZXRlciBtdXN0IG5vdCBiZSBuZWdhdGl2ZQpkaWZmIC0tZ2l0IGEv c3JjL3Rlc3QvcmVncmVzcy9zcWwvYXJyYXlzLnNxbCBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3Fs L2FycmF5cy5zcWwKaW5kZXggZjc3NGZhZjg1Ni4uNWRhZWU5YWE3MiAxMDA2NDQKLS0tIGEv c3JjL3Rlc3QvcmVncmVzcy9zcWwvYXJyYXlzLnNxbAorKysgYi9zcmMvdGVzdC9yZWdyZXNz L3NxbC9hcnJheXMuc3FsCkBAIC03NTQsMyArNzU0LDIwIEBAIEZST00KIAogU0VMRUNUIHRy aW1fYXJyYXkoQVJSQVlbMSwgMiwgM10sIC0xKTsgLS0gZmFpbAogU0VMRUNUIHRyaW1fYXJy YXkoQVJSQVlbMSwgMiwgM10sIDEwKTsgLS0gZmFpbAorCistLSBhcnJheV9zaHVmZmxlCitT RUxFQ1QgYXJyYXlfYWdnKGEgb3JkZXIgYnkgYSkKK0ZST00KKyhTRUxFQ1QgdW5uZXN0KGFy cmF5X3NodWZmbGUoJ3tOVUxMLDEsMiwzLDQsNX0nOjppbnRbXSkpKSB2KGEpOworCitTRUxF Q1QgYXJyYXlfZGltcyhhcnJheV9zaHVmZmxlKCd7ezEsMiwzfSx7NCw1LDZ9fSc6OmludFtd W10pKTsKK1NFTEVDVCBhcnJheV9kaW1zKGFycmF5X3NodWZmbGUoJ1stMToxXT17MSwyLDN9 Jzo6aW50W10pKTsKK1NFTEVDVCAoYXJyYXlfc2h1ZmZsZSgne3sxLDJ9LHszLDR9LHs1LDZ9 fSc6OmludFtdW10pKVsxOl1bMV0gPEAgJ3sxLDMsNX0nOjppbnRbXTsKKworLS0gYXJyYXlf c2FtcGxlCitTRUxFQ1QgY2FyZGluYWxpdHkoYXJyYXlfc2FtcGxlKCd7TlVMTCwxLDIsMyw0 LDV9Jzo6aW50W10sIDMpKTsKK1NFTEVDVCBhcnJheV9zYW1wbGUoJ3sxLDIsMyw0LDV9Jzo6 aW50W10sIDMpIDxAICd7MSwyLDMsNCw1fSc6OmludFtdOworU0VMRUNUIGFycmF5X3NhbXBs ZSgnezEsMiwzLDQsNX0nOjppbnRbXSwgMTApIDxAICd7MSwyLDMsNCw1fSc6OmludFtdOwor U0VMRUNUIGFycmF5X2RpbXMoYXJyYXlfc2FtcGxlKCd7ezEsMn0sezMsNH0sezQsNX0sezYs N319Jzo6aW50W11bXSwgMykpOworU0VMRUNUIGFycmF5X2RpbXMoYXJyYXlfc2FtcGxlKCdb LTE6MV09ezEsMiwzfSc6OmludFtdLCAyKSk7CitTRUxFQ1QgYXJyYXlfc2FtcGxlKCd7MSwy LDMsNCw1fSc6OmludFtdLCAtMSk7IC0tIGZhaWwKLS0gCjIuMzcuMQoK --------------N0IOwqGWj2nRYoHfV6Y67J7D--