Feedback-ID: i76984098:Fastmail
Message-ID: <92405f98-7f0c-4442-8252-697352daefc1@aklaver.com>
Date: Sun, 1 Dec 2024 13:08:28 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Errors when restoring backup created by pg_dumpall
To: PopeRigby <poperigby@mailbox.org>, Tom Lane <tgl@sss.pgh.pa.us>,
 "David G. Johnston" <david.g.johnston@gmail.com>
Cc: "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
References: <6a6439f1-8039-44e2-8fb9-59028f7f2014@mailbox.org>
 <cba48d2c-0987-4233-a86f-2e693677efd3@aklaver.com>
 <9c5ba566-27b8-4e8c-bf7d-2dc561509991@mailbox.org>
 <CAKFQuwaB5GuUNuyiUbS0ah-LYXepHLPnOHrP7g8RMz8ywOm3zQ@mail.gmail.com>
 <ff94f628-27af-4c3a-9590-cba38bb5d2d1@mailbox.org>
 <CAKFQuwYQUequkYVS8SLgC1L0TOdWNK=xVyxnPD9RPPwfvYRFSQ@mail.gmail.com>
 <41791b6d-aaf5-4fed-9cc3-e89bc49e8637@mailbox.org>
 <CAKFQuwbe4TSU_LxsrGxgcv4DfQq2x-UNoyKx-ABy36PhvbGCdg@mail.gmail.com>
 <1257068.1733025493@sss.pgh.pa.us>
 <06425038-e012-4bac-aec1-d9541436f893@mailbox.org>
Content-Language: en-US
From: Adrian Klaver <adrian.klaver@aklaver.com>
In-Reply-To: <06425038-e012-4bac-aec1-d9541436f893@mailbox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/92405f98-7f0c-4442-8252-697352daefc1%40aklaver.com>
Precedence: bulk

On 12/1/24 12:05, PopeRigby wrote:
> On 11/30/24 19:58, Tom Lane wrote:
>> "David G. Johnston" <david.g.johnston@gmail.com> writes:
>>> Ok, so the error is not emanating from your code but rather the body 
>>> of the
>>> ll_to_earth function defined in the earthdistance extension.
>> Yeah.  That is
>>
>> CREATE FUNCTION ll_to_earth(float8, float8)
>> RETURNS earth
>> LANGUAGE SQL
>> IMMUTABLE STRICT
>> PARALLEL SAFE
>> AS 'SELECT 
>> cube(cube(cube(earth()*cos(radians($1))*cos(radians($2))),earth()*cos(radians($1))*sin(radians($2))),earth()*sin(radians($1)))::earth';
>>
>> which is problematic: the function calls are not schema-qualified and
>> there's not a really easy way to fix that.  There's work afoot to fix
>> that [1], but it's not committed yet let alone in any shipping
>> version.  Nonetheless, your best bet for fixing this might be
>> to install the earthdistance 1.2 files from the latest patchset in
>> that thread.
>>
>>             regards, tom lane
>>
>> [1] 
>> https://www.postgresql.org/message-id/flat/3395418.1618352794@sss.pgh.pa.us
> 
> I've applied the following patch to postgres:
> 
> https://www.postgresql.org/message-id/attachment/122092/0002-earthdistance-sql-functions.patch
> 
> I'm still getting this error:
> 
> psql:all.sql:4102: ERROR:  type "earth" does not exist
> LINE 1: ...ians($1))*sin(radians($2))),earth()*sin(radians($1)))::earth
> 

The issue is still this:

SELECT pg_catalog.set_config('search_path', '', false);

in the pg_dumpall output.

As was suggested before change the above to:

SELECT pg_catalog.set_config('search_path', 'public', false);

in the pg_dumpall output file.


-- 
Adrian Klaver
adrian.klaver@aklaver.com