Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ttS3d-00Cd8z-Qt
	for pgsql-hackers@arkaria.postgresql.org; Sat, 15 Mar 2025 14:00:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ttS3c-00EX1w-AJ
	for pgsql-hackers@arkaria.postgresql.org; Sat, 15 Mar 2025 14:00:08 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1ttS3c-00EX1h-02
	for pgsql-hackers@lists.postgresql.org; Sat, 15 Mar 2025 14:00:08 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps  (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1ttS3Z-002yuH-0W
	for pgsql-hackers@postgresql.org;
	Sat, 15 Mar 2025 14:00:07 +0000
Received: from [192.168.11.5] (p1695135-ipoe.ipoe.ocn.ne.jp [118.0.92.134])
	by oss.nttdata.com (Postfix) with ESMTPSA id 4F2D360716;
	Sat, 15 Mar 2025 23:00:00 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
Message-ID: <92865dc2-9b2b-45ad-aa5a-7364dcdb5e38@oss.nttdata.com>
Date: Sat, 15 Mar 2025 22:59:59 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Disabling vacuum truncate for autovacuum
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Gurjeet Singh <gurjeet@singh.im>, Robert Haas <robertmhaas@gmail.com>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
 Postgres Hackers <pgsql-hackers@postgresql.org>,
 Will Storey <will@summercat.com>
References: <Z2DE4lDX4tHqNGZt@dev.null>
 <fa83a77bbca5da4d4864a49c8a27df323f23d28b.camel@cybertec.at>
 <CABwTF4U3xkF=ZRi2pztUDxohoN8h6XL10=QmTtuTXoMjzu5-zg@mail.gmail.com>
 <f82fc7fbb69a8c8000ad74ced50381257fe57838.camel@cybertec.at>
 <CA+TgmoZMXN19eorKdeiiFCv3AJFVaUAfkzRuamnt8A9U8uJSqg@mail.gmail.com>
 <Z7Tl2d7HrG1AQEOc@nathan>
 <CABwTF4XPc1_y=khhjErd=Oz8R20ZH05KigiAnMjjA+028QbohQ@mail.gmail.com>
 <Z8H-tHaYZ37lVZHb@nathan>
 <28773a66-fb88-41cf-a7ec-4216e6c91c94@oss.nttdata.com>
 <Z9ROT9v4rHjDYWNX@nathan>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <Z9ROT9v4rHjDYWNX@nathan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/92865dc2-9b2b-45ad-aa5a-7364dcdb5e38%40oss.nttdata.com>
Precedence: bulk



On 2025/03/15 0:42, Nathan Bossart wrote:
> I should also mention that we just have a few weeks left in the v18
> development cycle.  The code itself seems pretty straightforward, so if we
> can agree on behavior and nomenclature, I'll do my darndest to get this
> responsibly committed in time.

+1

Here are two minor review comments from me.

+      <varlistentry id="guc-vacuum-truncate" xreflabel="autovacuum">

This xreflabel should be "vacuum_truncate", not "autovacuum".


-      lock on the table. The <literal>TRUNCATE</literal> parameter
-      of <link linkend="sql-vacuum"><command>VACUUM</command></link>, if specified, overrides the value
-      of this option.
+      Per-table value for <xref linkend="guc-vacuum-truncate"/> parameter.

It was explicitly documented that the TRUNCATE option in the VACUUM
command overrides the vacuum_truncate reloption, but this information
has been removed in the patch. Shouldn't we keep it to clarify
the priority of these settings?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION