Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\))
Subject: Re: Using Expanded Objects other than Arrays from plpgsql
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: <256915.1738533419@sss.pgh.pa.us>
Date: Mon, 3 Feb 2025 14:19:09 +0500
Cc: Pavel Borisov <pashkin.elfe@gmail.com>,
 Michel Pelletier <pelletier.michel@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <932C9840-63D6-469D-9C65-1B1A14594D29@yandex-team.ru>
References: <CACxu=vJaKFNsYxooSnW1wEgsAO5u_v1XYBacfVJ14wgJV_PYeg@mail.gmail.com>
 <1342498.1729444411@sss.pgh.pa.us>
 <CACxu=vLXvpzN4X3k+9jsMt6ujuOvFVUSkA80t_cROSsF4y2jQQ@mail.gmail.com>
 <1445998.1729482404@sss.pgh.pa.us>
 <CACxu=vKEF8Qa-OaADFxf0uMg-xw6gH_CNCWd2s+xaqh-gY4=xg@mail.gmail.com>
 <2062830.1729625620@sss.pgh.pa.us> <2265411.1729699470@sss.pgh.pa.us>
 <CACxu=v++HNmss59yGUDkRny7g=M8tZ2YXF07AUXqKVGqcSfxGQ@mail.gmail.com>
 <2354718.1729737539@sss.pgh.pa.us> <2581216.1729794746@sss.pgh.pa.us>
 <CACxu=v+dn37zr8gx5xNP-EZY3OLtGLTHrbx_ZkCQc40HpyMLKA@mail.gmail.com>
 <1948345.1730500073@sss.pgh.pa.us>
 <CACxu=vL7i_U_iSNpREe8eCAMEyKHuPpk9THRpBhk+ar0U1EdOw@mail.gmail.com>
 <CACxu=vKLc6f5N8_DR58LKkE1eohWSxTvThTeGsLm7p7QH1aFBA@mail.gmail.com>
 <CACxu=vJf2S=ysun_h=zmYNu6oUM47+egbpX5mMC0X9BJK=EQwQ@mail.gmail.com>
 <CACxu=vK+S6BXN8ZYyBvqQBWrcwHXqtue1-ZuKO3+XtHGBYcDUQ@mail.gmail.com>
 <CAFj8pRCd6xcH-AYEyHFdGdU89O9JjZ-v-pyQnOwd9zNJkCEdhQ@mail.gmail.com>
 <3797606.1732045516@sss.pgh.pa.us> <CACxu=! !
 vJ1UeXPjPOzfT2E=tFpSCxPxcB7hgfqHYmefJWh3ZXPew@mail.gmail.com>
 <1417389.1736964543@sss.pgh.pa.us>
 <CACxu=vKModwqSpEjpn-ur1uMAEYkcd-i8CvNsH-z9=dk7F7YQw@mail.gmail.com>
 <3363452.1737483125@sss.pgh.pa.us>
 <0AC229FA-A3F1-43FD-B0DC-A46A73FEAFF7@yandex-team.ru>
 <931398.1737905825@sss.pgh.pa.us>
 <38A31221-C1C4-4846-9709-D66ACD76E87A@yandex-team.ru>
 <46876.1737918281@sss.pgh.pa.us>
 <CALT9ZEGy5+GNQUtR80BPL7k-Qi47sqwPLnN_dOaQUW5UbxcTGA@mail.gmail.com>
 <3682021.1738288421@sss.pgh.pa.us> <256915.1738533419@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/932C9840-63D6-469D-9C65-1B1A14594D29%40yandex-team.ru>
Precedence: bulk


> On 3 Feb 2025, at 02:56, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> I decided to see what would happen if we tried to avoid the code
> duplication in pl_funcs.c by making some "walker" infrastructure
> akin to expression_tree_walker.  While that doesn't seem useful
> for the dump_xxx functions, it works very nicely for the free_xxx
> functions and now for the mark_xxx ones as well.  pl_funcs.c
> nets out about 400 lines shorter than in the v4 patch.  The
> code coverage score for the file is still awful :-(, but that's
> because we're not testing the dump_xxx functions at all.
>=20
> PFA v5.  The new 0001 patch refactors the free_xxx infrastructure
> to create plpgsql_statement_tree_walker(), and then in what's now
> 0003 we can use that instead of writing a lot of duplicate code.


Pre-preliminary refactoring looks good to me, as the rest of the patch =
set.

(Well, maybe paramarg2 resonates a bit, just from similarity with =
varchar2)

ecpg tests seem to fail on Windows[0], but looks like it's not related =
to this thread.


Best regards, Andrey Borodin.

[0] https://cirrus-ci.com/task/4835794898124800=