Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXUmV-0004L5-K2 for pgsql-general@arkaria.postgresql.org; Sun, 11 Sep 2022 21:46:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oXUmU-0003eN-4O for pgsql-general@arkaria.postgresql.org; Sun, 11 Sep 2022 21:46:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXUjQ-0006x0-Bb for pgsql-general@lists.postgresql.org; Sun, 11 Sep 2022 21:43:12 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXUjO-0006wh-Mt for pgsql-general@lists.postgresql.org; Sun, 11 Sep 2022 21:43:11 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 65C0E2F1C40F for ; Sun, 11 Sep 2022 23:43:09 +0200 (CEST) Received: from s981.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 571262E2DA50; Sun, 11 Sep 2022 23:43:09 +0200 (CEST) Received: from s474.loopia.se (unknown [172.22.191.5]) by s981.loopia.se (Postfix) with ESMTP id 51F5322B174E; Sun, 11 Sep 2022 23:43:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.01 X-Spam-Level: X-Spam-Status: No, score=-1.01 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=disabled Received: from s899.loopia.se ([172.22.191.6]) by s474.loopia.se (s474.loopia.se [172.22.190.14]) (amavisd-new, port 10024) with LMTP id sjWZlUW6_hXt; Sun, 11 Sep 2022 23:43:06 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s899.loopia.se (Postfix) with ESMTPSA id E80D32C8BA3B; Sun, 11 Sep 2022 23:43:06 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: lippq client library and openssl initialization: PQinitOpenSSL() From: Daniel Gustafsson In-Reply-To: <1206133.1662932104@sss.pgh.pa.us> Date: Sun, 11 Sep 2022 23:43:06 +0200 Cc: Sebastien Flaesch , "pgsql-general@lists.postgresql.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <816006.1662908880@sss.pgh.pa.us> <9A09E47E-68EB-45DF-A934-FB76F2086D20@yesql.se> <1206133.1662932104@sss.pgh.pa.us> To: Tom Lane X-Mailer: Apple Mail (2.3696.100.31) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 11 Sep 2022, at 23:35, Tom Lane wrote: >=20 > Daniel Gustafsson writes: >> On 11 Sep 2022, at 17:08, Tom Lane wrote: >>> Don't believe so. The HAVE_CRYPTO_LOCK stuff is all obsolete and >>> not compiled if you built against 1.1.0. The only thing left that >>> will happen if you don't call PQinitOpenSSL is an extra call to >>> OPENSSL_init_ssl, which should be harmless as far as I can see >>> from the OpenSSL docs. >=20 >> To the best of my knowledge, thats entirely correct. >=20 > Should we document these functions as obsolete when using > OpenSSL >=3D 1.1.0 ? Given that 1.1.0+ is very common, it's probably not a bad idea to = document them as obsolete but harmless. Unless you beat me to it I can propose a = patch. -- Daniel Gustafsson https://vmware.com/