MIME-Version: 1.0
References: <CA+FnnTyR9AoJx-3zuvgudeYmUTiNcfpAucUh0ZTcs=Ajy49qVA@mail.gmail.com>
 <CAKFQuwZKp_FWZ0mi9H8th+fh70KeoV=4_6uB40TvQ9r1Q04UhA@mail.gmail.com>
 <CA+FnnTwW6bsN3zJSHYbc7cGUi_4+PBOmHx+L5bbupwKkUio9tQ@mail.gmail.com> <CAKFQuwbZxuVPZTwMmxqBYUFNajCPFKrOY12co+0pFK-eTHcEuA@mail.gmail.com>
In-Reply-To: <CAKFQuwbZxuVPZTwMmxqBYUFNajCPFKrOY12co+0pFK-eTHcEuA@mail.gmail.com>
From: Igor Korot <ikorot01@gmail.com>
Date: Sat, 26 Apr 2025 00:12:59 -0500
Message-ID: <CA+FnnTx5QBqs2WFAu+Bznv2z73i+j8aZXGDMB0ocE=Wb6hy4eA@mail.gmail.com>
Subject: Re: How to properly fix memory leak
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: "pgsql-generallists.postgresql.org" <pgsql-general@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BFnnTx5QBqs2WFAu%2BBznv2z73i%2Bj8aZXGDMB0ocE%3DWb6hy4eA%40mail.gmail.com>
Precedence: bulk

Hi, David,

On Fri, Apr 25, 2025 at 11:55=E2=80=AFPM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Friday, April 25, 2025, Igor Korot <ikorot01@gmail.com> wrote:
>>
>>
>> And the error case was handled correctly, right?
>
>
> Seems like answering that requires knowing what the query is or can be.  =
I also have no idea what idiomatic code looks like.  Though, I=E2=80=99d pr=
obably use PQresultErrorMessage and check affirmatively for the tuples and =
error cases and have a final else should the status be something unexpected=
.

Understood.

Below is the full function:

[code]
int PostgresDatabase::PopulateTablespaces(std::vector<std::wstring> &errorM=
sg)
{
    int result =3D 0;
    std::wstring errorMessage;
    std::wstring query =3D L"SELECT * FROM pg_tablespace;";
    auto res =3D PQexec( m_db, m_pimpl->m_myconv.to_bytes( query.c_str()
).c_str() );      /* ask for binary results */
    if( PQresultStatus( res ) !=3D PGRES_TUPLES_OK )
    {
        auto err =3D m_pimpl->m_myconv.from_bytes( PQerrorMessage( m_db ) )=
;
        errorMsg.push_back( L"Update validation table: " + err );
        result =3D 1;
    }
    else
    {
        for( int i =3D 0; i < PQntuples( res ); i++ )
        {
            auto temp1 =3D m_pimpl->m_myconv.from_bytes( PQgetvalue(
res, i, 1 ) );
            m_tablespaces.push_back( temp1 );
        }
    }
    PQclear( res );
    return result;
}
[/code]

Thank you.

>
> David J.
>