MIME-Version: 1.0
References: <69A2A7BD-F8CA-4067-B229-B5F9FC6A884F@thebuild.com>
 <2e3e4ddb-52b5-49b2-b363-00e3f12a83a0@postgrespro.ru> <1214992.1720473388@sss.pgh.pa.us>
 <CAKFQuwYdD-rUZy7nYCi0K-RxvL-=s1wMHU6hqdBNY7VsaCwv3A@mail.gmail.com> <1221566.1720476530@sss.pgh.pa.us>
In-Reply-To: <1221566.1720476530@sss.pgh.pa.us>
From: Robert Haas <robertmhaas@gmail.com>
Date: Mon, 8 Jul 2024 19:37:44 -0400
Message-ID: <CA+TgmobAZQo8KgVjDFsp=hGmMxEgmCXE_FNEWoCiSr6qmgPTBg@mail.gmail.com>
Subject: Re: v16 roles, SET FALSE, INHERIT FALSE, ADMIN FALSE
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Pavel Luzanov <p.luzanov@postgrespro.ru>, 
	Christophe Pettus <xof@thebuild.com>, pgsql-general <pgsql-general@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CA%2BTgmobAZQo8KgVjDFsp%3DhGmMxEgmCXE_FNEWoCiSr6qmgPTBg%40mail.gmail.com>
Precedence: bulk

On Mon, Jul 8, 2024 at 6:08=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> Hmm, if that check doesn't require INHERIT TRUE I'd say it's
> >> a bug.
>
> > The code doesn't support that claim.
>
> That doesn't make it not a bug.  Robert, what do you think?  If this
> is correct behavior, why is it correct?

Correct is debatable, but it's definitely intentional. I didn't think
that referencing a group in pg_hba.conf constituted either (a) the
group inheriting the privileges of the role -- which would make it
governed by INHERIT -- or (b) the group being able to SET ROLE to the
role -- which would make it controlled by SET. I guess you're arguing
for INHERIT which is probably the more logical of the two, but I'm not
really sold on it. I think the pg_hba.conf matching is just asking
whether X is in set S, not whether S has the privileges of X.

For contemporaneous evidence of my thinking on this subject see
https://www.postgresql.org/message-id/CA+TgmobhEYYnW9vrHvoLvD8ODsPBJuU9CbK6=
tms6Owd70hFMTw@mail.gmail.com
particularly the paragraph that starts with "That's it".

--
Robert Haas
EDB: http://www.enterprisedb.com