Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sxvnu-00DJzP-2h for pgsql-general@arkaria.postgresql.org; Mon, 07 Oct 2024 22:02:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sxvns-00GQql-8k for pgsql-general@arkaria.postgresql.org; Mon, 07 Oct 2024 22:02:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sxvnr-00GQqd-Tv for pgsql-general@lists.postgresql.org; Mon, 07 Oct 2024 22:02:07 +0000 Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sxvnp-0035ey-Ab for pgsql-general@lists.postgresql.org; Mon, 07 Oct 2024 22:02:07 +0000 Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3e27a0d7819so399940b6e.0 for ; Mon, 07 Oct 2024 15:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728338523; x=1728943323; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=msxEefqYJSrRCjWe2QVFYYJVem9y9XTsxj8LSv7Wllo=; b=aVN4KlBffn3C4XD2HlE+PDhIzkRJJQOdtsxuH+W174lSIlC2LcPE5pMChPGB+75dnH sDqxqoXXabWyyq/dM6p09muGbTSico/dIbQjAtQtI3pTV1cCjR0hpWr+XdIIygT0KizF pZDoC/Ht3EF0jA3lG3uF+hQ0sxeR8dYK4c+8wEO1ynuAgOCTCQb0YpHPE4oEssXvG8Tc 4soKoIY2B6owH/BQzzLDxwKIqFc9LJgqp8hqR4ZTUn5CTJ020c8MMP31ojitqZfomAYt Y57w/F9ogjxQfk2kwoT9zrwD3zFaoKiX3UChEzqjDO46XHogUHb9CmiBiQBpFr1iYjhN cyuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728338523; x=1728943323; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=msxEefqYJSrRCjWe2QVFYYJVem9y9XTsxj8LSv7Wllo=; b=W8ZNvz9LxdnDHcCxbIUdR/y5opF4vVgEw0p+3PJkfwpjR/2ES/QrWnfm4kCrvp6fwg MPXjIEJmni4ut+VW2gf6Cr3milCca2FeeG9To4GTnnbAI+i10Jo11ukUJBzOhOF0FVwA Qc8enQzz+NCf3EAenoyyCwW/l8T4Gqa7J/KGc2XAIHZW2kgt8c3APAuA2RKoM04Y8smB 2hoxQsIsiTRACIREpQrXEY9MSbH4aU+pDPFJnELUsAHp3yxx94FCvTCUAzar2Y4jxAT/ Ny+x/Y+nS+PPkXmGMzj/RHtj0rYGb11jS5fPXTbwpW9JBGCHw3PPD1049W+jXcaa79Cg HJnw== X-Forwarded-Encrypted: i=1; AJvYcCVRsQDc2KFFa5DWwc5KCLi5XgxGK9gNEWcVjWFv3cJ2h44qqdO/VoGTKTR7YzOkNrgEsJrxHlCZ4W3SeXeJ@lists.postgresql.org X-Gm-Message-State: AOJu0Yxh74odb5QHGV+HYB/NSj2IhGAzJ236a39HSHcwfzeZk9M9Tcun X50v/kpgfLZkswrg187UtibBHNiKDKeZgBkOoEMocPvcinw6+q76kl8/WIb7CHsNnrBh6PRdXdk z14HjwUxBkvqwdnzIrpyJgbPy9BazkLw8MB4= X-Google-Smtp-Source: AGHT+IFli0TXXSaGZeCo3ZZJOOj3dGOX/e9sFKgcyIBzuoYZ56OaVyJEeZtW/pQZtIPimYjNsbkumOrU7ID5j7kVWmU= X-Received: by 2002:a05:6808:bca:b0:3e2:9f3b:1684 with SMTP id 5614622812f47-3e3c1551a6bmr3198794b6e.5.1728338523089; Mon, 07 Oct 2024 15:02:03 -0700 (PDT) MIME-Version: 1.0 References: <3168699.1669046286@sss.pgh.pa.us> <20221123230256.m23somxrmvdyoimk@awork3.anarazel.de> <3755435.1669245082@sss.pgh.pa.us> <20221124023251.k4dnbmxuxmqzq7w3@awork3.anarazel.de> <20221207191756.po34ymbdt6u7ym7x@awork3.anarazel.de> <20221223112007.i7scxeij7d3coepz@alap3.anarazel.de> In-Reply-To: <20221223112007.i7scxeij7d3coepz@alap3.anarazel.de> From: Thomas Munro Date: Tue, 8 Oct 2024 11:01:26 +1300 Message-ID: Subject: Re: Getting PSQL in Windows to support TAB/Autocomplete via modified readline... To: Kirk Wolak Cc: Tom Lane , Andres Freund , pgsql-general@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Kirk, Just as an FYI since you were working in this area, Tom has just knocked off one of the blockers for tab completion on Windows, namely that MSVC didn't like the overgrown if-then-else code in tab-complete.c[1]. That is now fixed in PostgreSQL's master branch[2][3][4] (v18 to be). [1] https://www.postgresql.org/message-id/flat/2208466.1720729502%40sss.pgh.pa.us [2] https://github.com/postgres/postgres/commit/ef0938f7bdd0838857da38b9a660191ec8411696 [3] https://github.com/postgres/postgres/commit/bd1276a3c9433a9e2760db6ae6e73560d7d32a22 [4] https://github.com/postgres/postgres/commit/f391d9dc93a24923c57bb0e044161d3f0b840770