MIME-Version: 1.0
References: <Z9qybg3FxTUefRT7@msg.df7cb.de> <Z9y43-dRvb4EtxQ0@paquier.xyz>
 <Z92TLJ5MmSU_lyxa@msg.df7cb.de> <Z93sH12uzCQHfOo-@paquier.xyz>
 <Z96GJEmTnvHKz_Kn@msg.df7cb.de> <Z96Rz-4IEyRCS4ny@paquier.xyz>
 <1831838.1742656359@sss.pgh.pa.us> <80506.1742660683@sss.pgh.pa.us>
 <Z99aIy9T0f-lulK5@paquier.xyz> <461405.1742691859@sss.pgh.pa.us>
 <Z9-sUvq8pE5uinEu@paquier.xyz> <CAA5RZ0t4XQ_SANiJ5VfuoKnAuxMaY2ggQWoGKkHo+U2H+Sh-Sw@mail.gmail.com>
 <1189112.1742869660@sss.pgh.pa.us>
In-Reply-To: <1189112.1742869660@sss.pgh.pa.us>
From: Sami Imseih <samimseih@gmail.com>
Date: Mon, 24 Mar 2025 21:38:35 -0500
Message-ID: <CAA5RZ0uNofEXfEfNw3uRN3D3oXkFPQ_s+huLLHMKR_+MCk8RPQ@mail.gmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Christoph Berg <myon@debian.org>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, ma lz <ma100@hotmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAA5RZ0uNofEXfEfNw3uRN3D3oXkFPQ_s%2BhuLLHMKR_%2BMCk8RPQ%40mail.gmail.com>
Precedence: bulk

> select * from foo s1;
> select * from foo s2;

ah, thanks for pointing this out. Not as good of a workaround as
a comment since one must change aliases, but at least there is
a workaround...

> As against this, there is probably also a set of people who would
> *like* identical queries on identically-rowtyped tables in different
> schemas to be merged.  Right now they have no way to make that happen.

I agree that some may want stats to merge for the same tables,
and others may not. I will suggest this with some hesitation, but why not
make this behavior configurable via a GUC?
We recently introduced query_id_squash_values for controlling
the merge of an IN list, maybe this is another queryId behavior we should
provide a configuration for?

--
Sami Imseih
Amazon Web Services (AWS)