MIME-Version: 1.0
References: <CAAiHg9UhjM6XN5XV_NMB184v0UO4H8rHGaBrtwJr0HHok8pJVA@mail.gmail.com>
 <1371061.1729452752@sss.pgh.pa.us>
In-Reply-To: <1371061.1729452752@sss.pgh.pa.us>
From: Barry Walker <mstrchef7@gmail.com>
Date: Sun, 20 Oct 2024 17:29:41 -0400
Message-ID: <CAAiHg9Wjx_yMHseUPy8NGFVVXAepF0jTF4Oec6v_E7ZTzZ1kog@mail.gmail.com>
Subject: Re: Help Resolving Compiler Errors With enable-dtrace Flag
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-general@postgresql.org
Content-Type: multipart/alternative; boundary="00000000000090eef20624ef3cf3"
Archived-At: <https://www.postgresql.org/message-id/CAAiHg9Wjx_yMHseUPy8NGFVVXAepF0jTF4Oec6v_E7ZTzZ1kog%40mail.gmail.com>
Precedence: bulk

--00000000000090eef20624ef3cf3
Content-Type: text/plain; charset="UTF-8"

>I'd read
>
>
https://www.postgresql.org/docs/current/dynamic-trace.html#DEFINING-TRACE-POINTS
>
>
>and then go see if those tracepoints are fully conforming to the
>coding rules in the modified version.  A plausible bet is that
>their entries in probes.d don't entirely match up with the calls
>in the source code.  You could compare the relevant bits of code
>between vanilla and modified 16.4 if the problem isn't immediately
>obvious.
>
>                        regards, tom lane

I've taken a look at the probes.d file and there are no changes between the
modified and vanilla versions of the file, and the probes are called with
the same args. This is happening for every probe in the probes.d file.
Since I'm getting those errors it looks like the generated probes.h file is
also properly being used. Do you know where the
postgresql_transaction__commit_semaphore
symbol should be defined?

--00000000000090eef20624ef3cf3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">&gt;I&#39;d read<br>&gt;<br>&gt;<a href=3D"https://www.pos=
tgresql.org/docs/current/dynamic-trace.html#DEFINING-TRACE-POINTS" rel=3D"n=
oreferrer" target=3D"_blank">https://www.postgresql.org/docs/current/dynami=
c-trace.html#DEFINING-TRACE-POINTS</a>&gt;<br>&gt;<br>&gt;and then go see i=
f those tracepoints are fully conforming to the<br>&gt;coding rules in the =
modified version.=C2=A0 A plausible bet is that<br>&gt;their entries in pro=
bes.d don&#39;t entirely match up with the calls<br>&gt;in the source code.=
=C2=A0 You could compare the relevant bits of code<br>&gt;between vanilla a=
nd modified 16.4 if the problem isn&#39;t immediately<br>&gt;obvious.<br>&g=
t;<br>&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 regards, tom lane<div><br></div><div>I&#39;ve taken a =
look at the probes.d file and there are no changes between the modified and=
 vanilla=C2=A0versions of the file, and the probes are called with the same=
 args. This is happening for every probe in the probes.d file. Since I&#39;=
m getting those errors it looks like the generated probes.h file is also pr=
operly being used. Do you know where the=C2=A0<span style=3D"color:rgb(0,0,=
0);font-family:monospace,monospace;font-size:10.7333px">postgresql_transact=
ion__commit_semaphore </span><span style=3D"color:rgb(0,0,0)"><font face=3D=
"arial, sans-serif">symbol should be defined?</font></span></div></div>

--00000000000090eef20624ef3cf3--