MIME-Version: 1.0
References: <CACX+KaMz2ZoOojh0nQ6QNBYx8Ak1Dkoko=D4FSb80BYW+o8CHQ@mail.gmail.com>
 <855988.1739816850@sss.pgh.pa.us> <CAKFQuwZ+EsCJHmBVdHeJ2XUWUBSGtN8k2icrX2hrPR=m7sLNGg@mail.gmail.com>
 <861660.1739819589@sss.pgh.pa.us> <CACX+KaMiZaFWVxYzZ_Lw-EBKgiO5GEBHmHREqs=GDpM88hRqdw@mail.gmail.com>
 <908583.1739822263@sss.pgh.pa.us> <CA+TgmobSc_x6thvXZvHoni5Gs5-wsxyTRiOMKoeuX5br0PCtDA@mail.gmail.com>
 <CACX+KaPv4apqG3=Ef+FB9nn4C4cd6Z+604ej0PPOHKExH45u2A@mail.gmail.com>
 <934709.1739829723@sss.pgh.pa.us> <CAKFQuwZThU_Z-Zw+3mr+ecp1BVOw777dp3nXU5-wTVk3kS10gw@mail.gmail.com>
 <CA+TgmoZG71zBpLOfCGZqGhtp=88z6=YYhi54TEsCtKr3v+UpoA@mail.gmail.com>
 <1243984.1739894558@sss.pgh.pa.us> <CA+Tgmob_W0iq9Kuugra3WYTO2429RMJ_+HkVukrXWOUN81QiEw@mail.gmail.com>
 <1246906.1739896202@sss.pgh.pa.us> <CA+TgmoZYM2az+yCWu5DBnV50N_BE9f1r8-Doy6-tZTySeb-s+A@mail.gmail.com>
In-Reply-To: <CA+TgmoZYM2az+yCWu5DBnV50N_BE9f1r8-Doy6-tZTySeb-s+A@mail.gmail.com>
From: Ayush Vatsa <ayushvatsa1810@gmail.com>
Date: Wed, 19 Feb 2025 15:53:48 +0530
Message-ID: <CACX+KaNAbOzePn710EtzH9F5xiUdBC+u59=UMab=Wr8jgDKQtw@mail.gmail.com>
Subject: Re: Clarification on Role Access Rights to Table Indexes
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "David G. Johnston" <david.g.johnston@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000fb8b33062e7c279a"
Archived-At: <https://www.postgresql.org/message-id/CACX%2BKaNAbOzePn710EtzH9F5xiUdBC%2Bu59%3DUMab%3DWr8jgDKQtw%40mail.gmail.com>
Precedence: bulk

--000000000000fb8b33062e7c279a
Content-Type: multipart/alternative; boundary="000000000000fb8b32062e7c2798"

--000000000000fb8b32062e7c2798
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Everyone,
It seems there's a general consensus that we should maintain a
original design to support pg_prewarm, with a minor adjustment:
when querying indexes, we should verify the privileges of the parent table.

I=E2=80=99ve attached a patch for this, which includes some test cases as w=
ell.
Let me know if it needs any changes.

Regards,
Ayush Vatsa
SDE AWS

--000000000000fb8b32062e7c2798
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><p>Hello Everyone,<br>It seems there&#39;s a general conse=
nsus that we should maintain a <br>original design to support <code>pg_prew=
arm</code>, with a minor adjustment: <br>when querying indexes, we should v=
erify the privileges of the parent table.<br><br>I=E2=80=99ve attached a pa=
tch for this, which includes some test cases as well.<br>Let me know if it =
needs any=C2=A0changes.</p><p>Regards,<br>Ayush Vatsa<br>SDE AWS</p></div>

--000000000000fb8b32062e7c2798--
--000000000000fb8b33062e7c279a
Content-Type: application/octet-stream; 
	name="v1-0001-Improve-ACL-checks-in-pg_prewarm-for-indexes.patch"
Content-Disposition: attachment; 
	filename="v1-0001-Improve-ACL-checks-in-pg_prewarm-for-indexes.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m7brf97m0>
X-Attachment-Id: f_m7brf97m0

RnJvbSA4Zjg2MDZjMDA3ZmRiNTg0MDM3OTJkMzZhNjJjNjczOTM0MWIwNTQ5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBeXVzaCBWYXRzYSA8YXl1dmF0c2FAYW1hem9uLmNvbT4KRGF0
ZTogTW9uLCAxNyBGZWIgMjAyNSAyMDo0NDo1NiArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIElt
cHJvdmUgQUNMIGNoZWNrcyBpbiBwZ19wcmV3YXJtIGZvciBpbmRleGVzCgpXaGVuIHBnX3ByZXdh
cm0gaXMgY2FsbGVkIG9uIGFuIGluZGV4LCBwZXJmb3JtIHRoZSBBQ0wgY2hlY2sgb24gaXRzCnVu
ZGVybHlpbmcgdGFibGUgaW5zdGVhZCBvZiB0aGUgaW5kZXggaXRzZWxmLiBJbmRleGVzIGRvIG5v
dCBoYXZlCmluZGVwZW5kZW50IGFjY2VzcyByaWdodHMgYW5kIGRlcGVuZCBvbiB0aGVpciBhc3Nv
Y2lhdGVkIHRhYmxlIGZvcgphY2Nlc3MgY29udHJvbC4KLS0tCiBjb250cmliL3BnX3ByZXdhcm0v
cGdfcHJld2FybS5jICAgfCAyOSArKysrKysrKysrKysrKysrKysrKysrKystLS0KIGNvbnRyaWIv
cGdfcHJld2FybS90LzAwMV9iYXNpYy5wbCB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgNTggaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK
CmRpZmYgLS1naXQgYS9jb250cmliL3BnX3ByZXdhcm0vcGdfcHJld2FybS5jIGIvY29udHJpYi9w
Z19wcmV3YXJtL3BnX3ByZXdhcm0uYwppbmRleCBhMmYwYWM0YWYwLi5iMjg0NmNlZTJlIDEwMDY0
NAotLS0gYS9jb250cmliL3BnX3ByZXdhcm0vcGdfcHJld2FybS5jCisrKyBiL2NvbnRyaWIvcGdf
cHJld2FybS9wZ19wcmV3YXJtLmMKQEAgLTE2LDYgKzE2LDcgQEAKICNpbmNsdWRlIDx1bmlzdGQu
aD4KIAogI2luY2x1ZGUgImFjY2Vzcy9yZWxhdGlvbi5oIgorI2luY2x1ZGUgImNhdGFsb2cvaW5k
ZXguaCIKICNpbmNsdWRlICJmbWdyLmgiCiAjaW5jbHVkZSAibWlzY2FkbWluLmgiCiAjaW5jbHVk
ZSAic3RvcmFnZS9idWZtZ3IuaCIKQEAgLTU1LDYgKzU2LDcgQEAgRGF0dW0KIHBnX3ByZXdhcm0o
UEdfRlVOQ1RJT05fQVJHUykKIHsKIAlPaWQJCQlyZWxPaWQ7CisJT2lkCQkJdGFibGVPaWQ7CiAJ
dGV4dAkgICAqZm9ya05hbWU7CiAJdGV4dAkgICAqdHlwZTsKIAlpbnQ2NAkJZmlyc3RfYmxvY2s7
CkBAIC0xMDUsOSArMTA3LDMwIEBAIHBnX3ByZXdhcm0oUEdfRlVOQ1RJT05fQVJHUykKIAogCS8q
IE9wZW4gcmVsYXRpb24gYW5kIGNoZWNrIHByaXZpbGVnZXMuICovCiAJcmVsID0gcmVsYXRpb25f
b3BlbihyZWxPaWQsIEFjY2Vzc1NoYXJlTG9jayk7Ci0JYWNscmVzdWx0ID0gcGdfY2xhc3NfYWNs
Y2hlY2socmVsT2lkLCBHZXRVc2VySWQoKSwgQUNMX1NFTEVDVCk7Ci0JaWYgKGFjbHJlc3VsdCAh
PSBBQ0xDSEVDS19PSykKLQkJYWNsY2hlY2tfZXJyb3IoYWNscmVzdWx0LCBnZXRfcmVsa2luZF9v
Ymp0eXBlKHJlbC0+cmRfcmVsLT5yZWxraW5kKSwgZ2V0X3JlbF9uYW1lKHJlbE9pZCkpOworCisJ
LyoqCisJICogQ2hlY2sgYWNjZXNzIHBlcm1pc3Npb25zIGZvciBwZ19wcmV3YXJtLiBJZiB0aGUg
cmVsYXRpb24gaXMgYW4gaW5kZXgsCisJICogcGVyZm9ybSB0aGUgQUNMIGNoZWNrIG9uIGl0cyB1
bmRlcmx5aW5nIHRhYmxlIHNpbmNlIGluZGV4ZXMgZG8gbm90IGhhdmUKKwkgKiB0aGVpciBvd24g
YWNjZXNzIHJpZ2h0cy4KKwkgKi8KKwlpZiAocmVsLT5yZF9yZWwtPnJlbGtpbmQgPT0gUkVMS0lO
RF9JTkRFWCkKKwl7CisJCS8qCisJCSAqIElmIGl0J3MgYW4gaW5kZXgsIGdldCB0aGUgdGFibGUg
T0lEIGFuZCBwZXJmb3JtIEFDTCBjaGVjayBvbiB0aGUKKwkJICogdGFibGUuCisJCSAqLworCQl0
YWJsZU9pZCA9IEluZGV4R2V0UmVsYXRpb24ocmVsT2lkLCBmYWxzZSk7CisJCWFjbHJlc3VsdCA9
IHBnX2NsYXNzX2FjbGNoZWNrKHRhYmxlT2lkLCBHZXRVc2VySWQoKSwgQUNMX1NFTEVDVCk7CisJ
CWlmIChhY2xyZXN1bHQgIT0gQUNMQ0hFQ0tfT0spCisJCQlhY2xjaGVja19lcnJvcihhY2xyZXN1
bHQsIGdldF9yZWxraW5kX29ianR5cGUoUkVMS0lORF9SRUxBVElPTiksIGdldF9yZWxfbmFtZSh0
YWJsZU9pZCkpOworCX0KKwllbHNlCisJeworCQkvKiBJZiBpdCdzIG5vdCBhbiBpbmRleCwgcGVy
Zm9ybSBBQ0wgY2hlY2sgb24gdGhlIHJlbGF0aW9uIGl0c2VsZi4gKi8KKwkJYWNscmVzdWx0ID0g
cGdfY2xhc3NfYWNsY2hlY2socmVsT2lkLCBHZXRVc2VySWQoKSwgQUNMX1NFTEVDVCk7CisJCWlm
IChhY2xyZXN1bHQgIT0gQUNMQ0hFQ0tfT0spCisJCQlhY2xjaGVja19lcnJvcihhY2xyZXN1bHQs
IGdldF9yZWxraW5kX29ianR5cGUocmVsLT5yZF9yZWwtPnJlbGtpbmQpLCBnZXRfcmVsX25hbWUo
cmVsT2lkKSk7CisJfQogCiAJLyogQ2hlY2sgdGhhdCB0aGUgZm9yayBleGlzdHMuICovCiAJaWYg
KCFzbWdyZXhpc3RzKFJlbGF0aW9uR2V0U21ncihyZWwpLCBmb3JrTnVtYmVyKSkKZGlmZiAtLWdp
dCBhL2NvbnRyaWIvcGdfcHJld2FybS90LzAwMV9iYXNpYy5wbCBiL2NvbnRyaWIvcGdfcHJld2Fy
bS90LzAwMV9iYXNpYy5wbAppbmRleCAwYTgyNTlkMzY3Li42NTFmNGVjMzcxIDEwMDY0NAotLS0g
YS9jb250cmliL3BnX3ByZXdhcm0vdC8wMDFfYmFzaWMucGwKKysrIGIvY29udHJpYi9wZ19wcmV3
YXJtL3QvMDAxX2Jhc2ljLnBsCkBAIC0yMyw3ICsyMyw5IEBAICRub2RlLT5zdGFydDsKICRub2Rl
LT5zYWZlX3BzcWwoInBvc3RncmVzIiwKIAkJIkNSRUFURSBFWFRFTlNJT04gcGdfcHJld2FybTtc
biIKIAkgIC4gIkNSRUFURSBUQUJMRSB0ZXN0KGMxIGludCk7XG4iCi0JICAuICJJTlNFUlQgSU5U
TyB0ZXN0IFNFTEVDVCBnZW5lcmF0ZV9zZXJpZXMoMSwgMTAwKTsiKTsKKwkgIC4gIklOU0VSVCBJ
TlRPIHRlc3QgU0VMRUNUIGdlbmVyYXRlX3NlcmllcygxLCAxMDApO1xuIgorCSAgLiAiQ1JFQVRF
IElOREVYIHRlc3RfaWR4IE9OIHRlc3QoYzEpO1xuIgorCSAgLiAiQ1JFQVRFIFJPTEUgdGVzdF91
c2VyIFdJVEggTE9HSU47Iik7CiAKICMgdGVzdCByZWFkIG1vZGUKIG15ICRyZXN1bHQgPQpAQCAt
NDIsNiArNDQsMzUgQEAgb2soICggICAgICAgICRzdGRvdXQgPX4gcXIvXlsxLTldWzAtOV0qJC8K
IAkJICBvciAkc3RkZXJyID1+IHFyL3ByZWZldGNoIGlzIG5vdCBzdXBwb3J0ZWQgYnkgdGhpcyBi
dWlsZC8pLAogCSdwcmVmZXRjaCBtb2RlIHN1Y2NlZWRlZCcpOwogCisjIGdyYW50IFNFTEVDVCBw
ZXJtaXNzaW9uIG9uIHRoZSB0YWJsZSB0byB0ZXN0X3VzZXIKKyRub2RlLT5zYWZlX3BzcWwoInBv
c3RncmVzIiwgIkdSQU5UIFNFTEVDVCBPTiB0ZXN0IFRPIHRlc3RfdXNlcjsiKTsKKworIyB0ZXN0
IHBnX3ByZXdhcm0gb24gdGhlIHRhYmxlL2luZGV4IGFzIHRlc3RfdXNlciAoc2hvdWxkIHN1Y2Nl
ZWQpCiskcmVzdWx0ID0KKyAgJG5vZGUtPnNhZmVfcHNxbCgicG9zdGdyZXMiLCAiU0VMRUNUIHBn
X3ByZXdhcm0oJ3Rlc3QnLCAnYnVmZmVyJyk7IiwgZXh0cmFfcGFyYW1zID0+IFsgJy0tdXNlcm5h
bWUnID0+ICJ0ZXN0X3VzZXIiIF0pOworbGlrZSgkcmVzdWx0LCBxci9eWzEtOV1bMC05XSokLywg
J3BnX3ByZXdhcm0gb24gdGFibGUgc3VjY2VlZHMgd2l0aCBTRUxFQ1QgcGVybWlzc2lvbiBvbiB0
YWJsZScpOworCiskcmVzdWx0ID0KKyAgJG5vZGUtPnNhZmVfcHNxbCgicG9zdGdyZXMiLCAiU0VM
RUNUIHBnX3ByZXdhcm0oJ3Rlc3RfaWR4JywgJ2J1ZmZlcicpOyIsIGV4dHJhX3BhcmFtcyA9PiBb
ICctLXVzZXJuYW1lJyA9PiAidGVzdF91c2VyIiBdKTsKK2xpa2UoJHJlc3VsdCwgcXIvXlsxLTld
WzAtOV0qJC8sICdwZ19wcmV3YXJtIG9uIGluZGV4IHN1Y2NlZWRzIHdpdGggU0VMRUNUIHBlcm1p
c3Npb24gb24gdGFibGUnKTsKKworIyByZXZva2UgU0VMRUNUIHBlcm1pc3Npb24gb24gdGhlIHRh
YmxlIGZyb20gdGVzdF91c2VyCiskbm9kZS0+c2FmZV9wc3FsKCJwb3N0Z3JlcyIsICJSRVZPS0Ug
U0VMRUNUIE9OIHRlc3QgRlJPTSB0ZXN0X3VzZXI7Iik7CisKKyMgdGVzdCBwZ19wcmV3YXJtIG9u
IHRoZSB0YWJsZS9pbmRleCBhcyB0ZXN0X3VzZXIgKHNob3VsZCBmYWlsKQorKCRjbWRyZXQsICRz
dGRvdXQsICRzdGRlcnIpID0KKyAgJG5vZGUtPnBzcWwoInBvc3RncmVzIiwgIlNFTEVDVCBwZ19w
cmV3YXJtKCd0ZXN0JywgJ2J1ZmZlcicpOyIsIGV4dHJhX3BhcmFtcyA9PiBbICctLXVzZXJuYW1l
JyA9PiAidGVzdF91c2VyIiBdKTsKK29rKCAkc3RkZXJyID1+IC9wZXJtaXNzaW9uIGRlbmllZCBm
b3IgdGFibGUgdGVzdC8sCisJImVycm9yIG1lc3NhZ2UgaW5kaWNhdGVzIHVzZXIgZG9lc24ndCBo
YXZlIHN1ZmZpY2llbnQgcHJpdmlsZWdlcyBmb3IgdGhlIHBhcmVudCB0YWJsZSIpOworCisoJGNt
ZHJldCwgJHN0ZG91dCwgJHN0ZGVycikgPQorICAkbm9kZS0+cHNxbCgicG9zdGdyZXMiLCAiU0VM
RUNUIHBnX3ByZXdhcm0oJ3Rlc3RfaWR4JywgJ2J1ZmZlcicpOyIsIGV4dHJhX3BhcmFtcyA9PiBb
ICctLXVzZXJuYW1lJyA9PiAidGVzdF91c2VyIiBdKTsKK29rKCAkc3RkZXJyID1+IC9wZXJtaXNz
aW9uIGRlbmllZCBmb3IgdGFibGUgdGVzdC8sCisJImVycm9yIG1lc3NhZ2UgaW5kaWNhdGVzIHVz
ZXIgZG9lc24ndCBoYXZlIHN1ZmZpY2llbnQgcHJpdmlsZWdlcyBmb3IgdGhlIHBhcmVudCB0YWJs
ZSIpOworCisjIGNsZWFuIHVwOiBkcm9wIHRoZSB0ZXN0X3VzZXIgcm9sZQorJG5vZGUtPnNhZmVf
cHNxbCgicG9zdGdyZXMiLCAiRFJPUCBST0xFIHRlc3RfdXNlcjsiKTsKKwogIyB0ZXN0IGF1dG9w
cmV3YXJtX2R1bXBfbm93KCkKICRyZXN1bHQgPSAkbm9kZS0+c2FmZV9wc3FsKCJwb3N0Z3JlcyIs
ICJTRUxFQ1QgYXV0b3ByZXdhcm1fZHVtcF9ub3coKTsiKTsKIGxpa2UoJHJlc3VsdCwgcXIvXlsx
LTldWzAtOV0qJC8sICdhdXRvcHJld2FybV9kdW1wX25vdyBzdWNjZWVkZWQnKTsKLS0gCjIuNDcu
MQoK
--000000000000fb8b33062e7c279a--