MIME-Version: 1.0
References: <934709.1739829723@sss.pgh.pa.us> <CAKFQuwZThU_Z-Zw+3mr+ecp1BVOw777dp3nXU5-wTVk3kS10gw@mail.gmail.com>
 <CA+TgmoZG71zBpLOfCGZqGhtp=88z6=YYhi54TEsCtKr3v+UpoA@mail.gmail.com>
 <1243984.1739894558@sss.pgh.pa.us> <CA+Tgmob_W0iq9Kuugra3WYTO2429RMJ_+HkVukrXWOUN81QiEw@mail.gmail.com>
 <1246906.1739896202@sss.pgh.pa.us> <CA+TgmoZYM2az+yCWu5DBnV50N_BE9f1r8-Doy6-tZTySeb-s+A@mail.gmail.com>
 <CACX+KaNAbOzePn710EtzH9F5xiUdBC+u59=UMab=Wr8jgDKQtw@mail.gmail.com>
 <Z8dcGMMP3-D5dobY@nathan> <CACX+KaO4R9QDxbPSxSB0jNXFsqA6Jf=UPS+tyUvT_YvuP_grVA@mail.gmail.com>
 <Z8yxsm9ZWVkHlPbV@nathan>
In-Reply-To: <Z8yxsm9ZWVkHlPbV@nathan>
From: Ayush Vatsa <ayushvatsa1810@gmail.com>
Date: Sun, 9 Mar 2025 03:01:41 +0530
Message-ID: <CACX+KaP+6U9jf=GT4wpR7TvRvSMtTAhz=vP2Zr+ZdUFVZzqNsA@mail.gmail.com>
Subject: Re: Clarification on Role Access Rights to Table Indexes
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, 
	"David G. Johnston" <david.g.johnston@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000b8a92b062fdb77b0"
Archived-At: <https://www.postgresql.org/message-id/CACX%2BKaP%2B6U9jf%3DGT4wpR7TvRvSMtTAhz%3DvP2Zr%2BZdUFVZzqNsA%40mail.gmail.com>
Precedence: bulk

--000000000000b8a92b062fdb77b0
Content-Type: text/plain; charset="UTF-8"

> From a quick test and skim of the relevant
> code, I think your patch is fine, though
Thanks for reviewing.

> And IIUC
> DROP TABLE first acquires a lock on the table and its dependent objects
> (e.g., indexes) before any actual deletions, so AFAICT there's no problem
> with using it in pg_class_aclcheck() and get_rel_name(), either.
True, I have also verified that from [1], hence I think we are safe here.
Maybe we can move ahead with the patch if we can see no other concerns.

[1]
https://github.com/postgres/postgres/blob/master/src/backend/catalog/dependency.c#L398-L430

Thanks,
Ayush Vatsa
SDE AWS

--000000000000b8a92b062fdb77b0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">&gt; From a quick test and skim of the relevant<br>&gt; co=
de, I think your patch is fine, though<br>Thanks for reviewing.<div><br></d=
iv><div>&gt; And IIUC</div>&gt; DROP TABLE first acquires a lock on the tab=
le and its dependent objects<br>&gt; (e.g., indexes) before any actual dele=
tions, so AFAICT there&#39;s no problem<br>&gt; with using it in pg_class_a=
clcheck() and get_rel_name(), either.<div>True, I have also verified that f=
rom [1], hence I think we are safe here.<br>Maybe we can move ahead with th=
e patch if we can see no other concerns.</div><div><br></div><div>[1]=C2=A0=
<a href=3D"https://github.com/postgres/postgres/blob/master/src/backend/cat=
alog/dependency.c#L398-L430">https://github.com/postgres/postgres/blob/mast=
er/src/backend/catalog/dependency.c#L398-L430</a></div><div><br></div><div>=
Thanks,<br>Ayush Vatsa<br>SDE AWS</div></div>

--000000000000b8a92b062fdb77b0--