Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1temji-00FcvI-8a for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Feb 2025 03:02:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1temjh-009gO3-D0 for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Feb 2025 03:02:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1temjh-009gNu-3q for pgsql-hackers@lists.postgresql.org; Mon, 03 Feb 2025 03:02:57 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1temje-002sU6-3A for pgsql-hackers@lists.postgresql.org; Mon, 03 Feb 2025 03:02:56 +0000 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-30762598511so38886921fa.0 for ; Sun, 02 Feb 2025 19:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738551773; x=1739156573; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EV9uL45ZjXxWKph+C06ij9Pik0eT+Dvv93tvlXh9+Oc=; b=aX/cHdNek3xmgwrBGVnzTmeZcYyRh1DnPWmigF/9A5T4v4Q3h4d8Jm3O15aSJncjzy i4EJ352HE92bvR7fAJGK06I3wVODkAuI3MXo7Y/pupooe1ay01RH5/vGJAZOGlIjNPbU 0BaRhe4redgVhkiezimU4pqp6VWAt+qOAO3R/fIM2KfvqMusr0/rZk7V1GmCA+WRvEUg b4mIHp7hyZL6AhMrC4JXb33IMxb8GsucUcevfghLHMCRSUphN0R+Jv/xRrLAb4TFPUBW 6cXEtg5M5rdgmwNxR1SofxRrlhbqpleAiq4WIdiiCtCAQNlnks0cOZ7wKeRGH2QaxGnc SlOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738551773; x=1739156573; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EV9uL45ZjXxWKph+C06ij9Pik0eT+Dvv93tvlXh9+Oc=; b=kcQA334Qxg/LL3dLhW3Qi+jbCP1f9jEzAn/wiAdSHCBvk5gsjLOFJO/Nqw2y7gxdrr 4V+nNAUx9nNnHuvek7w54CNhC4TKiv7+AKqe5bBWJVDWbrz4X8gm8nhvPEQuM2OATFJk ZaL4+nzoArrV5EPJX68IW9tyS0tLdQY5MMIxmstQ7oAQO3q0RNAdD70YCfq3UuNvAUnz Gfur3rLlOiPcGPFLIJkvX9pJJccGelg3eoWixQSEfl8jYEY3rjy6qOtUME+VEXf+pMB7 2zkh/vigfPoJLC8ysgTc8b5gpqStTx62qMnm4QWdeW938ZF/zVd82xB3ulQ59YLJkIlP AX4g== X-Forwarded-Encrypted: i=1; AJvYcCWd/A/KjZcGQAM1DTMyNfScFmAsim2YvTJ7+/puH6DL7B8jXdAWVDRbpcP+ZB3uNOSi08soNjIokx+xCzps@lists.postgresql.org X-Gm-Message-State: AOJu0YxoawfFtXXgVfTs3YOHsaCYMdDHpyM4tA3yzGP+ISZ18AOUKkfr IypnLaN/zCLJF8596WW8tGfFvXRQNG1a1W4w9Qng1J5QPbzUiyrOCazh+KDBcuR6NoG1IbGYPz0 oQwj0m8WU9cd4BToUaVDffkdyd3c= X-Gm-Gg: ASbGncuLEwu8kYSRfnCcKg3xFqHzZGRap3lGg5KolMgbCIi9DPH15Tnyb4fvAoriQps nmgmBzkNvSJKwMldKKjefOctPUWigxlkaSHMPAsuQ2VH99R7wQTkhZdipTEEYzd2qrWidk40= X-Google-Smtp-Source: AGHT+IHy1QDGNBz2P8uOzBR4QSD/51H/oRBUyo4WRJL2fDWFoadSnTKVhf5/CHrW9RuKHJDYR/AE/+6JpSY5WSuh5G0= X-Received: by 2002:a2e:a917:0:b0:302:40ec:a1b9 with SMTP id 38308e7fff4ca-307968c0655mr56973811fa.5.1738551772584; Sun, 02 Feb 2025 19:02:52 -0800 (PST) MIME-Version: 1.0 References: <1342498.1729444411@sss.pgh.pa.us> <1445998.1729482404@sss.pgh.pa.us> <2062830.1729625620@sss.pgh.pa.us> <2265411.1729699470@sss.pgh.pa.us> <2354718.1729737539@sss.pgh.pa.us> <2581216.1729794746@sss.pgh.pa.us> <1948345.1730500073@sss.pgh.pa.us> <3797606.1732045516@sss.pgh.pa.us> <1417389.1736964543@sss.pgh.pa.us> <3363452.1737483125@sss.pgh.pa.us> <0AC229FA-A3F1-43FD-B0DC-A46A73FEAFF7@yandex-team.ru> <931398.1737905825@sss.pgh.pa.us> <38A31221-C1C4-4846-9709-D66ACD76E87A@yandex-team.ru> <46876.1737918281@sss.pgh.pa.us> <3682021.1738288421@sss.pgh.pa.us> <256915.1738533419@sss.pgh.pa.us> In-Reply-To: <256915.1738533419@sss.pgh.pa.us> From: Michel Pelletier Date: Sun, 2 Feb 2025 19:02:16 -0800 X-Gm-Features: AWEUYZk_CxjTfxlPmkx2UHL0mStK1CdiwIKrBRLrTMKgFUoo9xWGOOAg59ZlT8U Message-ID: Subject: Re: Using Expanded Objects other than Arrays from plpgsql To: Tom Lane Cc: Pavel Borisov , Andrey Borodin , Pavel Stehule , pgsql-hackers@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000d42310062d342087" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000d42310062d342087 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 2, 2025 at 1:57=E2=80=AFPM Tom Lane wrote: > I wrote: > > Hmm, it seemed to still apply for me. But anyway, I needed to make > > the other changes, so here's v4. > > PFA v5. The new 0001 patch refactors the free_xxx infrastructure > to create plpgsql_statement_tree_walker(), and then in what's now > 0003 we can use that instead of writing a lot of duplicate code. > Thanks Tom! These patches apply for me and all my tests and benchmarks are still good. -Michel --000000000000d42310062d342087 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Feb 2, 2025 at 1:57=E2=80=AFPM To= m Lane <tgl@sss.pgh.pa.us> w= rote:
I wrote:
> Hmm, it seemed to still apply for me.=C2=A0 But anyway, I needed to ma= ke
> the other changes, so here's v4.

PFA v5.=C2=A0 The new 0001 patch refactors the free_xxx infrastructure
to create plpgsql_statement_tree_walker(), and then in what's now
0003 we can use that instead of writing a lot of duplicate code.

Thanks Tom!=C2=A0 These patches apply for me and = all my tests and benchmarks are still good.

-Miche= l
--000000000000d42310062d342087--