MIME-Version: 1.0
References: <CACxu=vJaKFNsYxooSnW1wEgsAO5u_v1XYBacfVJ14wgJV_PYeg@mail.gmail.com>
 <1342498.1729444411@sss.pgh.pa.us> <CACxu=vLXvpzN4X3k+9jsMt6ujuOvFVUSkA80t_cROSsF4y2jQQ@mail.gmail.com>
 <1445998.1729482404@sss.pgh.pa.us> <CACxu=vKEF8Qa-OaADFxf0uMg-xw6gH_CNCWd2s+xaqh-gY4=xg@mail.gmail.com>
 <2062830.1729625620@sss.pgh.pa.us> <2265411.1729699470@sss.pgh.pa.us>
 <CACxu=v++HNmss59yGUDkRny7g=M8tZ2YXF07AUXqKVGqcSfxGQ@mail.gmail.com>
 <2354718.1729737539@sss.pgh.pa.us> <2581216.1729794746@sss.pgh.pa.us>
 <CACxu=v+dn37zr8gx5xNP-EZY3OLtGLTHrbx_ZkCQc40HpyMLKA@mail.gmail.com>
 <1948345.1730500073@sss.pgh.pa.us> <CACxu=vL7i_U_iSNpREe8eCAMEyKHuPpk9THRpBhk+ar0U1EdOw@mail.gmail.com>
 <CACxu=vKLc6f5N8_DR58LKkE1eohWSxTvThTeGsLm7p7QH1aFBA@mail.gmail.com>
 <CACxu=vJf2S=ysun_h=zmYNu6oUM47+egbpX5mMC0X9BJK=EQwQ@mail.gmail.com>
 <CACxu=vK+S6BXN8ZYyBvqQBWrcwHXqtue1-ZuKO3+XtHGBYcDUQ@mail.gmail.com>
 <CAFj8pRCd6xcH-AYEyHFdGdU89O9JjZ-v-pyQnOwd9zNJkCEdhQ@mail.gmail.com> <3797606.1732045516@sss.pgh.pa.us>
In-Reply-To: <3797606.1732045516@sss.pgh.pa.us>
From: Michel Pelletier <pelletier.michel@gmail.com>
Date: Tue, 19 Nov 2024 12:52:46 -0800
Message-ID: <CACxu=vJNMj1MqqUiwATuazoewireaN=7nskD5V-CBEcrs_K6Vg@mail.gmail.com>
Subject: Re: Using Expanded Objects other than Arrays from plpgsql
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000053608306274a39ef"
Archived-At: <https://www.postgresql.org/message-id/CACxu%3DvJNMj1MqqUiwATuazoewireaN%3D7nskD5V-CBEcrs_K6Vg%40mail.gmail.com>
Precedence: bulk

--00000000000053608306274a39ef
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 19, 2024 at 11:45=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote=
:

> Pavel Stehule <pavel.stehule@gmail.com> writes:
> > =C3=BAt 19. 11. 2024 v 18:51 odes=C3=ADlatel Michel Pelletier <
> > pelletier.michel@gmail.com> napsal:
> >> A couple years ago I tried to compress what I learned about expanded
> >> objects into a dummy extension that just provides the necessary
> >> boilerplate.  It wasn't great but a start:
> >> https://github.com/michelp/pgexpanded
> >> Pavel Stehule indicated this might be a good example to put into
> contrib:
>
> > another position can be src/test/modules - I think so your example is
> > "similar" to plsample
>
> Yeah.  I think we've largely adopted the position that contrib should
> contain installable modules that do something potentially useful to
> end-users.  A pure skeleton wouldn't be that, but if it's fleshed out
> enough to be test code for some core features then src/test/modules
> could be a reasonable home.
>

Great!  I'll put a patch together that adds the skeleton object to
src/test/modules and I'll write some expected tests that run the expansion
through its paces, when the support function feature happens I'll update it
to include tests for that.

Should I include Tom's patch changes on top of mine or keep those
separate?  I'm not entirely clear on the best practice to carry those
forward as well.

-Michel

--00000000000053608306274a39ef
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Nov 19, 2024 at 11:45=E2=80=AFAM =
Tom Lane &lt;<a href=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>&gt;=
 wrote:</div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">Pavel Stehule &lt;<a href=3D"mailto:pavel.stehule@gmail.com"=
 target=3D"_blank">pavel.stehule@gmail.com</a>&gt; writes:<br>
&gt; =C3=BAt 19. 11. 2024 v 18:51 odes=C3=ADlatel Michel Pelletier &lt;<br>
&gt; <a href=3D"mailto:pelletier.michel@gmail.com" target=3D"_blank">pellet=
ier.michel@gmail.com</a>&gt; napsal:<br>
&gt;&gt; A couple years ago I tried to compress what I learned about expand=
ed<br>
&gt;&gt; objects into a dummy extension that just provides the necessary<br=
>
&gt;&gt; boilerplate.=C2=A0 It wasn&#39;t great but a start:<br>
&gt;&gt; <a href=3D"https://github.com/michelp/pgexpanded" rel=3D"noreferre=
r" target=3D"_blank">https://github.com/michelp/pgexpanded</a><br>
&gt;&gt; Pavel Stehule indicated this might be a good example to put into c=
ontrib:<br>
<br>
&gt; another position can be src/test/modules - I think so your example is<=
br>
&gt; &quot;similar&quot; to plsample<br>
<br>
Yeah.=C2=A0 I think we&#39;ve largely adopted the position that contrib sho=
uld<br>
contain installable modules that do something potentially useful to<br>
end-users.=C2=A0 A pure skeleton wouldn&#39;t be that, but if it&#39;s fles=
hed out<br>
enough to be test code for some core features then src/test/modules<br>
could be a reasonable home.<br></blockquote><div><br></div><div>Great!=C2=
=A0 I&#39;ll put a patch together that adds the skeleton object to src/test=
/modules and I&#39;ll write some expected tests that run the expansion thro=
ugh its paces, when the support function feature happens I&#39;ll update it=
 to include tests for that.</div><div><br></div><div>Should I include Tom&#=
39;s patch changes on top of mine or keep those separate?=C2=A0 I&#39;m not=
 entirely clear on the best practice to carry those forward as well.</div><=
div><br></div><div>-Michel</div><div><br></div><div>=C2=A0</div></div></div=
>

--00000000000053608306274a39ef--