MIME-Version: 1.0
References: <CACxu=vJaKFNsYxooSnW1wEgsAO5u_v1XYBacfVJ14wgJV_PYeg@mail.gmail.com>
 <1342498.1729444411@sss.pgh.pa.us> <CACxu=vLXvpzN4X3k+9jsMt6ujuOvFVUSkA80t_cROSsF4y2jQQ@mail.gmail.com>
 <1445998.1729482404@sss.pgh.pa.us> <CACxu=vKEF8Qa-OaADFxf0uMg-xw6gH_CNCWd2s+xaqh-gY4=xg@mail.gmail.com>
 <2062830.1729625620@sss.pgh.pa.us> <2265411.1729699470@sss.pgh.pa.us>
 <CACxu=v++HNmss59yGUDkRny7g=M8tZ2YXF07AUXqKVGqcSfxGQ@mail.gmail.com>
 <2354718.1729737539@sss.pgh.pa.us> <2581216.1729794746@sss.pgh.pa.us>
 <CACxu=v+dn37zr8gx5xNP-EZY3OLtGLTHrbx_ZkCQc40HpyMLKA@mail.gmail.com>
 <1948345.1730500073@sss.pgh.pa.us> <CACxu=vL7i_U_iSNpREe8eCAMEyKHuPpk9THRpBhk+ar0U1EdOw@mail.gmail.com>
 <CACxu=vKLc6f5N8_DR58LKkE1eohWSxTvThTeGsLm7p7QH1aFBA@mail.gmail.com>
 <CACxu=vJf2S=ysun_h=zmYNu6oUM47+egbpX5mMC0X9BJK=EQwQ@mail.gmail.com>
 <CACxu=vK+S6BXN8ZYyBvqQBWrcwHXqtue1-ZuKO3+XtHGBYcDUQ@mail.gmail.com>
 <CAFj8pRCd6xcH-AYEyHFdGdU89O9JjZ-v-pyQnOwd9zNJkCEdhQ@mail.gmail.com>
 <3797606.1732045516@sss.pgh.pa.us> <CACxu=vKqoHGmnuaTehd3Jc7vEMuCktA+F=QHYqqvZGW1am2ASg@mail.gmail.com>
 <2234661.1733272923@sss.pgh.pa.us> <CACxu=vKCSSqO6y0ES4SJnFSMBa8szANOykQkG3L1LsLnN2v0JA@mail.gmail.com>
In-Reply-To: <CACxu=vKCSSqO6y0ES4SJnFSMBa8szANOykQkG3L1LsLnN2v0JA@mail.gmail.com>
From: Michel Pelletier <pelletier.michel@gmail.com>
Date: Sat, 7 Dec 2024 23:05:13 -0800
Message-ID: <CACxu=vL4g2pPgEg66F-ttZ5jVuMba8K31vsoEYKbTJ7q6jk0hg@mail.gmail.com>
Subject: Re: Using Expanded Objects other than Arrays from plpgsql
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000085f6ac0628bce11e"
Archived-At: <https://www.postgresql.org/message-id/CACxu%3DvL4g2pPgEg66F-ttZ5jVuMba8K31vsoEYKbTJ7q6jk0hg%40mail.gmail.com>
Precedence: bulk

--00000000000085f6ac0628bce11e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 6, 2024 at 4:51=E2=80=AFPM Michel Pelletier <pelletier.michel@g=
mail.com>
wrote:

>
>  My question is about nvals =3D nvals(graph) in that function above, the
> object is flattened and then rexpanded, even after the object was expande=
d
> and returned by wait() [1] into a r/w pointer.
>
...

>
> mxm calls expand_matrix three times for each of the three arguments.
> Ideally I'd like the already expanded rw pointer from wait() to be honore=
d
> by mxm so that it doesn't re-expand the object three times but, like
> set_element, not at all.
>

My bad, sorry for the long confusing email, I figured out that I was
calling the wrong macro when getting my matrix datum and inadvertently
expanding RO pointers as well, I've fixed that issue, and everything is
working great!  No extra expansions and my support functions are working
well, I need to go through a few more places in the API to add more support
but otherwise the fixes Tom has put into plpgsql have worked perfectly and
the library now appears to be behaving optimally!  I can get down to doing
some benchmarks and head-to-head with the C and Python bindings to compare
against.

Thanks for your help Tom, I'm looking forward to the changes being released
soon!  In the meanwhile I'll keep a locally patched version for ongoing
testing purposes.

-Michel

>

--00000000000085f6ac0628bce11e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Dec 6, =
2024 at 4:51=E2=80=AFPM Michel Pelletier &lt;<a href=3D"mailto:pelletier.mi=
chel@gmail.com">pelletier.michel@gmail.com</a>&gt; wrote:<br></div><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"=
><br></div><div class=3D"gmail_quote"><div>=C2=A0My question is about nvals=
 =3D nvals(graph) in that function above, the object is flattened and then =
rexpanded, even after the object was expanded and returned by wait() [1] in=
to a r/w pointer.=C2=A0</div></div></div></blockquote><div>...=C2=A0</div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div clas=
s=3D"gmail_quote"><div><br></div><div>mxm calls expand_matrix three times f=
or each of the three arguments.=C2=A0 Ideally I&#39;d like the already expa=
nded rw pointer from wait() to be honored by mxm so that it doesn&#39;t re-=
expand=C2=A0the object three times but, like set_element, not at all.</div>=
</div></div></blockquote><div><br></div><div>My bad, sorry for the long con=
fusing email, I figured out that I was calling the wrong macro when getting=
 my matrix datum and inadvertently expanding RO pointers as well, I&#39;ve =
fixed that issue, and everything is working great!=C2=A0 No extra expansion=
s and my support functions are working well, I need to go through a few mor=
e places in the API to add more support but otherwise the fixes Tom has put=
 into plpgsql have worked perfectly and the library now appears to be behav=
ing optimally!=C2=A0 I can get down to doing some benchmarks and head-to-he=
ad with the C and Python bindings to compare against.</div><div><br></div><=
div>Thanks for your help Tom, I&#39;m looking forward to the changes being =
released soon!=C2=A0 In the meanwhile I&#39;ll keep a locally patched versi=
on for ongoing testing purposes.</div><div><br></div><div>-Michel</div><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex">
</blockquote></div></div>

--00000000000085f6ac0628bce11e--