Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vNxZk-0039pU-1Q for pgsql-general@arkaria.postgresql.org; Tue, 25 Nov 2025 18:15:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vNxZi-00AbzE-03 for pgsql-general@arkaria.postgresql.org; Tue, 25 Nov 2025 18:15:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vNxZh-00Abz6-1w for pgsql-general@lists.postgresql.org; Tue, 25 Nov 2025 18:15:37 +0000 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vNxZf-001T2K-2x for pgsql-general@lists.postgresql.org; Tue, 25 Nov 2025 18:15:37 +0000 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-78a6a7654a4so58218117b3.0 for ; Tue, 25 Nov 2025 10:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764094533; x=1764699333; darn=lists.postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=8CAZAPjhcUBwxSx3rGGDccbRPhtVvj9OUALEEz7dL8Y=; b=jsXmxNomV7kOwz/vuA7iV+hMjKPFh8cJ0YUGjoq0bFW/1Y9HiyB7zLdUJx37mFqraA +eNaUHFROeLwdVz6DUm39cxM44/WYm1pxpf/wBo7t69Wjjmm7wxl2WVV5TzqPPm0ntdq qh8cubBlcA7EfwXpB1dfsUftHQw7tWQ9I36yqwLRvZxRFLQsKnVdLe+S61HiZ/f0pLmr L8eAE3HhrMwI7sDq15+qA7yO7ckbgRxikLZ/gOJLH6AukSiJjEo/6goTO1d1an+bnXgH Ld5L8O+NTsjRf53h18IwdBj+IbmxSp+VCl4e1B12oAsVxx+y+s+7xY7t43WT4OHsi9R5 qgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764094533; x=1764699333; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8CAZAPjhcUBwxSx3rGGDccbRPhtVvj9OUALEEz7dL8Y=; b=mGud+/zjOy7TqLcGJUKgLTMmZoWgs4KrNJw/G56cVqDzlGkDQK6vFuZYsVgJmK1Npy F2zvU3cDFmeiITM2dREnBBfcxgzQ1PVyw5na4RN0Ltg2Bl7IB7PlQbeNB5gaz5V23fm9 WUrteYgv5J1vm3PvALa2oY8KinR1ipf8Gxl167zHm5Mv8mIXht0Ik/O5VE9T0IceKXob KOKMNShAOjXsFgxtyiBF00B0ANi0BGIVRv+zpgydbBuJ/CayfCAQy8W2pb/fvg6xEHSw 5eufMPhfSwSMopncKAneCWMemA4AbNxvMI2kYFLM5XFkJdPzP7hKcALB+fxH/v6kj9pq Cdsw== X-Gm-Message-State: AOJu0YyfeMretxpEaRwtUN2RVKh9Aj5pJBaXJmIgLZBLdYq6AGlbzYke hxCwwQG7161WykXPRxe+cKT1OdkUaCHkieIZuZ5Y0j0ZXKAlVJat81YUtLQpWlp5Mpew3IL3tYF E/0ZUPfvf3Y5APx/yiWmPkA2mIu9VySDE8zEr X-Gm-Gg: ASbGncuLKmOizhSf9qGvrzH1NhuCjosp60nymgIXwbnJJfg/1JMsFdkPwbQfkf8x0nf uaEcX6PW7URTGg/NsAKMhz9I0tO+K6akrA+ywNIadsattU9ssnUOvZNG1qulYgbcFGYylvYqYaM 4JawjPr4+60Pt/+OifcJTdDKNs2JBlWND4zBj4+M4aJyX/o+5dCCgaYoZQctvGsOSxnvHYE7T26 ADn/4PUPQufMPnj3RZlaz75/uT/jRcPS84gynJKU7OMb/lvU87lNi3SakuWmhImbwUUtSx7A9nx 5QVMQw== X-Google-Smtp-Source: AGHT+IG757uQapoM5PV+tetSwlscVlD95PtQ/EClCEyC37tGKu/lp/ntxdS/CxgcfZNgLL1UrswKjGnIELuVb7WzCBY= X-Received: by 2002:a05:690c:e1f:b0:786:4fd5:e5de with SMTP id 00721157ae682-78a8b56e89cmr142484557b3.67.1764094533195; Tue, 25 Nov 2025 10:15:33 -0800 (PST) MIME-Version: 1.0 From: Bernice Southey Date: Tue, 25 Nov 2025 18:14:57 +0000 X-Gm-Features: AWmQ_blbKXrPqKXd0L_-5cJIl64rIhGnelx4AuSemIffAUJdGv6cNPmRFJRo5Kw Message-ID: Subject: Indentation in a patch To: pgsql-general@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, I'm having a fight with git and indentation for my first ever patch attempt. I'm just adding an if statement around an existing 70-line code-block. It's a very simple few lines with --ignore-all-space. But the patch file is noisy because of 140 lines of +/- indentation diffs. I then realised the standard was tabs, and after fixing my spaces, things got even worse. The 140 lines now interleave in many unreadable chunks. I've tried different diff-algorithms, but they make no difference. I'm tempted to submit my patch without indenting the if-block, and an explanation. Any better suggestions? While I'm asking, I added a regression test and ran make check-world with the TAP tests. Anything else I should do before sending it to hackers? Thanks, Bernice