public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dominique Devienne <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: libpq version macro to use or not PQsocketPoll
Date: Fri, 9 Aug 2024 15:49:33 +0200
Message-ID: <CAFCRh--rSHr4uz4QX0hfF1nJYx2YipoPOw9qXxK=7fF-wN74Yg@mail.gmail.com> (raw)
In-Reply-To: <CAFCRh-_9f05Rw2BBbCDGhEZTs3358nyTej4t3w_QuCQne_NxjQ@mail.gmail.com>
References: <CAFCRh-_Fz4HDKt_y+qr-Gztrh+vMiJ4EFxFHDLgC6AePJpWOzQ@mail.gmail.com>
	<[email protected]>
	<CAFCRh-_9f05Rw2BBbCDGhEZTs3358nyTej4t3w_QuCQne_NxjQ@mail.gmail.com>

On Tue, Aug 6, 2024 at 4:48 PM Dominique Devienne <[email protected]> wrote:
> On Tue, Aug 6, 2024 at 4:31 PM Tom Lane <[email protected]> wrote:
> > Dominique Devienne <[email protected]> writes:
> > Indeed, that's an oversight, and there's a number of other things
> > we added to libpq-fe.h between 16 and 17 that probably deserve
> > their own LIBPQ_HAS symbols.

Hi. Doesn't look like beta3 _has_ them (pun indented :)).
Was probably too late for the beta3 release train.

> We can have both. Also, version macros don't
> multiply the way _HAS_ macros do, over time.

I stumbled on such version macros today by chance.
And pg_config.h seems available on both Windows and Linux.
So I guess that's good enough for conditional compilation.

From the old post I found, and your recent reply Tom,
I got the impression these macros didn't exist. FWIW. --DD

[ddevienne@acme include]$ sift VERSION pg*.h
pg_config.h:#define PACKAGE_VERSION "16.1"
pg_config.h:#define PG_MAJORVERSION "16"
pg_config.h:#define PG_MAJORVERSION_NUM 16
pg_config.h:#define PG_MINORVERSION_NUM 1
pg_config.h:#define PG_VERSION "16.1"
pg_config.h:#define PG_VERSION_NUM 160001
pg_config.h:#define PG_VERSION_STR "PostgreSQL 16.1 on
x86_64-pc-linux-gnu, compiled by gcc (GCC) 12.2.1 20221121 (Red Hat
12.2.1-7), 64-bit"

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: libpq version macro to use or not PQsocketPoll
  In-Reply-To: <CAFCRh--rSHr4uz4QX0hfF1nJYx2YipoPOw9qXxK=7fF-wN74Yg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox