MIME-Version: 1.0
References: <CO1PR04MB8281387B9AD9DE30976966BBC045A@CO1PR04MB8281.namprd04.prod.outlook.com>
 <6add2a9a-7cf2-4d1b-8f3e-2e26a7ebe883@aklaver.com> <4d8122febd3007143504e4b6034b4253f7000761.camel@cybertec.at>
 <PH0PR04MB82943D67CD179002714AA503C044A@PH0PR04MB8294.namprd04.prod.outlook.com>
 <f2ebeef82fddaf8a8152383f8ff62e75f20aac3c.camel@cybertec.at>
 <PH0PR04MB8294E796D6297D4E3BE4EFB6C049A@PH0PR04MB8294.namprd04.prod.outlook.com>
 <08d943a83590308cbb9be594d80b4e19ca80e08e.camel@cybertec.at>
 <2505eef1-b6aa-4518-baff-861a2e6a507b@gmail.com> <b65126bf381d4b41f561afe691000b77ac7b8cc2.camel@cybertec.at>
 <a018a729-9b18-444f-baed-be0d6d8ecb80@gmail.com> <2c1f1834107045dfa8b32417771b56bab0cffc56.camel@cybertec.at>
 <2cce9851-327a-4b1a-ab8e-531c2f92532b@gmail.com> <CAHGQGwEvwpydO7hjnB51Q2zgS0ydv31X4HCFLNzMeqLr=poS8w@mail.gmail.com>
 <9c9cb744-b8c7-4d75-acad-595b3faba187@gmail.com> <CAHGQGwEj8PCk1OVveJ_F1sj_COrV95N-mfu_tLUn4gdcAM24kA@mail.gmail.com>
 <9a93cffe79e2be1d9450a36e773a39dc456c241e.camel@cybertec.at>
In-Reply-To: <9a93cffe79e2be1d9450a36e773a39dc456c241e.camel@cybertec.at>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 18 Aug 2025 11:38:23 +0900
Message-ID: <CAHGQGwGje3mv5sOmyCJ0NroNPF8938OYCOHMJZbegTekccZZ=g@mail.gmail.com>
Subject: Re: analyze-in-stages post upgrade questions
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Mircea Cadariu <cadariu.mircea@gmail.com>, 
	"Zechman, Derek S" <Derek.S.Zechman@snapon.com>, Adrian Klaver <adrian.klaver@aklaver.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000e42cc0063c9aa299"
Archived-At: <https://www.postgresql.org/message-id/CAHGQGwGje3mv5sOmyCJ0NroNPF8938OYCOHMJZbegTekccZZ%3Dg%40mail.gmail.com>
Precedence: bulk

--000000000000e42cc0063c9aa299
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 7, 2025 at 5:52=E2=80=AFAM Laurenz Albe <laurenz.albe@cybertec.=
at> wrote:
> > I understand your point. But on second thought, since the patch changes
> > behavior, I'm leaning toward treating it as an improvement, so it shoul=
d
> > only go to master...
>
> I agree that this behavior change should not be backpatched.
> That is not a bugfix.

+1

> > --------------------
> > vacuumdb should generally follow the behavior of the underlying
> > VACUUM and ANALYZE commands. If analyze_only is true, process
> > regular tables, materialized views, and partitioned tables, just like
> > ANALYZE (with no specific target tables) does. Otherwise, process
> > only regular tables and materialized views, since VACUUM skips
> > partitioned tables when no target tables are specified.
> > --------------------
>
> I am fine with that suggestion.

Thanks! So I've updated the patch based on my earlier comments.
Unless there are objections, I'll commit the attached version to master onl=
y.

Regards,

--=20
Fujii Masao

--000000000000e42cc0063c9aa299
Content-Type: application/octet-stream; 
	name="v3-0001-vacuumdb-Make-vacuumdb-analyze-only-process-parti.patch"
Content-Disposition: attachment; 
	filename="v3-0001-vacuumdb-Make-vacuumdb-analyze-only-process-parti.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_megi9jde0>
X-Attachment-Id: f_megi9jde0

RnJvbSA1Yzk2OTM3OTUxNGFlZDZkZTYxMjE2NWYzOWZhNzA5NzQwYTU2OTMzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IE1vbiwgMTggQXVnIDIwMjUgMTA6NDE6MTUgKzA5MDAKU3ViamVjdDogW1BBVENIIHYzXSB2
YWN1dW1kYjogTWFrZSB2YWN1dW1kYiAtLWFuYWx5emUtb25seSBwcm9jZXNzIHBhcnRpdGlvbmVk
CiB0YWJsZXMuCgp2YWN1dW1kYiBzaG91bGQgZm9sbG93IHRoZSBiZWhhdmlvciBvZiB0aGUgdW5k
ZXJseWluZyBWQUNVVU0gYW5kIEFOQUxZWkUKY29tbWFuZHMuIFdoZW4gLS1hbmFseXplLW9ubHkg
aXMgdXNlZCwgaXQgb3VnaHQgdG8gYW5hbHl6ZSByZWd1bGFyIHRhYmxlcywKbWF0ZXJpYWxpemVk
IHZpZXdzLCBhbmQgcGFydGl0aW9uZWQgdGFibGVzLCBqdXN0IGFzIEFOQUxZWkUgKHdpdGggbm8g
ZXhwbGljaXQKdGFyZ2V0IHRhYmxlcykgZG9lcy4gT3RoZXJ3aXNlLCBpdCBzaG91bGQgb25seSBw
cm9jZXNzIHJlZ3VsYXIgdGFibGVzIGFuZAptYXRlcmlhbGl6ZWQgdmlld3MsIHNpbmNlIFZBQ1VV
TSBza2lwcyBwYXJ0aXRpb25lZCB0YWJsZXMgd2hlbiBubyB0YXJnZXRzCmFyZSBnaXZlbi4KClBy
ZXZpb3VzbHksIHZhY3V1bWRiIC0tYW5hbHl6ZS1vbmx5IHNraXBwZWQgcGFydGl0aW9uZWQgdGFi
bGVzLiBUaGlzIHdhcwppbmNvbnNpc3RlbnQsIGFuZCBhbHNvIGluY29udmVuaWVudCBhZnRlciBw
Z191cGdyYWRlLCB3aGVyZSAtLWFuYWx5emUtb25seQppcyB0eXBpY2FsbHkgdXNlZCB0byBnYXRo
ZXIgbWlzc2luZyBzdGF0aXN0aWNzLgoKVGhpcyBjb21taXQgZml4ZXMgdGhlIGJlaGF2aW9yIHNv
IHRoYXQgdmFjdXVtZGIgLS1hbmFseXplLW9ubHkgYWxzbyBwcm9jZXNzZXMKcGFydGl0aW9uZWQg
dGFibGVzLiBBcyBhIHJlc3VsdCwgYm90aCB2YWN1dW1kYiAtLWFuYWx5emUtb25seSBhbmQKQU5B
TFlaRSAod2l0aCBubyBleHBsaWNpdCB0YXJnZXRzKSBub3cgYW5hbHl6ZSByZWd1bGFyIHRhYmxl
cywKcGFydGl0aW9uZWQgdGFibGVzLCBhbmQgbWF0ZXJpYWxpemVkIHZpZXdzLCBidXQgbm90IGZv
cmVpZ24gdGFibGVzLgoKQmVjYXVzZSB0aGlzIGlzIGEgbm9udHJpdmlhbCBiZWhhdmlvciBjaGFu
Z2UsIGl0IGlzIGFwcGxpZWQgb25seSB0byBtYXN0ZXIuCgpSZXBvcnRlZC1ieTogWmVjaG1hbiwg
RGVyZWsgUyA8RGVyZWsuUy5aZWNobWFuQHNuYXBvbi5jb20+CkF1dGhvcjogTGF1cmVueiBBbGJl
IDxsYXVyZW56LmFsYmVAY3liZXJ0ZWMuYXQ+CkNvLWF1dGhvcmVkLWJ5OiBNaXJjZWEgQ2FkYXJp
dSA8Y2FkYXJpdS5taXJjZWFAZ21haWwuY29tPgpSZXZpZXdlZC1ieTogRnVqaWkgTWFzYW8gPG1h
c2FvLmZ1amlpQGdtYWlsLmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS9DTzFQ
UjA0TUI4MjgxMzg3QjlBRDlERTMwOTc2OTY2QkJDMDQ1QSU0MENPMVBSMDRNQjgyODEubmFtcHJk
MDQucHJvZC5vdXRsb29rLmNvbQotLS0KIGRvYy9zcmMvc2dtbC9yZWYvdmFjdXVtZGIuc2dtbCAg
ICB8ICA5ICsrKysrKysrKwogc3JjL2Jpbi9zY3JpcHRzL3QvMTAwX3ZhY3V1bWRiLnBsIHwgMTEg
KysrKysrKysrKysKIHNyYy9iaW4vc2NyaXB0cy92YWN1dW1kYi5jICAgICAgICB8IDI0ICsrKysr
KysrKysrKysrKysrKysrLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCA0
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvdmFjdXVtZGIuc2dt
bCBiL2RvYy9zcmMvc2dtbC9yZWYvdmFjdXVtZGIuc2dtbAppbmRleCBjN2Q5ZGNhMTdiOC4uNTMx
NDc0ODA1MTUgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9yZWYvdmFjdXVtZGIuc2dtbAorKysg
Yi9kb2Mvc3JjL3NnbWwvcmVmL3ZhY3V1bWRiLnNnbWwKQEAgLTM5Nyw2ICszOTcsMTUgQEAgUG9z
dGdyZVNRTCBkb2N1bWVudGF0aW9uCiAgICAgICAgIE11bHRpcGxlIHRhYmxlcyBjYW4gYmUgdmFj
dXVtZWQgYnkgd3JpdGluZyBtdWx0aXBsZQogICAgICAgICA8b3B0aW9uPi10PC9vcHRpb24+IHN3
aXRjaGVzLgogICAgICAgIDwvcGFyYT4KKyAgICAgICA8cGFyYT4KKyAgICAgICAgSWYgbm8gdGFi
bGVzIGFyZSBzcGVjaWZpZWQgd2l0aCB0aGUgPG9wdGlvbj4tLXRhYmxlPC9vcHRpb24+IG9wdGlv
biwKKyAgICAgICAgPGFwcGxpY2F0aW9uPnZhY3V1bWRiPC9hcHBsaWNhdGlvbj4gd2lsbCBjbGVh
biBhbGwgcmVndWxhciB0YWJsZXMKKyAgICAgICAgYW5kIG1hdGVyaWFsaXplZCB2aWV3cyBpbiB0
aGUgY29ubmVjdGVkIGRhdGFiYXNlLgorICAgICAgICBJZiA8b3B0aW9uPi0tYW5hbHl6ZS1vbmx5
PC9vcHRpb24+IG9yCisgICAgICAgIDxvcHRpb24+LS1hbmFseXplLWluLXN0YWdlczwvb3B0aW9u
PiBpcyBhbHNvIHNwZWNpZmllZCwKKyAgICAgICAgaXQgd2lsbCBhbmFseXplIGFsbCByZWd1bGFy
IHRhYmxlcywgcGFydGl0aW9uZWQgdGFibGVzLAorICAgICAgICBhbmQgbWF0ZXJpYWxpemVkIHZp
ZXdzIChidXQgbm90IGZvcmVpZ24gdGFibGVzKS4KKyAgICAgICA8L3BhcmE+CiAgICAgICAgPHRp
cD4KICAgICAgICAgPHBhcmE+CiAgICAgICAgICBJZiB5b3Ugc3BlY2lmeSBjb2x1bW5zLCB5b3Ug
cHJvYmFibHkgaGF2ZSB0byBlc2NhcGUgdGhlIHBhcmVudGhlc2VzCmRpZmYgLS1naXQgYS9zcmMv
YmluL3NjcmlwdHMvdC8xMDBfdmFjdXVtZGIucGwgYi9zcmMvYmluL3NjcmlwdHMvdC8xMDBfdmFj
dXVtZGIucGwKaW5kZXggZmY1NmExM2I0NmIuLjI0MGYwZmRkM2U1IDEwMDY0NAotLS0gYS9zcmMv
YmluL3NjcmlwdHMvdC8xMDBfdmFjdXVtZGIucGwKKysrIGIvc3JjL2Jpbi9zY3JpcHRzL3QvMTAw
X3ZhY3V1bWRiLnBsCkBAIC0zNDAsNCArMzQwLDE1IEBAICRub2RlLT5pc3N1ZXNfc3FsX3VubGlr
ZSgKIAlxci9zdGF0ZW1lbnQ6XCBBTkFMWVpFL3N4LAogCSctLW1pc3Npbmctc3RhdHMtb25seSB3
aXRoIG5vIG1pc3NpbmcgcGFydGl0aW9uIHN0YXRzJyk7CiAKKyRub2RlLT5zYWZlX3BzcWwoJ3Bv
c3RncmVzJywKKwkiQ1JFQVRFIFRBQkxFIHBhcmVudF90YWJsZSAoYSBJTlQpIFBBUlRJVElPTiBC
WSBMSVNUIChhKTtcbiIKKwkgIC4gIkNSRUFURSBUQUJMRSBjaGlsZF90YWJsZSBQQVJUSVRJT04g
T0YgcGFyZW50X3RhYmxlIEZPUiBWQUxVRVMgSU4gKDEpO1xuIgorCSAgLiAiSU5TRVJUIElOVE8g
cGFyZW50X3RhYmxlIFZBTFVFUyAoMSk7XG4iKTsKKyRub2RlLT5pc3N1ZXNfc3FsX2xpa2UoCisJ
WworCQkndmFjdXVtZGInLCAnLS1hbmFseXplLW9ubHknLCAncG9zdGdyZXMnCisJXSwKKwlxci9z
dGF0ZW1lbnQ6IEFOQUxZWkUgcHVibGljLnBhcmVudF90YWJsZS9zLAorCSctLWFuYWx5emUtb25s
eSB1cGRhdGVzIHN0YXRpc3RpY3MgZm9yIHBhcnRpdGlvbmVkIHRhYmxlcycpOworCiBkb25lX3Rl
c3RpbmcoKTsKZGlmZiAtLWdpdCBhL3NyYy9iaW4vc2NyaXB0cy92YWN1dW1kYi5jIGIvc3JjL2Jp
bi9zY3JpcHRzL3ZhY3V1bWRiLmMKaW5kZXggNzliMTA5NmViMDguLjIyMDkzZTUwYWE1IDEwMDY0
NAotLS0gYS9zcmMvYmluL3NjcmlwdHMvdmFjdXVtZGIuYworKysgYi9zcmMvYmluL3NjcmlwdHMv
dmFjdXVtZGIuYwpAQCAtOTExLDEwICs5MTEsMjYgQEAgcmV0cmlldmVfb2JqZWN0cyhQR2Nvbm4g
KmNvbm4sIHZhY3V1bWluZ09wdGlvbnMgKnZhY29wdHMsCiAJICovCiAJaWYgKChvYmpmaWx0ZXIg
JiBPQkpGSUxURVJfVEFCTEUpID09IDApCiAJewotCQlhcHBlbmRQUUV4cEJ1ZmZlclN0cigmY2F0
YWxvZ19xdWVyeSwKLQkJCQkJCQkgIiBBTkQgYy5yZWxraW5kIE9QRVJBVE9SKHBnX2NhdGFsb2cu
PSkgQU5ZIChhcnJheVsiCi0JCQkJCQkJIENwcEFzU3RyaW5nMihSRUxLSU5EX1JFTEFUSU9OKSAi
LCAiCi0JCQkJCQkJIENwcEFzU3RyaW5nMihSRUxLSU5EX01BVFZJRVcpICJdKVxuIik7CisJCS8q
CisJCSAqIHZhY3V1bWRiIHNob3VsZCBnZW5lcmFsbHkgZm9sbG93IHRoZSBiZWhhdmlvciBvZiB0
aGUgdW5kZXJseWluZworCQkgKiBWQUNVVU0gYW5kIEFOQUxZWkUgY29tbWFuZHMuIElmIGFuYWx5
emVfb25seSBpcyB0cnVlLCBwcm9jZXNzCisJCSAqIHJlZ3VsYXIgdGFibGVzLCBtYXRlcmlhbGl6
ZWQgdmlld3MsIGFuZCBwYXJ0aXRpb25lZCB0YWJsZXMsIGp1c3QKKwkJICogbGlrZSBBTkFMWVpF
ICh3aXRoIG5vIHNwZWNpZmljIHRhcmdldCB0YWJsZXMpIGRvZXMuIE90aGVyd2lzZSwKKwkJICog
cHJvY2VzcyBvbmx5IHJlZ3VsYXIgdGFibGVzIGFuZCBtYXRlcmlhbGl6ZWQgdmlld3MsIHNpbmNl
IFZBQ1VVTQorCQkgKiBza2lwcyBwYXJ0aXRpb25lZCB0YWJsZXMgd2hlbiBubyB0YXJnZXQgdGFi
bGVzIGFyZSBzcGVjaWZpZWQuCisJCSAqLworCQlpZiAodmFjb3B0cy0+YW5hbHl6ZV9vbmx5KQor
CQkJYXBwZW5kUFFFeHBCdWZmZXJTdHIoJmNhdGFsb2dfcXVlcnksCisJCQkJCQkJCSAiIEFORCBj
LnJlbGtpbmQgT1BFUkFUT1IocGdfY2F0YWxvZy49KSBBTlkgKGFycmF5WyIKKwkJCQkJCQkJIENw
cEFzU3RyaW5nMihSRUxLSU5EX1JFTEFUSU9OKSAiLCAiCisJCQkJCQkJCSBDcHBBc1N0cmluZzIo
UkVMS0lORF9NQVRWSUVXKSAiLCAiCisJCQkJCQkJCSBDcHBBc1N0cmluZzIoUkVMS0lORF9QQVJU
SVRJT05FRF9UQUJMRSkgIl0pXG4iKTsKKwkJZWxzZQorCQkJYXBwZW5kUFFFeHBCdWZmZXJTdHIo
JmNhdGFsb2dfcXVlcnksCisJCQkJCQkJCSAiIEFORCBjLnJlbGtpbmQgT1BFUkFUT1IocGdfY2F0
YWxvZy49KSBBTlkgKGFycmF5WyIKKwkJCQkJCQkJIENwcEFzU3RyaW5nMihSRUxLSU5EX1JFTEFU
SU9OKSAiLCAiCisJCQkJCQkJCSBDcHBBc1N0cmluZzIoUkVMS0lORF9NQVRWSUVXKSAiXSlcbiIp
OworCiAJfQogCiAJLyoKLS0gCjIuNTAuMQoK
--000000000000e42cc0063c9aa299--