MIME-Version: 1.0
References: <CO1PR04MB8281387B9AD9DE30976966BBC045A@CO1PR04MB8281.namprd04.prod.outlook.com>
 <6add2a9a-7cf2-4d1b-8f3e-2e26a7ebe883@aklaver.com> <4d8122febd3007143504e4b6034b4253f7000761.camel@cybertec.at>
 <PH0PR04MB82943D67CD179002714AA503C044A@PH0PR04MB8294.namprd04.prod.outlook.com>
 <f2ebeef82fddaf8a8152383f8ff62e75f20aac3c.camel@cybertec.at>
 <PH0PR04MB8294E796D6297D4E3BE4EFB6C049A@PH0PR04MB8294.namprd04.prod.outlook.com>
 <08d943a83590308cbb9be594d80b4e19ca80e08e.camel@cybertec.at>
 <2505eef1-b6aa-4518-baff-861a2e6a507b@gmail.com> <b65126bf381d4b41f561afe691000b77ac7b8cc2.camel@cybertec.at>
 <a018a729-9b18-444f-baed-be0d6d8ecb80@gmail.com> <2c1f1834107045dfa8b32417771b56bab0cffc56.camel@cybertec.at>
 <2cce9851-327a-4b1a-ab8e-531c2f92532b@gmail.com> <CAHGQGwEvwpydO7hjnB51Q2zgS0ydv31X4HCFLNzMeqLr=poS8w@mail.gmail.com>
 <9c9cb744-b8c7-4d75-acad-595b3faba187@gmail.com> <CAHGQGwEj8PCk1OVveJ_F1sj_COrV95N-mfu_tLUn4gdcAM24kA@mail.gmail.com>
 <9a93cffe79e2be1d9450a36e773a39dc456c241e.camel@cybertec.at>
 <CAHGQGwGje3mv5sOmyCJ0NroNPF8938OYCOHMJZbegTekccZZ=g@mail.gmail.com> <ad3adb5df84c50d78e9c1d118f55a06f753dd7dd.camel@cybertec.at>
In-Reply-To: <ad3adb5df84c50d78e9c1d118f55a06f753dd7dd.camel@cybertec.at>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Tue, 19 Aug 2025 23:40:05 +0900
Message-ID: <CAHGQGwHpA8nJfnX1Tk8CiVRUuZofACUFRHwk-8i=9yHYtmqiTw@mail.gmail.com>
Subject: Re: analyze-in-stages post upgrade questions
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Mircea Cadariu <cadariu.mircea@gmail.com>, 
	"Zechman, Derek S" <Derek.S.Zechman@snapon.com>, Adrian Klaver <adrian.klaver@aklaver.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHGQGwHpA8nJfnX1Tk8CiVRUuZofACUFRHwk-8i%3D9yHYtmqiTw%40mail.gmail.com>
Precedence: bulk

On Mon, Aug 18, 2025 at 3:40=E2=80=AFPM Laurenz Albe <laurenz.albe@cybertec=
.at> wrote:
>
> On Mon, 2025-08-18 at 11:38 +0900, Fujii Masao wrote:
> > Thanks! So I've updated the patch based on my earlier comments.
> > Unless there are objections, I'll commit the attached version to master=
 only.
>
> I am fine with your patch.

Thanks for the review!


> One suggestion:
>
> > --- a/doc/src/sgml/ref/vacuumdb.sgml
> > +++ b/doc/src/sgml/ref/vacuumdb.sgml
> > @@ -397,6 +397,15 @@ PostgreSQL documentation
> >          Multiple tables can be vacuumed by writing multiple
> >          <option>-t</option> switches.
> >         </para>
> > +       <para>
> > +        If no tables are specified with the <option>--table</option> o=
ption,
> > +        <application>vacuumdb</application> will clean all regular tab=
les
> > +        and materialized views in the connected database.
> > +        If <option>--analyze-only</option> or
> > +        <option>--analyze-in-stages</option> is also specified,
> > +        it will analyze all regular tables, partitioned tables,
> > +        and materialized views (but not foreign tables).
> > +       </para>
>
> I suggest replacing "clean" with "process", since VACUUM does so much mor=
e than
> clean up dead tuples.

I see your point. However, since the vacuumdb docs already use "clean"
in several places, I think it's better to keep using "clean" here
for consistency. Thought?


> Concerning backpatching, I voted against, but I suggest that this be back=
patched
> to v18.  I don't feel very strongly about it though.

As for back-patching, I failed to find a strong reason to apply this change
to v18 over the many other patches that could not be committed before
the feature freeze... Of course if there's broad support for back-patching,
we can certainly revisit it. But for now I'm thinking to commit the patch
to master.

Regards,

--=20
Fujii Masao