MIME-Version: 1.0
References: <28773a66-fb88-41cf-a7ec-4216e6c91c94@oss.nttdata.com>
 <Z9ROT9v4rHjDYWNX@nathan> <CABwTF4WFp-oNSm6utik6g-1HZBxijTJBcuX7BKD8MYqza+KMnw@mail.gmail.com>
 <6f2f2167f4be09e6ca9251c8f69dfe01809d68be.camel@cybertec.at>
 <CABV9wwNagobmRMCxs0dKqWmKXaQTUQj+oOOTw=fsPAgbBfVhew@mail.gmail.com>
 <Z9g8a4HGLUcSo96v@nathan> <Z9ohFZtDaZnkch7u@nathan> <88e3b55a-8ef8-4b53-8d71-6bfde1a07bc1@oss.nttdata.com>
 <Z9rlb0jgNLm8ULAB@nathan> <Z9rsMX5ZOL5E0cQy@nathan> <Z9wxuP1AY303wAxM@nathan>
In-Reply-To: <Z9wxuP1AY303wAxM@nathan>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Thu, 20 Mar 2025 09:59:45 -0700
Message-ID: <CAKFQuwYKtEUYKS+18gRs-xPhn0qOJgM2KGyyWVCODHuVn9F-XQ@mail.gmail.com>
Subject: Re: Disabling vacuum truncate for autovacuum
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Robert Treat <rob@xzilla.net>, 
	Laurenz Albe <laurenz.albe@cybertec.at>, Gurjeet Singh <gurjeet@singh.im>, 
	Andres Freund <andres@anarazel.de>, Will Storey <will@summercat.com>, 
	Robert Haas <robertmhaas@gmail.com>, Postgres Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000cb48c80630c912f5"
Archived-At: <https://www.postgresql.org/message-id/CAKFQuwYKtEUYKS%2B18gRs-xPhn0qOJgM2KGyyWVCODHuVn9F-XQ%40mail.gmail.com>
Precedence: bulk

--000000000000cb48c80630c912f5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 20, 2025 at 8:18=E2=80=AFAM Nathan Bossart <nathandbossart@gmai=
l.com>
wrote:

> Committed.
>
>
We added isset_offset to the public struct to introduce this new general
behavior of tracking whether any table reloption has been set (not just
vacuum_truncate) without any comments.

I get the need for this kind of logic, since we used a boolean for the
table option, but as a self-proclaimed hack it seems worth more comments
than provided here.  Especially pertaining to whether this is indeed
generic or vacuum_truncate specific.  It's unclear since both isset and
vacuum_truncate_set have been introduced.  If it is now a general property
applying to any setting then vacuum_truncate_set shouldn't be needed - we
should just get the isset value of the existing vacuum_truncate reloption
by name.

David J.

--000000000000cb48c80630c912f5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,helvetica,sans-serif"><span style=3D"font-family:Arial,Helve=
tica,sans-serif">On Thu, Mar 20, 2025 at 8:18=E2=80=AFAM Nathan Bossart &lt=
;<a href=3D"mailto:nathandbossart@gmail.com">nathandbossart@gmail.com</a>&g=
t; wrote:</span></div></div><div class=3D"gmail_quote gmail_quote_container=
"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex">Committed.<br><br></blo=
ckquote><div><br></div><div class=3D"gmail_default" style=3D"font-family:ar=
ial,helvetica,sans-serif">We added isset_offset to the public struct to int=
roduce this new general behavior of tracking=C2=A0whether any table relopti=
on has been set (not just vacuum_truncate) without any comments.</div><div =
class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif"><b=
r></div><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,s=
ans-serif">I get the need for this kind of logic, since we used a boolean f=
or the table option, but as a self-proclaimed hack it seems worth more comm=
ents than provided here.=C2=A0 Especially pertaining to whether this is ind=
eed generic or vacuum_truncate specific.=C2=A0 It&#39;s unclear since both =
isset and vacuum_truncate_set have been introduced.=C2=A0 If it is now a ge=
neral property applying to any setting then vacuum_truncate_set shouldn&#39=
;t be needed - we should just get the isset value of the existing vacuum_tr=
uncate reloption by name.</div><div class=3D"gmail_default" style=3D"font-f=
amily:arial,helvetica,sans-serif"><br></div><div class=3D"gmail_default" st=
yle=3D"font-family:arial,helvetica,sans-serif">David J.</div><div class=3D"=
gmail_default" style=3D"font-family:arial,helvetica,sans-serif"><br></div><=
/div></div>

--000000000000cb48c80630c912f5--