MIME-Version: 1.0
In-Reply-To: <CAAPsdhfQ0GvDuNeMZpe_sccHcM=7dHZq=C6wXbM8zFr_X2FD3g@mail.gmail.com>
References: <CANzqJaB=-AUnoXh+V6ayLPbRut7yNt7utL-=0+OK4hdh35-cTQ@mail.gmail.com>
 <CAAPsdhfQ0GvDuNeMZpe_sccHcM=7dHZq=C6wXbM8zFr_X2FD3g@mail.gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Thu, 6 Jun 2024 21:32:09 -0700
Message-ID: <CAKFQuwYhAbOwvMfCSWg4VMAWDUX1kCZAdG1XQMKnWWFZYyOpTA@mail.gmail.com>
Subject: Re: PG 14 pg_basebackup accepts --compress=server-zst option
To: Kashif Zeeshan <kashi.zeeshan@gmail.com>
Cc: Ron Johnson <ronljohnsonjr@gmail.com>, pgsql-general <pgsql-general@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000006d655a061a4548aa"
Archived-At: <https://www.postgresql.org/message-id/CAKFQuwYhAbOwvMfCSWg4VMAWDUX1kCZAdG1XQMKnWWFZYyOpTA%40mail.gmail.com>
Precedence: bulk

--0000000000006d655a061a4548aa
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thursday, June 6, 2024, Kashif Zeeshan <kashi.zeeshan@gmail.com> wrote:

> Hi
>
> On Fri, Jun 7, 2024 at 6:54=E2=80=AFAM Ron Johnson <ronljohnsonjr@gmail.c=
om>
> wrote:
>
>>
>> https://www.postgresql.org/docs/14/app-pgbasebackup.html doesn't mention
>> "--compress=3D[{client|server}-]method".  That first appears in the v15
>> docs.
>>
>> And yet pg_basebackup doesn't complain about an invalid option.
>> (Technically, this is a bug; I first noticed it a week after copying a
>> script from a PG 15 server to five PG 14 servers, and running it quite a
>> few times without fail.)
>>
>
Seems a bit suspect, but as your script doesn=E2=80=99t mention tar the opt=
ion
itself is apparently ignored, I guess silently.  Assuming this isn=E2=80=99=
t an
actual regression in behavior in a patch-released older version I don=E2=80=
=99t see
us adding an error message at this point.


> If the support is removed then it should be mentioned in the official
> documentation.
>

Support wasn=E2=80=99t removed.  Re-read the email and check the version/ti=
mes
being mentioned again.

David J.

--0000000000006d655a061a4548aa
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thursday, June 6, 2024, Kashif Zeeshan &lt;<a href=3D"mailto:kashi.zeesh=
an@gmail.com">kashi.zeeshan@gmail.com</a>&gt; wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"g=
mail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jun 7, 2024 at 6:=
54=E2=80=AFAM Ron Johnson &lt;<a href=3D"mailto:ronljohnsonjr@gmail.com" ta=
rget=3D"_blank">ronljohnsonjr@gmail.com</a>&gt; wrote:<br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px so=
lid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div><br></div><div=
><a href=3D"https://www.postgresql.org/docs/14/app-pgbasebackup.html" targe=
t=3D"_blank">https://www.postgresql.org/<wbr>docs/14/app-pgbasebackup.html<=
/a> doesn&#39;t mention &quot;--compress=3D[{client|server}-]<wbr>method&qu=
ot;.=C2=A0 That first appears in the v15 docs.<br></div><div><br></div><div=
>And yet pg_basebackup doesn&#39;t complain about an invalid option.=C2=A0 =
(Technically, this is a bug; I first noticed it a week after copying a scri=
pt from a PG 15 server to five PG 14 servers, and running it quite a few ti=
mes without fail.)</div></div></blockquote></div></div></blockquote><div><b=
r></div><div>Seems a bit suspect, but as your script doesn=E2=80=99t mentio=
n tar the option itself is apparently ignored, I guess silently.=C2=A0 Assu=
ming this isn=E2=80=99t an actual regression in behavior in a patch-release=
d older version I don=E2=80=99t see us adding an error message at this poin=
t.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:=
0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><d=
iv class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
<div dir=3D"ltr"></div></blockquote><div>If the support is removed then it =
should be mentioned=C2=A0in the official documentation.</div></div></div></=
blockquote><div><br></div><div>Support wasn=E2=80=99t removed.=C2=A0 Re-rea=
d the email and check the version/times being mentioned again.</div><div><b=
r></div><div>David J.</div><div><br></div>

--0000000000006d655a061a4548aa--