MIME-Version: 1.0
References: <CABwTF4WFp-oNSm6utik6g-1HZBxijTJBcuX7BKD8MYqza+KMnw@mail.gmail.com>
 <6f2f2167f4be09e6ca9251c8f69dfe01809d68be.camel@cybertec.at>
 <CABV9wwNagobmRMCxs0dKqWmKXaQTUQj+oOOTw=fsPAgbBfVhew@mail.gmail.com>
 <Z9g8a4HGLUcSo96v@nathan> <Z9ohFZtDaZnkch7u@nathan> <88e3b55a-8ef8-4b53-8d71-6bfde1a07bc1@oss.nttdata.com>
 <Z9rlb0jgNLm8ULAB@nathan> <Z9rsMX5ZOL5E0cQy@nathan> <Z9wxuP1AY303wAxM@nathan>
 <CAKFQuwYKtEUYKS+18gRs-xPhn0qOJgM2KGyyWVCODHuVn9F-XQ@mail.gmail.com> <Z9xaroJSrS44HyKG@nathan>
In-Reply-To: <Z9xaroJSrS44HyKG@nathan>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Fri, 21 Mar 2025 08:54:55 -0700
Message-ID: <CAKFQuwaduAUn=v-vnTkW0hXs2G5Yv0nxcHDDiuviet4FTxFzMQ@mail.gmail.com>
Subject: Re: Disabling vacuum truncate for autovacuum
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Robert Treat <rob@xzilla.net>, 
	Laurenz Albe <laurenz.albe@cybertec.at>, Gurjeet Singh <gurjeet@singh.im>, 
	Andres Freund <andres@anarazel.de>, Will Storey <will@summercat.com>, 
	Robert Haas <robertmhaas@gmail.com>, Postgres Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000dc21f90630dc4827"
Archived-At: <https://www.postgresql.org/message-id/CAKFQuwaduAUn%3Dv-vnTkW0hXs2G5Yv0nxcHDDiuviet4FTxFzMQ%40mail.gmail.com>
Precedence: bulk

--000000000000dc21f90630dc4827
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 20, 2025 at 11:13=E2=80=AFAM Nathan Bossart <nathandbossart@gma=
il.com>
wrote:

>
> How does something like this look for the comment?
>
>         /*
>          * isset_offset is an optional offset of a field in the result
> struct
>          * that stores whether the value is explicitly set for the
> relation or
>          * has just picked up the default value.  In most cases, this can
> be
>          * deduced by giving the reloption a special default value (e.g.,
> -2 is
>          * a common one for integer reloptions), but this isn't always
>          * possible.  One notable example is Boolean reloptions, where it=
's
>          * difficult to discern the source of the value.  This offset is
> only
>          * used if given a value greater than zero.
>          */
>         int                     isset_offset;
>
>
>
I didn't actually come back to this before writing my comment.

I'm glad they both say basically the same thing.

I'm still partial to mine but yours probably fits the overall style of the
codebase better.

David J.

--000000000000dc21f90630dc4827
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,helvetica,sans-serif"><span style=3D"font-family:Arial,Helve=
tica,sans-serif">On Thu, Mar 20, 2025 at 11:13=E2=80=AFAM Nathan Bossart &l=
t;<a href=3D"mailto:nathandbossart@gmail.com">nathandbossart@gmail.com</a>&=
gt; wrote:</span></div></div><div class=3D"gmail_quote gmail_quote_containe=
r"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
How does something like this look for the comment?<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /*<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* isset_offset is an optional offset of a=
 field in the result struct<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* that stores whether the value is explic=
itly set for the relation or<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* has just picked up the default value.=
=C2=A0 In most cases, this can be<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* deduced by giving the reloption a speci=
al default value (e.g., -2 is<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* a common one for integer reloptions), b=
ut this isn&#39;t always<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* possible.=C2=A0 One notable example is =
Boolean reloptions, where it&#39;s<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* difficult to discern the source of the =
value.=C2=A0 This offset is only<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* used if given a value greater than zero=
.<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 int=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0isset_offset;<br>
<br><br></blockquote><div><br></div><div class=3D"gmail_default" style=3D"f=
ont-family:arial,helvetica,sans-serif">I didn&#39;t actually come back=C2=
=A0to this before writing my comment.</div><div class=3D"gmail_default" sty=
le=3D"font-family:arial,helvetica,sans-serif"><br></div><div class=3D"gmail=
_default" style=3D"font-family:arial,helvetica,sans-serif">I&#39;m glad the=
y both say basically the same thing.</div><div class=3D"gmail_default" styl=
e=3D"font-family:arial,helvetica,sans-serif"><br></div><div class=3D"gmail_=
default" style=3D"font-family:arial,helvetica,sans-serif">I&#39;m still par=
tial to mine but yours probably fits the overall style of the codebase bett=
er.</div><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,=
sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-family:ari=
al,helvetica,sans-serif">David J.</div><div class=3D"gmail_default" style=
=3D"font-family:arial,helvetica,sans-serif"><br></div></div></div>

--000000000000dc21f90630dc4827--