public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G. Johnston <[email protected]>
To: Igor Korot <[email protected]>
Cc: pgsql-generallists.postgresql.org <[email protected]>
Subject: Re: Clarification on the docs
Date: Fri, 11 Apr 2025 20:22:03 -0700
Message-ID: <CAKFQuwbz_-LUeGO0ABOXDSe5EbzQUUsMV7NMP1kr6cnBRfuDpQ@mail.gmail.com> (raw)
In-Reply-To: <CA+FnnTyyUV-QwkSYbXoXmmoc+ghhEsmeEvjQ1QH6uFZVzvwR9A@mail.gmail.com>
References: <CA+FnnTz=EW1VQRpWB9J+G-NSchrPFcw4nR7d0JqzEK9jWKB35A@mail.gmail.com>
	<CAKFQuwZrL59BXqZB8c1x-dsUwSunDO=D39+kra0z+JraVcV6+Q@mail.gmail.com>
	<CA+FnnTyyUV-QwkSYbXoXmmoc+ghhEsmeEvjQ1QH6uFZVzvwR9A@mail.gmail.com>

On Friday, April 11, 2025, Igor Korot <[email protected]> wrote:

> Hi, David,
>
> On Fri, Apr 11, 2025 at 9:04 PM David G. Johnston <
> [email protected]> wrote:
>
>> On Fri, Apr 11, 2025 at 6:49 PM Igor Korot <[email protected]> wrote:
>>
>>> Hi, ALL,
>>> On the https://www.postgresql.org/docs/17/sql-createindex.html#
>>> SQL-CREATEINDEX-STORAGE-PARAMETERS
>>> its said:
>>>
>>> [quote]
>>> The optional WITH clause specifies storage parameters for the index.
>>> Each index method has its own set of allowed storage parameters. The
>>> B-tree, hash, GiST and SP-GiST index methods all accept this
>>> parameter:
>>> [/quote]
>>>
>>>
>> These are the index methods and the valid lists for each.  The docs are
>> correct in how they remove duplication.  I'm undecided on whether that is
>> the best presentation choice.  I would at minimum place a new paragraph
>> after "own set of allowed storage parameters." so that "The B-tree,
>> hash..." begins its own line.
>>
>

> This above looks much better. What stops you from pushing it?
>
> There is no double meaning and everything is split nicely.
>

Because I’m undecided on what exactly would be an improvement and don’t
care enough on the basis of this single question to put effort into
figuring that out.  Committers read these and if one of them wants to act
on my new paragraph suggestion great.  If not, it isn’t that big a deal.
For me, this doesn’t warrant a CF entry.

David J.

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Clarification on the docs
  In-Reply-To: <CAKFQuwbz_-LUeGO0ABOXDSe5EbzQUUsMV7NMP1kr6cnBRfuDpQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox