MIME-Version: 1.0
References: <CANzqJaCCF9kpfdbWbRR2xuqH_qaBgL+me13w2c-5S=_YATKh+Q@mail.gmail.com>
 <CAFj8pRDxMpQv4P3Bi-zEQ+OQ2dsVCZ+g-vbpU-F3qvozZKjUzA@mail.gmail.com> <1627466.1734283766@sss.pgh.pa.us>
In-Reply-To: <1627466.1734283766@sss.pgh.pa.us>
From: Isaac Morland <isaac.morland@gmail.com>
Date: Sun, 15 Dec 2024 12:40:12 -0500
Message-ID: <CAMsGm5dmNjPuYAg8V7yutENjgJod5pNXhoQpiWoPH3e7i1RrVg@mail.gmail.com>
Subject: Re: Request for new column in pg_namespace
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Ron Johnson <ronljohnsonjr@gmail.com>, 
	pgsql-general <pgsql-general@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000000b6f2a0629528ff5"
Archived-At: <https://www.postgresql.org/message-id/CAMsGm5dmNjPuYAg8V7yutENjgJod5pNXhoQpiWoPH3e7i1RrVg%40mail.gmail.com>
Precedence: bulk

--0000000000000b6f2a0629528ff5
Content-Type: text/plain; charset="UTF-8"

On Sun, 15 Dec 2024 at 12:29, Tom Lane <tgl@sss.pgh.pa.us> wrote:


> What I'd suggest as an improvement that could be implemented
> immediately is to wrap the checks in a user-defined function
> like "is_system_schema(nspname name)".
>

Would it make sense to make the parameter be of type regnamespace?

--0000000000000b6f2a0629528ff5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sun, 15 Dec 2024 at 12:29, Tom Lane &l=
t;<a href=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>&gt; wrote:<br>=
</div><div class=3D"gmail_quote gmail_quote_container"><div>=C2=A0</div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padd=
ing-left:1ex">
What I&#39;d suggest as an improvement that could be implemented<br>
immediately is to wrap the checks in a user-defined function<br>
like &quot;is_system_schema(nspname name)&quot;.<br></blockquote><div><br><=
/div><div>Would it make sense to make the parameter be of type regnamespace=
?=C2=A0</div></div></div>

--0000000000000b6f2a0629528ff5--