MIME-Version: 1.0
References: <CANzqJaB=-AUnoXh+V6ayLPbRut7yNt7utL-=0+OK4hdh35-cTQ@mail.gmail.com>
 <CAAPsdhfQ0GvDuNeMZpe_sccHcM=7dHZq=C6wXbM8zFr_X2FD3g@mail.gmail.com> <CAKFQuwYhAbOwvMfCSWg4VMAWDUX1kCZAdG1XQMKnWWFZYyOpTA@mail.gmail.com>
In-Reply-To: <CAKFQuwYhAbOwvMfCSWg4VMAWDUX1kCZAdG1XQMKnWWFZYyOpTA@mail.gmail.com>
From: Ron Johnson <ronljohnsonjr@gmail.com>
Date: Fri, 7 Jun 2024 08:04:33 -0400
Message-ID: <CANzqJaAAJmAhgbYYx1T-+-A_myAEOLgDbzE3m5zfOQMwNzcCQQ@mail.gmail.com>
Subject: Re: PG 14 pg_basebackup accepts --compress=server-zst option
To: pgsql-general <pgsql-general@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f0710a061a4b9a4f"
Archived-At: <https://www.postgresql.org/message-id/CANzqJaAAJmAhgbYYx1T-%2B-A_myAEOLgDbzE3m5zfOQMwNzcCQQ%40mail.gmail.com>
Precedence: bulk

--000000000000f0710a061a4b9a4f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 7, 2024 at 12:32=E2=80=AFAM David G. Johnston <
david.g.johnston@gmail.com> wrote:

> On Thursday, June 6, 2024, Kashif Zeeshan <kashi.zeeshan@gmail.com> wrote=
:
>
>> Hi
>>
>> On Fri, Jun 7, 2024 at 6:54=E2=80=AFAM Ron Johnson <ronljohnsonjr@gmail.=
com>
>> wrote:
>>
>>>
>>> https://www.postgresql.org/docs/14/app-pgbasebackup.html doesn't
>>> mention "--compress=3D[{client|server}-]method".  That first appears in=
 the
>>> v15 docs.
>>>
>>> And yet pg_basebackup doesn't complain about an invalid option.
>>> (Technically, this is a bug; I first noticed it a week after copying a
>>> script from a PG 15 server to five PG 14 servers, and running it quite =
a
>>> few times without fail.)
>>>
>>
> Seems a bit suspect, but as your script doesn=E2=80=99t mention tar the o=
ption
> itself is apparently ignored, I guess silently.
>

Does this mean that "--compress=3Dserver-zst" is only relevant with
--format=3Dtar?


> Assuming this isn=E2=80=99t an actual regression in behavior in a patch-r=
eleased
> older version
>

My apologies for not mentioning the version: 14.12-1PGDG-rhel8.


> I don=E2=80=99t see us adding an error message at this point.
>

Me neither.  It just seemed odd.

--000000000000f0710a061a4b9a4f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Jun 7, 2024 at 12:32=E2=80=AFAM D=
avid G. Johnston &lt;<a href=3D"mailto:david.g.johnston@gmail.com">david.g.=
johnston@gmail.com</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex">On Thursday, June 6, 2024, Kas=
hif Zeeshan &lt;<a href=3D"mailto:kashi.zeeshan@gmail.com" target=3D"_blank=
">kashi.zeeshan@gmail.com</a>&gt; wrote:<br><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jun 7, 2024 =
at 6:54=E2=80=AFAM Ron Johnson &lt;<a href=3D"mailto:ronljohnsonjr@gmail.co=
m" target=3D"_blank">ronljohnsonjr@gmail.com</a>&gt; wrote:<br></div><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div><br></div=
><div><a href=3D"https://www.postgresql.org/docs/14/app-pgbasebackup.html" =
target=3D"_blank">https://www.postgresql.org/docs/14/app-pgbasebackup.html<=
/a> doesn&#39;t mention &quot;--compress=3D[{client|server}-]method&quot;.=
=C2=A0 That first appears in the v15 docs.<br></div><div><br></div><div>And=
 yet pg_basebackup doesn&#39;t complain about an invalid option.=C2=A0 (Tec=
hnically, this is a bug; I first noticed it a week after copying a script f=
rom a PG 15 server to five PG 14 servers, and running it quite a few times =
without fail.)</div></div></blockquote></div></div></blockquote><div><br></=
div><div>Seems a bit suspect, but as your script doesn=E2=80=99t mention ta=
r the option itself is apparently ignored, I guess silently.=C2=A0 </div></=
blockquote><div><br></div><div>Does this mean that &quot;<span style=3D"fon=
t-family:monospace">--compress=3Dserver-zst</span>&quot; is only relevant w=
ith <font face=3D"monospace">--format=3Dtar</font>?</div><div>=C2=A0</div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"><div>Assuming this isn=E2=
=80=99t an actual regression in behavior in a patch-released older version =
</div></blockquote><div><br></div><div>My apologies for not mentioning the =
version: 14.12-1PGDG-rhel8.</div><div>=C2=A0</div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex"><div>I don=E2=80=99t see us adding an error messag=
e at this point.</div></blockquote><div><br></div><div>Me neither.=C2=A0 It=
 just seemed odd.</div><div><br></div></div></div>

--000000000000f0710a061a4b9a4f--