MIME-Version: 1.0
From: Ron Johnson <ronljohnsonjr@gmail.com>
Date: Thu, 6 Jun 2024 21:54:20 -0400
Message-ID: <CANzqJaB=-AUnoXh+V6ayLPbRut7yNt7utL-=0+OK4hdh35-cTQ@mail.gmail.com>
Subject: PG 14 pg_basebackup accepts --compress=server-zst option
To: pgsql-general <pgsql-general@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000a25ab2061a4314d7"
Archived-At: <https://www.postgresql.org/message-id/CANzqJaB%3D-AUnoXh%2BV6ayLPbRut7yNt7utL-%3D0%2BOK4hdh35-cTQ%40mail.gmail.com>
Precedence: bulk

--000000000000a25ab2061a4314d7
Content-Type: text/plain; charset="UTF-8"

https://www.postgresql.org/docs/14/app-pgbasebackup.html doesn't mention
"--compress=[{client|server}-]method".  That first appears in the v15 docs.

And yet pg_basebackup doesn't complain about an invalid option.
(Technically, this is a bug; I first noticed it a week after copying a
script from a PG 15 server to five PG 14 servers, and running it quite a
few times without fail.)

$ pg_basebackup \
>             --pgdata=$PGDATA \
>             --dbname=service=basebackup \
>             --verbose --progress \
>             --checkpoint=fast \
>             --write-recovery-conf \
>             --wal-method=stream \
>             --create-slot --slot=pgstandby1 \
>             --compress=server-zst ; echo $?
pg_basebackup: initiating base backup, waiting for checkpoint to complete
pg_basebackup: checkpoint completed
pg_basebackup: write-ahead log start point: 256/BC000028 on timeline 1
pg_basebackup: starting background WAL receiver
pg_basebackup: created replication slot "pgstandby1"
42567083/42567083 kB (100%), 1/1 tablespace
pg_basebackup: write-ahead log end point: 256/BC000138
pg_basebackup: waiting for background process to finish streaming ...
pg_basebackup: syncing data to disk ...
pg_basebackup: renaming backup_manifest.tmp to backup_manifest
pg_basebackup: base backup completed
0

--000000000000a25ab2061a4314d7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><br></div><div><a href=3D"https://www.postgresql.org/=
docs/14/app-pgbasebackup.html">https://www.postgresql.org/docs/14/app-pgbas=
ebackup.html</a> doesn&#39;t mention &quot;--compress=3D[{client|server}-]m=
ethod&quot;.=C2=A0 That first appears in the v15 docs.<br></div><div><br></=
div><div>And yet pg_basebackup doesn&#39;t complain about an invalid option=
.=C2=A0 (Technically, this is a bug; I first noticed it a week after copyin=
g a script from a PG 15 server to five PG 14 servers, and running it quite =
a few times without fail.)</div><br><div><font face=3D"monospace">$ pg_base=
backup \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --pgdata=3D$PGDA=
TA \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --dbname=3Dservice=
=3Dbasebackup \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --verbose=
 --progress \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --checkpoin=
t=3Dfast \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --write-recove=
ry-conf \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --wal-method=3D=
stream \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --create-slot --=
slot=3Dpgstandby1 \<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --com=
press=3Dserver-zst ; echo $?<br>pg_basebackup: initiating base backup, wait=
ing for checkpoint to complete<br>pg_basebackup: checkpoint completed<br>pg=
_basebackup: write-ahead log start point: 256/BC000028 on timeline 1<br>pg_=
basebackup: starting background WAL receiver<br>pg_basebackup: created repl=
ication slot &quot;pgstandby1&quot;<br>42567083/42567083 kB (100%), 1/1 tab=
lespace=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pg_basebackup: write-ahead lo=
g end point: 256/BC000138<br>pg_basebackup: waiting for background process =
to finish streaming ...<br>pg_basebackup: syncing data to disk ...<br>pg_ba=
sebackup: renaming backup_manifest.tmp to backup_manifest<br>pg_basebackup:=
 base backup completed<br>0</font><br></div><div><br></div></div>

--000000000000a25ab2061a4314d7--