public inbox for [email protected]
help / color / mirror / Atom feedFrom: Sebastien Flaesch <[email protected]>
To: Tom Lane <[email protected]>
Cc: Adrian Klaver <[email protected]>
Cc: M Tarkeshwar Rao <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
Date: Thu, 20 Mar 2025 15:42:39 +0000
Message-ID: <DBAP191MB12895511C8AF01672076F8E3B0D82@DBAP191MB1289.EURP191.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <[email protected]>
References: <PAWPR07MB1009569596278D85AC691BBF4AEDD2@PAWPR07MB10095.eurprd07.prod.outlook.com>
<[email protected]>
<DBAP191MB1289124F5D8690DF3F72F62CB0DC2@DBAP191MB1289.EURP191.PROD.OUTLOOK.COM>
<[email protected]>
<DBAP191MB1289C92E15014C2627C49BEBB0D92@DBAP191MB1289.EURP191.PROD.OUTLOOK.COM>
<[email protected]>
<[email protected]>
<DBAP191MB1289417EA192457D9663350EB0D82@DBAP191MB1289.EURP191.PROD.OUTLOOK.COM>
<[email protected]>
Tom,
They are. You were already pointed to it. The fact that you don't
like how that file's name is spelled is not really going to
impress anyone.
I don't care about the .h file name or location, what scares me is this:
/*
* Backwards compatibility for ancient random spellings of pg_type OID macros.
* Don't use these names in new code.
*/
#define CASHOID MONEYOID
#define LSNOID PG_LSNOID
#define BOOLOID 16
#define BYTEAOID 17
#define CHAROID 18
#define NAMEOID 19
#define INT8OID 20
#define INT2OID 21
#define INT2VECTOROID 22
#define INT4OID 23
#define REGPROCOID 24
If I am missing something, then please point me to the correct .h file that contains #define constants without this scary comment.
OR.... ( I guess I start to understand the code... ) it this comment only for:
#define CASHOID MONEYOID
#define LSNOID PG_LSNOID
???
And sorry if I consider constant names like these (without any prefix such as PG_TYPE_)
#define BOOLOID 16
#define BYTEAOID 17
#define CHAROID 18
#define NAMEOID 19
#define INT8OID 20
#define INT2OID 21
...
... are looking more like names not to be used!
Arrogance does not help here, clarity and better API doc would.
Seb
________________________________
From: Tom Lane <[email protected]>
Sent: Thursday, March 20, 2025 3:31 PM
To: Sebastien Flaesch <[email protected]>
Cc: Adrian Klaver <[email protected]>; M Tarkeshwar Rao <[email protected]>; [email protected] <[email protected]>
Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
EXTERNAL: Do not click links or open attachments if you do not recognize the sender.
Sebastien Flaesch <[email protected]> writes:
> Native PostgreSQL built-in SQL types should be listed in a .h header of the C client API
They are. You were already pointed to it. The fact that you don't
like how that file's name is spelled is not really going to
impress anyone.
regards, tom lane
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
In-Reply-To: <DBAP191MB12895511C8AF01672076F8E3B0D82@DBAP191MB1289.EURP191.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox