Date: Wed, 20 Jan 2021 11:56:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andrus <kobruleht2@hot.ee>, pgsql-general@postgresql.org
Subject: Re: Error messages on duplicate schema names
Message-ID: <YAebw/WH0t6YCd8S@paquier.xyz>
References: <YAEZ6D+R5tSGk08i@paquier.xyz>
 <20210119203751.GA5473@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jtN5YEHWOJTQclLR"
Content-Disposition: inline
In-Reply-To: <20210119203751.GA5473@alvherre.pgsql>
Precedence: bulk


--jtN5YEHWOJTQclLR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 19, 2021 at 05:37:51PM -0300, Alvaro Herrera wrote:
> I guess you could make the case that the CCI call should be in the
> callers where we actually loop (SetDefaultACLsInSchemas,
> RemoveRoleFromObjectACL), but it's hard to get excited about the added
> clutter.

Yeah, that matches my thoughts.  And I did not see any harm in putting
the CCI in SetDefaultACL() even for the case of pg_default_acl with
DROP OWNED BY.  So applied and backpatched.  Thanks, Alvaro and
Andrus.
--
Michael

--jtN5YEHWOJTQclLR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmAHm8MACgkQnvQgOdby
QH1AYA/9HBTdKdJaXIiTy63i7gDtd5VwlU/uAb6sAgxNzlM1s9/Rc7XzM1OoqD1g
eZJlvZHn2kzCjuN0Krb8tHOkZ0UAKl+DzwM12N1QVBoigDCHTIMsNJyoXbM0wm6s
9jJL7pAVZxC0Oxouq4az0i84DF3QmQ6Asf/Zf+opl/nE7G1jvOyHT921XnLsMPuA
OlRgZKMOuBCVRcG93RSl50Iz3j/Bq6vv5QIfwget7y/npp7QdjwAURNAWEmHc0D+
tlC0xsw/0wFaNZhYFHbKMMbL96DKge+qDr+IMCEMcgkKh3+ghzHnmtRxAEWIG+7j
XP6bV/K4vKtUl8VJhCzWVTjXheyXncartAaNcRKhqRh8msDljkzOAVcJERLFqe5u
CzLe6m8//FBB0/Qn97eXVAfinmnlXjoRm5D5CD1oOrjc6AIai/p/kRdgeUQ5TU73
vO8MieiOBUztT5gKquZFgv+/SP077QrmR4xoQ13/yDg23TqPAB+1jvzvpLhU0SDk
V/DhcttIR/mchaLTyImpNoVObJsOc9hDZorE3jOXgVEvCQSW3AZ/c+l0qIQ7+ga2
KKk1oiVs5meSSw03vAILWKAdkn9Nqql8pc3dpOMNy+mXdOAmfZM1ypYKKswSkaOL
uSucQChWHAIrWuVWNPTpf4sIyoTFgXIJWZ4d11ai2H80XcrOjr0=
=vtZm
-----END PGP SIGNATURE-----

--jtN5YEHWOJTQclLR--