Date: Mon, 24 Mar 2025 16:41:35 +0100
From: Christoph Berg <myon@debian.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z-F9L8nGd72E8d2G@msg.df7cb.de>
References: <Z9y43-dRvb4EtxQ0@paquier.xyz>
 <Z92TLJ5MmSU_lyxa@msg.df7cb.de>
 <Z93sH12uzCQHfOo-@paquier.xyz>
 <Z96GJEmTnvHKz_Kn@msg.df7cb.de>
 <Z96Rz-4IEyRCS4ny@paquier.xyz>
 <1831838.1742656359@sss.pgh.pa.us>
 <80506.1742660683@sss.pgh.pa.us>
 <Z99aIy9T0f-lulK5@paquier.xyz>
 <461405.1742691859@sss.pgh.pa.us>
 <Z9-sUvq8pE5uinEu@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z9-sUvq8pE5uinEu@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Z-F9L8nGd72E8d2G%40msg.df7cb.de>
Precedence: bulk

Re: Michael Paquier
> So your idea to use the relation name in eref while skipping the
> column list looks kind of promising.  Per se the attached.  Thoughts?

Makes sense to me, thanks for digging into it.

> +++ b/src/backend/nodes/queryjumblefuncs.c
> @@ -33,6 +33,7 @@
>  #include "postgres.h"
>  
>  #include "access/transam.h"
> +#include "catalog/namespace.h"

No longer needed.

> +++ b/contrib/pg_stat_statements/sql/select.sql
> +SET search_path = 'pgss_schema_1';
> +SELECT count(*) FROM tab_search_same;
> +SELECT a, b FROM tab_search_same;
> +SELECT count(*) FROM tab_search_diff_1;
> +SELECT count(*) FROM tab_search_diff_2;
> +SELECT a FROM tab_search_diff_2;
> +SET search_path = 'pgss_schema_1';

Should this be pgss_schema_2 ?

Christoph