Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 25 Mar 2025 12:47:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <myon@debian.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z-InR3Qs3KqKXCcz@paquier.xyz>
References: <Z92TLJ5MmSU_lyxa@msg.df7cb.de>
 <Z93sH12uzCQHfOo-@paquier.xyz>
 <Z96GJEmTnvHKz_Kn@msg.df7cb.de>
 <Z96Rz-4IEyRCS4ny@paquier.xyz>
 <1831838.1742656359@sss.pgh.pa.us>
 <80506.1742660683@sss.pgh.pa.us>
 <Z99aIy9T0f-lulK5@paquier.xyz>
 <461405.1742691859@sss.pgh.pa.us>
 <Z9-sUvq8pE5uinEu@paquier.xyz>
 <Z-F9L8nGd72E8d2G@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gES5a/B0hjjUPmBa"
Content-Disposition: inline
In-Reply-To: <Z-F9L8nGd72E8d2G@msg.df7cb.de>
Archived-At: <https://www.postgresql.org/message-id/Z-InR3Qs3KqKXCcz%40paquier.xyz>
Precedence: bulk


--gES5a/B0hjjUPmBa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 24, 2025 at 04:41:35PM +0100, Christoph Berg wrote:
> Re: Michael Paquier
>> +++ b/src/backend/nodes/queryjumblefuncs.c
>> @@ -33,6 +33,7 @@
>>  #include "postgres.h"
>> =20
>>  #include "access/transam.h"
>> +#include "catalog/namespace.h"
>=20
> No longer needed.

Indeed.

>> +++ b/contrib/pg_stat_statements/sql/select.sql
>> +SET search_path =3D 'pgss_schema_1';
>> +SELECT count(*) FROM tab_search_same;
>> +SELECT a, b FROM tab_search_same;
>> +SELECT count(*) FROM tab_search_diff_1;
>> +SELECT count(*) FROM tab_search_diff_2;
>> +SELECT a FROM tab_search_diff_2;
>> +SET search_path =3D 'pgss_schema_1';
>=20
> Should this be pgss_schema_2 ?

Oops.  Nice copy-paste.
--
Michael

--gES5a/B0hjjUPmBa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfiJ0cACgkQnvQgOdby
QH103BAAlYsSaCX55DVTSCn4cyBswwvRTPF3ik6OlhqDsgxcIo2/p940UbFItOqq
LpFSfzTL+01P78NkKXSwcporQNq5FU3yShgJUQoBtD8kEhfcUZj5WZLiasq3BQW6
pFab4nDIVN8dlhIQpIzRqgSWR0vqO8RsuXrSpHUbGvBi22gXr33MU2MI7KgDsooQ
+ECk5vvMXydNzBsS5kPWJCpInFv1MS7K2aYCymhcSh7dVtQ4AZu0XOYvrhVht0KD
nqoV++QtP4HqMUX0j7VGCTpO4aHz68Y+SRdXG7DNaEhE6M88lKvzDgXMrrKkDFO6
6Iq8arR9aB6ENB3DCfRKrmqTFE++H5LYPnEdSlvkogXYCVjyHB+T66UNxKx3Ppch
kw3Q0aMlafvoKsX94yb4Bqnq2m95W3Bp1Re4EjaKK0NyGiMZTcP11NQecEciJN6Y
gxw7LYT/Bda6b+6+cbrhuqjTTPI4blWAeM3KJP3qyv6SubPtiEJq0o4nafXnV0V/
amOAO0iTnp4VlgWjrE5QmoQx4SrPS5VcBeVj7i76WNoPtkAK+ky7YSTk/yeDMAeL
Q+3Ur9lfTLtg7rzoz55DzzrfruW9saiR7yl1lIm5kK5g/+lloiyBdiGvGY09549G
QSsuqNJacjKN5MXpokykIAH5J3ewaOZiiKLeyGD7yHJNkaKSlOs=
=qAB5
-----END PGP SIGNATURE-----

--gES5a/B0hjjUPmBa--