Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 26 Mar 2025 15:24:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Christoph Berg <myon@debian.org>,
	Lukas Fittl <lukas@fittl.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z-OdsRQUmwtSa_4l@paquier.xyz>
References: <Z-NLelZdH3GaLRNK@paquier.xyz>
 <70BA294B-5A33-4F47-A637-8011C1F279CB@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ai5/8qrZsKwpePf2"
Content-Disposition: inline
In-Reply-To: <70BA294B-5A33-4F47-A637-8011C1F279CB@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z-OdsRQUmwtSa_4l%40paquier.xyz>
Precedence: bulk


--ai5/8qrZsKwpePf2
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 25, 2025 at 07:56:29PM -0500, Sami Imseih wrote:
> FWIW, the pg_stat_statements docs in a few places refer to=20
> queries that may look different but have the same meaning=20
> as =E2=80=9Csemantically equivalent=E2=80=9D, this is why I used the same=
=20
> terminology here.  But, I have no issue with the simplified
> rewrite either.
>=20
> The patch LGTM as well.=20

If any adjustments are required, it would be always possible to do
these later.  Anyway, workloads with a lot of temporary tables are
going to benefit from this change, so let's see how it goes.

Applied, after eyeing much more the PGSS dumps from installcheck
before and after the patch, to make sure that I'm not missing
something..
--
Michael

--ai5/8qrZsKwpePf2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfjnbEACgkQnvQgOdby
QH33xg/+NNWYuJUq30cg4mKZSc7+TEJfO4xAS45jC1KBLFl4HltMcQucPuR+yeTi
QlEr6Np36u9HNU6ZPrm13vcufsUCwCVuU8nwQ1LtBlRmWSH3NQhzm2adtZrYoMI7
JwnVIKXV7NmOTzWJIkOGI7+eQsVenfg8sn9sIE0ufSdoM1Aii6MY+wIn4E5Niyet
EKRUXax/B1Zb2bLCO2CCwO+nbuPyI1Q6TnFapDx+iRG7sGIm3SfP3DBW7w0L+8GS
wGy4J52+9onIFc+STPL2PTnQzYJo+dqt4o5LQsljLseAU6uqSukTPOjLQSIQPfPB
w8W1Y9hedkdNkChXqnlEYpCMUyGt8hO5JbaefjD9yyM/uOAAp7qII/snEAEuhDwr
nJrxjuN3dsu6q8tMCvaz6sf71eVcAcrSBRMBqAaCCL4QtzxNXk5yf+KXm56tZE6z
6DPw3UWv2JVtyF6+aqotoh6wfnZdxtx/YegCm/16hsTUGnRMBGiXP301L14CA3un
P/0xljrJk/+0IxCuY2UUxWZ5HEblSYryND7tLPvlgJxCTiZMSortbup8XzXYUbHh
Fw0oINCE+oyraXn+Wbnzpq/6tEUhtOo4XK4KwYV0uPCjm80whgc9286chUu41icn
jxV13cckBwIo7rLjs+JimnnLkcYejYoYrE1rk8H13u3F2s5phAY=
=92VT
-----END PGP SIGNATURE-----

--ai5/8qrZsKwpePf2--