Date: Fri, 21 Mar 2025 17:26:20 +0100
From: Christoph Berg <myon@debian.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z92TLJ5MmSU_lyxa@msg.df7cb.de>
References: <OSZP286MB2253413D25A5D93BEA4F6459F2432@OSZP286MB2253.JPNP286.PROD.OUTLOOK.COM>
 <ZbtabEYMaZ3-wcxv@paquier.xyz>
 <Z9iWXKGwkm8RAC93@msg.df7cb.de>
 <Z9ju-lB4r6fXcIKS@paquier.xyz>
 <Z9mkqplmUpQ4xG52@msg.df7cb.de>
 <Z9n_K2YGbadpzD_s@paquier.xyz>
 <Z9qybg3FxTUefRT7@msg.df7cb.de>
 <Z9y43-dRvb4EtxQ0@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z9y43-dRvb4EtxQ0@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Z92TLJ5MmSU_lyxa%40msg.df7cb.de>
Precedence: bulk

Re: Michael Paquier
> I have been thinking about this patch for a couple of days.  What
> makes me unhappy in this proposal is that RangeTblEntry is a large and
> complicated Node, and we only want to force a custom computation for
> the "relid" portion of the node, while being able to also take some
> decisions for what the parent node has.  Leaving the existing
> per-field query_jumble_ignore with the custom function is prone to
> errors, as well, because we need to maintain some level of consistency
> between parsenodes.h and src/backend/nodes/.

Ack, that was also bothering me, but I didn't think it was so easy to
do it on a per-field level. Thanks!

> The custom functions are named _jumble${node}_${field}, with the field
> and the parent node given as arguments.  I agree that giving the field
> is kind of pointless if you have the parent node, but I think that
> this is better so as this forces developers to think about how to use
> the field value with the node.

Makes sense.

> Please see the attached.  What do you think?

Just one minor thing, I don't understand what you are trying to say in
this comment:

> +/*
> + * Note that the argument types are enforced for the per-field custom
> + * functions.
> + */
> +#define JUMBLE_CUSTOM(nodetype, item) \
> +	_jumble##nodetype##_##item(jstate, expr, expr->item)

Thanks,
Christoph