Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 22 Mar 2025 07:45:51 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z93sH12uzCQHfOo-@paquier.xyz>
References: <OSZP286MB2253413D25A5D93BEA4F6459F2432@OSZP286MB2253.JPNP286.PROD.OUTLOOK.COM>
 <ZbtabEYMaZ3-wcxv@paquier.xyz>
 <Z9iWXKGwkm8RAC93@msg.df7cb.de>
 <Z9ju-lB4r6fXcIKS@paquier.xyz>
 <Z9mkqplmUpQ4xG52@msg.df7cb.de>
 <Z9n_K2YGbadpzD_s@paquier.xyz>
 <Z9qybg3FxTUefRT7@msg.df7cb.de>
 <Z9y43-dRvb4EtxQ0@paquier.xyz>
 <Z92TLJ5MmSU_lyxa@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Ljs0EdCK+uTTqemp"
Content-Disposition: inline
In-Reply-To: <Z92TLJ5MmSU_lyxa@msg.df7cb.de>
Archived-At: <https://www.postgresql.org/message-id/Z93sH12uzCQHfOo-%40paquier.xyz>
Precedence: bulk


--Ljs0EdCK+uTTqemp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 21, 2025 at 05:26:20PM +0100, Christoph Berg wrote:
> Just one minor thing, I don't understand what you are trying to say in
> this comment:
>=20
>> +/*
>> + * Note that the argument types are enforced for the per-field custom
>> + * functions.
>> + */
>> +#define JUMBLE_CUSTOM(nodetype, item) \
>> +	_jumble##nodetype##_##item(jstate, expr, expr->item)

In this one, I want to mean that we require a custom per-field
function to look like that:
_jumbleNodefoo_field(JumbleState *jstate, NodeFoo *expr, FieldType field);

Rather than having more generic shape like that:
_jumbleNodefoo_field(JumbleState *jstate, Node *exp,
                     const unsigned char *item, Size size);

So a custom function is defined so as the node type and field type are
arguments.  Perhaps this comment would be better if reworded like
that:
"The arguments of this function use the node type and the field type,
rather than a generic argument like AppendJumble() and the other
_jumble() functions."

If you have a better idea, please feel free..
--
Michael

--Ljs0EdCK+uTTqemp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfd7B8ACgkQnvQgOdby
QH37wQ/+L8MMpAJqkUPL7ZyRImJmpxzF6YkZPJu18QA5twLlkaaozaBeV9ISXh46
tDs4P4YoSUPtQ+a9d7AiIJ+/tkIzSym/s9h2dDkd7o2qHgqM9nCkI1Mq/jbpBAFn
QH3qGiY8br+6uTLF1ueKgJNdOGbUWAL4S2UQdIqRSXWjT3/3kGD6szp3hZ1QIjKS
qYWPOLoetlW4UiSdr75OKIPA35b7Rq5wE4Gh9eWiHD/QdOq//1wPGynymxou1nkD
uwXSDxeFUdJf6hWs0xOfZI67EXWKkkSLdPV3UbCIlDjamwP93E1yepRQAUm56o5l
ZaL7oVPXmaDPrCYk/kaO/b46gbn/jnf9NyqStyIynX/xC3nTdG7Eu3ysfY9b1uLU
/tGS5uWlyISuqrhxIfDb/zVeDYo46lmAFgwHLx6s4rbFiIBFapztMAWr+hR6fFyn
F5S78L+J44e8SXXoN5RlKMZXgjLoLeYp2l5eirTI+81EUy+hooEi0EmO21bLG6YF
3N+RWaHkut5zrlGHBsxGpwfAc3X94wKTzOhpTAgJxWzJhs8uC5hCbF62j8tCr6LI
ENGWzfZwGC3GiO6fUEGni4xLgdRuhqHQMVBYS06U3i3xVN06JnDiWOLj7VvFJg81
XkVYBANXheU0z9tKf0Chj6f9hPTTl/1rKwSqqBva/sbR4lRHYoQ=
=9cG1
-----END PGP SIGNATURE-----

--Ljs0EdCK+uTTqemp--