Date: Sat, 22 Mar 2025 10:43:00 +0100
From: Christoph Berg <myon@debian.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z96GJEmTnvHKz_Kn@msg.df7cb.de>
References: <OSZP286MB2253413D25A5D93BEA4F6459F2432@OSZP286MB2253.JPNP286.PROD.OUTLOOK.COM>
 <ZbtabEYMaZ3-wcxv@paquier.xyz>
 <Z9iWXKGwkm8RAC93@msg.df7cb.de>
 <Z9ju-lB4r6fXcIKS@paquier.xyz>
 <Z9mkqplmUpQ4xG52@msg.df7cb.de>
 <Z9n_K2YGbadpzD_s@paquier.xyz>
 <Z9qybg3FxTUefRT7@msg.df7cb.de>
 <Z9y43-dRvb4EtxQ0@paquier.xyz>
 <Z92TLJ5MmSU_lyxa@msg.df7cb.de>
 <Z93sH12uzCQHfOo-@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z93sH12uzCQHfOo-@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Z96GJEmTnvHKz_Kn%40msg.df7cb.de>
Precedence: bulk

Re: Michael Paquier
> >> + * Note that the argument types are enforced for the per-field custom
> >> + * functions.
> >> + */
> >> +#define JUMBLE_CUSTOM(nodetype, item) \
> >> +	_jumble##nodetype##_##item(jstate, expr, expr->item)
> 
> In this one, I want to mean that we require a custom per-field
> function to look like that:
> _jumbleNodefoo_field(JumbleState *jstate, NodeFoo *expr, FieldType field);
> 
> Rather than having more generic shape like that:
> _jumbleNodefoo_field(JumbleState *jstate, Node *exp,
>                      const unsigned char *item, Size size);
> 
> So a custom function is defined so as the node type and field type are
> arguments.  Perhaps this comment would be better if reworded like
> that:
> "The arguments of this function use the node type and the field type,
> rather than a generic argument like AppendJumble() and the other
> _jumble() functions."

Perhaps this:

/*
 * The per-field custom jumble functions get jstate, the node, and the
 * field as arguments.
 */

They are not actually different from _jumbleList and _jumbleA_Const
which also get the node (and just not the field). AppendJumble is a
different layer, the output, so it's not surprising its signature is
different.

Are we at the point where the patch is already Ready for Committer?

Thanks,
Christoph