Date: Sat, 22 Mar 2025 11:12:58 +0100
From: Christoph Berg <myon@debian.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z96NKlt-uNnICyhs@msg.df7cb.de>
References: <ZbtabEYMaZ3-wcxv@paquier.xyz>
 <Z9iWXKGwkm8RAC93@msg.df7cb.de>
 <Z9ju-lB4r6fXcIKS@paquier.xyz>
 <Z9mkqplmUpQ4xG52@msg.df7cb.de>
 <Z9n_K2YGbadpzD_s@paquier.xyz>
 <Z9qybg3FxTUefRT7@msg.df7cb.de>
 <Z9y43-dRvb4EtxQ0@paquier.xyz>
 <Z92TLJ5MmSU_lyxa@msg.df7cb.de>
 <Z93sH12uzCQHfOo-@paquier.xyz>
 <Z96GJEmTnvHKz_Kn@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z96GJEmTnvHKz_Kn@msg.df7cb.de>
Archived-At: <https://www.postgresql.org/message-id/Z96NKlt-uNnICyhs%40msg.df7cb.de>
Precedence: bulk

Re: To Michael Paquier
> > >> +#define JUMBLE_CUSTOM(nodetype, item) \
> > >> +	_jumble##nodetype##_##item(jstate, expr, expr->item)
> > 
> > In this one, I want to mean that we require a custom per-field
> > function to look like that:
> > _jumbleNodefoo_field(JumbleState *jstate, NodeFoo *expr, FieldType field);
> 
> Perhaps this:

Or actually more explicit:

/*
 * Per-field custom jumble functions have this signature:
 * _jumbleNodefoo_field(JumbleState *jstate, NodeFoo *expr, FieldType field);
 */

Christoph