Date: Mon, 17 Mar 2025 10:14:51 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Treat <rob@xzilla.net>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
	Gurjeet Singh <gurjeet@singh.im>,
	Andres Freund <andres@anarazel.de>,
	Will Storey <will@summercat.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Postgres Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Disabling vacuum truncate for autovacuum
Message-ID: <Z9g8a4HGLUcSo96v@nathan>
References: <f82fc7fbb69a8c8000ad74ced50381257fe57838.camel@cybertec.at>
 <CA+TgmoZMXN19eorKdeiiFCv3AJFVaUAfkzRuamnt8A9U8uJSqg@mail.gmail.com>
 <Z7Tl2d7HrG1AQEOc@nathan>
 <CABwTF4XPc1_y=khhjErd=Oz8R20ZH05KigiAnMjjA+028QbohQ@mail.gmail.com>
 <Z8H-tHaYZ37lVZHb@nathan>
 <28773a66-fb88-41cf-a7ec-4216e6c91c94@oss.nttdata.com>
 <Z9ROT9v4rHjDYWNX@nathan>
 <CABwTF4WFp-oNSm6utik6g-1HZBxijTJBcuX7BKD8MYqza+KMnw@mail.gmail.com>
 <6f2f2167f4be09e6ca9251c8f69dfe01809d68be.camel@cybertec.at>
 <CABV9wwNagobmRMCxs0dKqWmKXaQTUQj+oOOTw=fsPAgbBfVhew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="RNDgGzXBgkhvU3Qa"
Content-Disposition: inline
In-Reply-To: 
 <CABV9wwNagobmRMCxs0dKqWmKXaQTUQj+oOOTw=fsPAgbBfVhew@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Z9g8a4HGLUcSo96v%40nathan>
Precedence: bulk


--RNDgGzXBgkhvU3Qa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Mar 16, 2025 at 06:24:59PM -0400, Robert Treat wrote:
> So if the general idea is a guc "vacuum_truncate" which sets a global
> default for whether vacuums and autovacuums should do truncation, and
> we then have the storage parameter which would override the global
> setting. And to be clear, there is also the decision on whether the
> VACUUM commands default should default to truncate=on (like the
> existing behavior) or truncate == vacuum_truncate guc, unless
> explicitly set. I think the latter is probably the right way to go.

Thank you all for the discussion.  I've attempted to address the
outstanding feedback into the new version of the patch.

-- 
nathan

--RNDgGzXBgkhvU3Qa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v4-0001-Add-vacuum_truncate-configuration-parameter.patch"