Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 18 Mar 2025 12:56:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: support fix query_id for temp table
Message-ID: <Z9ju-lB4r6fXcIKS@paquier.xyz>
References: <OSZP286MB2253413D25A5D93BEA4F6459F2432@OSZP286MB2253.JPNP286.PROD.OUTLOOK.COM>
 <ZbtabEYMaZ3-wcxv@paquier.xyz>
 <Z9iWXKGwkm8RAC93@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mnrdN0pU3KuSQi1X"
Content-Disposition: inline
In-Reply-To: <Z9iWXKGwkm8RAC93@msg.df7cb.de>
Archived-At: <https://www.postgresql.org/message-id/Z9ju-lB4r6fXcIKS%40paquier.xyz>
Precedence: bulk


--mnrdN0pU3KuSQi1X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 17, 2025 at 10:38:36PM +0100, Christoph Berg wrote:
> Here's that patch with regression tests added. I would think changing
> this would be a big usability improvement for anyone using temp tables
> a lot.

Not the first time I am seeing this argument this month.  It is the
second time.

+    /*
+     * If this is a temp table, jumble the name instead of the table oid.
+     */
+    if (expr->rtekind == RTE_RELATION && isAnyTempNamespace(get_rel_namespace(expr->relid)))
+    {
+        rel_name = get_rel_name(expr->relid);
+        AppendJumble(jstate, (const unsigned char *)rel_name, strlen(rel_name));
+    }
+    else
+        JUMBLE_FIELD(relid);

This is OK on its own, still feels a bit incomplete, as the relid also
includes an assumption about the namespace.  I would suggested to add
a hardcoded "pg_temp" here, to keep track of this assumption, at
least.

 typedef struct RangeTblEntry
 {
-    pg_node_attr(custom_read_write)
+    pg_node_attr(custom_read_write, custom_query_jumble)

This structure still includes some query_jumble_ignore, which are not
required once custom_query_jumble is added.

We had better document at the top of RangeTblEntry why we are using a
custom function.
--
Michael

--mnrdN0pU3KuSQi1X
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfY7voACgkQnvQgOdby
QH1ihg/9GuC3F49Ot7RDytPn54dyu+OQoj7PQihTkyYePaVaCDQW0P8g0K4Tp3eJ
lmYFwIH6/1BWmo7nzva22qLS7e2LZ1sn706VbBF3j3kdCIAk/nepLCUSGRH1ji6t
NgZUv6KgZtU4Li8gAV983M5wjV4RpPg1B0J1X+j69wd+OnkZfonF0B+o7o7a71Cj
4qvzPFflDYb+ykEy5zmre5Dio4Zrr3vnyYgXwFQyCCNlAPs1CHlnN2jhXnknGp6a
YomudU7GgEYM+9oy15BegwuK1ikqxhUfAV7jITtiEux1NKGWVRoQc6O5FWzBtVMy
2b2uYDYRAmH2Svyl7T4PVAV9mN/IiN5cLKU6+Ahg4v1amJAhO5FURrnZ/4Mz6rVt
DqvwmF88Kg4Wv3WE/26BPW82Xq/NH9q1XLnQyQjFLNZ9x+ENCfKcFJjhTJpaqGCi
0JaPTL19DQ95C5XbLY8BekKugY4Fch/zy0MFjIiBVAl16Gpuxd+fBreDPBt3SbNP
/daKXF53R5mzxlrebGWlJX7dEHHoB46v7w+XnuXqvjC4SguU8ZSOobvuaSmm6Kgr
qanjiaqByBh/6ThyGcLz6b0u7Yu6JuE4ZCOaZTtpAbzF1kH+qbO7f9K0+C1AAowF
AYvMDdWitj+7aJeAi8JNqdOUKt7g9/vEgvdMQBMpGboOE47bjIs=
=ykf/
-----END PGP SIGNATURE-----

--mnrdN0pU3KuSQi1X--