Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 19 Mar 2025 08:18:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better
 pg_stat_statement UX
Message-ID: <Z9n_K2YGbadpzD_s@paquier.xyz>
References: <OSZP286MB2253413D25A5D93BEA4F6459F2432@OSZP286MB2253.JPNP286.PROD.OUTLOOK.COM>
 <ZbtabEYMaZ3-wcxv@paquier.xyz>
 <Z9iWXKGwkm8RAC93@msg.df7cb.de>
 <Z9ju-lB4r6fXcIKS@paquier.xyz>
 <Z9mkqplmUpQ4xG52@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Urqtcu/JHaU7viIj"
Content-Disposition: inline
In-Reply-To: <Z9mkqplmUpQ4xG52@msg.df7cb.de>
Archived-At: <https://www.postgresql.org/message-id/Z9n_K2YGbadpzD_s%40paquier.xyz>
Precedence: bulk


--Urqtcu/JHaU7viIj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 18, 2025 at 05:51:54PM +0100, Christoph Berg wrote:
> I had thought about it, but figured that integers and strings are
> already separate namespaces, so hashing them shouldn't have any
> conflicts. But it's more clear to do that, so added in the new
> version:
>=20
>        AppendJumble(jstate, (const unsigned char *)"pg_temp", sizeof("pg_=
temp"));
>        AppendJumble(jstate, (const unsigned char *)rel_name, strlen(rel_n=
ame));

Yes, I know that it's not a big deal, but it could be confusing if
somebody makes an argument about jumbling more object names for
relations.  The problem is not only limited to relations, though, as
there are other object types that can use a temp namespace like
functions, but the case of table entries should cover most of the
complaints I can imagine.

> >  typedef struct RangeTblEntry
> >  {
> > -    pg_node_attr(custom_read_write)
> > +    pg_node_attr(custom_read_write, custom_query_jumble)
> >=20
> > This structure still includes some query_jumble_ignore, which are not
> > required once custom_query_jumble is added.
>=20
> I would tend to keep them for documentation purposes. (The other
> custom_query_jumble functions have a much more explicit structure so
> there it is clear which fields are supposed to be jumbled.)

Fine by me as well to keep a dependency based on the fact that the
structure is rather complicated, but I'd rather document that as well
in parsenodes.h with a slightly fatter comment.  What do you think?
--
Michael

--Urqtcu/JHaU7viIj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmfZ/ysACgkQnvQgOdby
QH3L8w/+Np5Z65FlxU8zDxl85XsQbW1bOqiHN47WqUiVt8wpQI7CKm+uuwrH1WEj
96wEeWEMgytbXIeSevFB0WpFHxw+EJeAJbfE2i6NPDqcWnaYZ6vDefCIrwVHqA1W
D8y2p7LdJSK57AtfLx8ymEgrD74ZTGLghii8eQtiHGiTCkQz2sTuweyz0YLmN+nt
f30mrmxwtWLKd7Ndww957miAYapkeuSZ4/sKxkUwnokaUsGPV4e79QqxeNCadeKA
di79YCTaQvjKoLoJ0zlvbwbMWVlhntHx51x5eBO9oLba8MB/ko442F5t43jexSgH
JqhG+YYRo9+MypatYa86ovr+jcAwb3K0e3gQgJwxnIYEagwHsjf7AdYitTLzl9gO
JutA56XwvY16+c8p2WgewxJ/n1YhWFZ3bsnppHD3xd6O2eXIzHu58PI53gKXHMHx
LOguyoSCT4Kun1K4pubgAZE4jWVdDbHLQGwGc50ra9SlNmu4i01Ib8Z0r6r4qwcQ
PME/XUde4+LmgtbZEil3H6Q4ZtaydZ9b60DFM06oR/AK+0yu5qnNiTkByR0hNet5
aocVyBgp4Qj+ay7pZ4TdQ3L3uf07I+psAzm2Rqk2TFEcQstiCT8XlG7oTpuC8/nP
VheQDLnt+wZGH8DLq/2XwXhlu0W9vdJQ3X9LBvtU+EytYqAFaaw=
=VRjn
-----END PGP SIGNATURE-----

--Urqtcu/JHaU7viIj--