Date: Wed, 19 Mar 2025 11:09:21 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Robert Treat <rob@xzilla.net>, Laurenz Albe <laurenz.albe@cybertec.at>,
	Gurjeet Singh <gurjeet@singh.im>,
	Andres Freund <andres@anarazel.de>,
	Will Storey <will@summercat.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Postgres Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Disabling vacuum truncate for autovacuum
Message-ID: <Z9rsMX5ZOL5E0cQy@nathan>
References: <Z8H-tHaYZ37lVZHb@nathan>
 <28773a66-fb88-41cf-a7ec-4216e6c91c94@oss.nttdata.com>
 <Z9ROT9v4rHjDYWNX@nathan>
 <CABwTF4WFp-oNSm6utik6g-1HZBxijTJBcuX7BKD8MYqza+KMnw@mail.gmail.com>
 <6f2f2167f4be09e6ca9251c8f69dfe01809d68be.camel@cybertec.at>
 <CABV9wwNagobmRMCxs0dKqWmKXaQTUQj+oOOTw=fsPAgbBfVhew@mail.gmail.com>
 <Z9g8a4HGLUcSo96v@nathan>
 <Z9ohFZtDaZnkch7u@nathan>
 <88e3b55a-8ef8-4b53-8d71-6bfde1a07bc1@oss.nttdata.com>
 <Z9rlb0jgNLm8ULAB@nathan>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="QCdigXRwPRi3PRaS"
Content-Disposition: inline
In-Reply-To: <Z9rlb0jgNLm8ULAB@nathan>
Archived-At: <https://www.postgresql.org/message-id/Z9rsMX5ZOL5E0cQy%40nathan>
Precedence: bulk


--QCdigXRwPRi3PRaS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 19, 2025 at 10:40:31AM -0500, Nathan Bossart wrote:
> On Thu, Mar 20, 2025 at 12:34:59AM +0900, Fujii Masao wrote:
>> +# - Default Behavior -
>> +
>> +#vacuum_truncate = on			# enable truncation after vacuum
>> 
>> Since there's no existing GUC category that fits to vacuum_truncate,
>> I'm fine with adding a new category like "Vacuuming" and placing
>> vacuum_truncate there.
>> 
>> However, if we do this, ISTM that the new category should also be added to
>> guc_tables.h, and vacuum_truncate should be assigned to it in guc_tables.c.
>> Additionally, the documentation should be updated to include
>> the new category, with vacuum_truncate placed under it. Thought?
> 
> Ah, you're right, I need to fix the category.  Will post an updated patch
> soon.

Here's a new version of the patch with the GUC placed in a new "Default
Behavior" category for vacuum-related parameters.

-- 
nathan

--QCdigXRwPRi3PRaS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v6-0001-Add-vacuum_truncate-configuration-parameter.patch"