Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pznRi-0006RQ-Ra for pgsql-hackers@arkaria.postgresql.org; Thu, 18 May 2023 23:54:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pznRh-0000KS-9R for pgsql-hackers@arkaria.postgresql.org; Thu, 18 May 2023 23:54:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pznRg-0000KI-VW for pgsql-hackers@lists.postgresql.org; Thu, 18 May 2023 23:54:08 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pznRb-000Zjj-H7 for pgsql-hackers@lists.postgresql.org; Thu, 18 May 2023 23:54:07 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 9ABBB5F7B7; Thu, 18 May 2023 19:53:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=snowman.net; s=dkim; t=1684454038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+fQuUxZm5GV4s7P9ZrXoxCYmnCa/pF6S7uPMi7vQ/jc=; b=YC6TwYy2nKvBy9bLN1T2zsJYvLQiPS4/MrToy4W0nqhqpoOd2x6vH5IZW+doa/x1fL1qFD qe9cktA1tEv5oVkV8ITmYLtCDHRHSYC3fHotfiypg0SYV/EPAXSH2mbxDbAIR0ZSfAwkuY rd0n5uLgeRNwBbYRpoq99EfM6PCtSrc= Date: Thu, 18 May 2023 19:53:58 -0400 From: Stephen Frost To: Kirk Wolak Cc: Jeremy Smith , PostgreSQL Hackers , Ron Subject: Re: Adding SHOW CREATE TABLE Message-ID: References: <1565715.1683923271@sss.pgh.pa.us> <1aac01a1-d9db-8048-9bfa-1e4f9bb69a03@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="G0CpAOFVD9g/MuXw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --G0CpAOFVD9g/MuXw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Kirk Wolak (wolakk@gmail.com) wrote: > My approach for now is to develop this as the \st command. > After reviewing the code/output from the 3 sources (psql, fdw, and > pg_dump). This trivializes the approach, > and requires the smallest set of changes (psql is already close with > existing queries, etc). >=20 > And frankly, I would rather have an \st feature that handles 99% of the u= se > cases then go 15yrs waiting for a perfect solution. > Once this works well for the group. Then, IMO, that would be the time to > discuss moving it. Having this only available via psql seems like the least desirable option as then it wouldn't be available to any other callers.. Having it in libpq, on the other hand, would make it available to psql as well as any other utility, library, or language / driver which uses libpq, including pg_dump.. Using libpq would also make sense from the perspective that libpq can be used to connect to a number of different major versions of PG and this could work work for them all in much the way that pg_dump does. The downside with this apporach is that drivers which don't use libpq (eg: JDBC) would have to re-implement this if they wanted to keep feature parity with libpq.. Thanks, Stephen --G0CpAOFVD9g/MuXw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmRmupYACgkQ7WyKOINH ZFVbdRAAoGKw4AuCDYX+WQUASD0r9bIIJw9erRjJx2TjhWkzNRlaz6p/+3lQwAAX UfB4TZT3NnADVrZsGZM2iag8Qf5mgq7a9mQXfKFoRZPJUGh9e/DdIPILr9QZ193s gB492auJsA+FnVMnii33rJRAakhl4diu8yYVU3dpdnfOWzwScX+KzJljR0mcjAdz U0lhW4MKHsdR2jK93seMTpasUBH1rvCB202wRL5U0plxN9K5E+gG/6qnS8nFyC3f I7dssryFkfFgfTa0SJKfdOtqgwojxZSysa8jHHeOrCIp+glAvLh0trY4+/N62ZpO BYpYUAqdnB6jET+Eeg8vQLmxPSSbAYGikQpnGnm8QF3dDEF/qfaEIkg4GjsmLy+c X/NtowGG6ZPlmWat2wLX/cJ3M/X4sjmoCVvM7DnOAZtCwjAEsNO19ioZ1cRPrElQ R2cS//hE14137l6DKBqP3u+G9bGD0G5uEB1KqI17gdg6T1HvrbjzGbpszKPo9rwE lAice5GiYZZU0+18N5amC+LneFJKGLTpjHjVl01Am96yvwRm36QicLYBIWvv/QjX MQgJ4aX3ZhgUa6WRIvigKOA5tUO6spXOk2qaV+i5gsJQXsdlCDSknKSkDDxKV2U3 8DmW8SbO2BzFQVDpD2NcnqjnhdQ6bbRKPjr/Nbc8h8Enzy/yAUk= =O+1X -----END PGP SIGNATURE----- --G0CpAOFVD9g/MuXw--