Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 4 Apr 2024 09:34:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Isaac Morland <isaac.morland@gmail.com>
Cc: "pgsql-general@lists.postgresql.org" <pgsql-general@lists.postgresql.org>
Subject: Re: recovery.signal not being removed when recovery complete
Message-ID: <Zg31i-f58Y3SOiqE@paquier.xyz>
References: <CAMsGm5dbUPS+3NTJdVvnnvjdSDPk3f+ztxw+yXv56FJa5sdkEw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GSZTtPxEvGG4GznN"
Content-Disposition: inline
In-Reply-To: <CAMsGm5dbUPS+3NTJdVvnnvjdSDPk3f+ztxw+yXv56FJa5sdkEw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zg31i-f58Y3SOiqE%40paquier.xyz>
Precedence: bulk


--GSZTtPxEvGG4GznN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2024 at 06:22:32PM -0400, Isaac Morland wrote:
> I use a script to restore a backup to create a testing copy of the
> database. I set the following in postgresql.auto.conf:
>=20
> recovery_target =3D 'immediate'
> recovery_target_action =3D 'promote'

Why not, after a pg_basebackup -R I assume.  Would you mind sharing
your commands?

> In the logs I get "recovery stopping after reaching consistency" then a
> moment later "database system is ready to accept read-only connections",
> then some entries about restoring log files, then "database system is rea=
dy
> to accept connections".

If you have some logs, that could help as well.

> I am able to make changes (e.g. CREATE TABLE), yet recovery.signal is sti=
ll
> present. My understanding is that recovery.signal should be removed when
> recovery is finished (i.e., more or less when "database system is ready to
> accept connections" is logged?), unless recovery_target_action is set to
> 'shutdown'.
>=20
> Any ideas? Even just confirming/denying I understand the above correctly
> would help.

Not removing the two .signal files when promotion is achieved would be
a problem to me because we'd reenter recovery again at a follow-up
startup.  ArchiveRecoveryRequested should be set if there was either
recovery.signal or standby.signal found at startup, meaning that we
should have a TLI jump at promotion with a physical removal of both
files and a LOG for a "selected new timeline ID".
--
Michael

--GSZTtPxEvGG4GznN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYN9YsACgkQnvQgOdby
QH3y5Q/+I5/pZUmAlAEmVNE3zHTztH1d5etNaqjjf6MCWZPXp5+XtYvLrygBcYK4
thrn5Kvs2D+5+wQstvt2ldzhkzo1U1hBjuFim6CfbPydH1HgAVI68901EfrbM+Q7
wp9iKmpBYTuamqUsGrC77Xd+M9tLYqQlCCZTlw0VYgTDV2I9hDPJ5109aPBWlSdL
QY3eVaTUXtDVTb6CHZkx2+rGTpFeICuQoL/Br2g8DkZVm5q5Vg15/4QDNKQaLwZ/
0rfI0uBIlIeaxmL6NcEVlZY76axo8HOAKMf5CIFydVe6brqcVixY9ww+8qq4Qb2i
j2mz0c8fueeTwv9Z05VXEOs67/B9tqh0s90n3fSyx2bN8rDcuPsZzrfjdMQj00uG
D+w4Qx+KuPOanNccV/YDmp8qiIYO7xpBl7igprtpwNI2lFIcnDTD6+P31o6EHppU
GerofbI+tI3LVHFLwIwqQG6Nx2FHIaB6SpNDPyo5zmoWWggfONF+YBMtPSSEdYPq
gWfOiU4zHaWgLvmW9FBrG0J2T2Q6pDyFGSHwg1n5rL3VDyiY9mvzHduXfIXPGJFJ
tveYwDFaStJtQM6KtdPsNoQ85S6asvlGCsr66ZFmouRdVNHBmx5H7H54N6eYqVuD
XUt05mjCw0HoOfyJR0gF1qDCmFiDwvt2ny/SsIe23t/qXVKKvWQ=
=/AZL
-----END PGP SIGNATURE-----

--GSZTtPxEvGG4GznN--