Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZu0J-009mpc-KU for pgsql-general@arkaria.postgresql.org; Thu, 10 Jul 2025 16:20:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uZu0H-00EeOc-J8 for pgsql-general@arkaria.postgresql.org; Thu, 10 Jul 2025 16:20:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZu0H-00EeOT-7l for pgsql-general@lists.postgresql.org; Thu, 10 Jul 2025 16:20:09 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uZu0G-006bOu-0Z for pgsql-general@lists.postgresql.org; Thu, 10 Jul 2025 16:20:08 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-454ac069223so12610585e9.1 for ; Thu, 10 Jul 2025 09:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752164406; x=1752769206; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=J5iwcXYPmBKjVI+X52flB9o7vBewP+ZkfLnHgCcjfSs=; b=GukNrupyr2xfKF5PCFSxQSTV6HJhlZ1ip+3pK1vwqykzp6g0S4ffqzaawLMZ2KNUlL Eyw+FOMUQcF7RgGIkJh3+YQ80yax5/vDB4vcDzn/90b9BJtZuiA7o2M3tgmU7dF0ahBD zIBM3mYh/OULx7TU1l00kb6/o1NIFd3hl49JRzsC9GbSk5GH9VU3koNvOGeky/Gkh4CE m2E8WbNhrANmU/fcB3tzmOQF4EpK1hEWuq+YUuI7qEAoPDkffgUEs0KESycGbLZal9wK oKScJ8ggPVzL1y3E19T9NUwAezooBF+REv3q+v//bMU1kzQQ8IWhSUjr9GwInJqq8UxD o9Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164406; x=1752769206; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J5iwcXYPmBKjVI+X52flB9o7vBewP+ZkfLnHgCcjfSs=; b=e/D+8RnKL9F3xlJ0i3mIwhWLwk+4ZKyjSRenc040rZkhg1i7CFqbeWF+X3ejeQQCHz wvQZMmsad0FHJArCo/ydSD+vbmkLHb+Yq/wnnXcmY0ubLsnyYlxyvM2Xt67CUwEBMWb9 sPV5k996VQMa+UJARXNKGrbWMfxwav+kGF3PuSj7exZKj8gK6cWbzMmU4FVCt1izBkyA Ik5ldl6MPO4iW4piILWWDotdUKC084HYaFlivQfUkeUbIsdQLoEStlwtLc31rbt8UTlf VS92qI7KOcB/D7xu3jNGfuyoYyU2MkEIXluvnoq1tUxbIDMv0PAo3bMAfD25Wn8Umxth eVNA== X-Forwarded-Encrypted: i=1; AJvYcCUxmpfYSK4WXpx/2akX9LyuMfSnE3fcO2NBg4ixY0mjIuYf4gactSDp4w59IK/B9oi6q7LjO74svXSK54Ih@lists.postgresql.org X-Gm-Message-State: AOJu0YyJEJ/KRSLL8UGrd0GdhUcDSfsoYYdgo5wt7Goh8PddeV96OW5A E726iqLsGTAexddtpb2Ee15CzXedJnjV6EbQqr2s6gG+IKlCR2x+J72z X-Gm-Gg: ASbGncuYKp/8Iq7ps15x9eYZlijkOMTN/O0U2NRkBLBTVloBDrM3OzBIXarDsOSGweS koctAJZCqbE73vO/7sLYo930SVkKk6xumciQj3Z0xaBqvs55nH27StgZLyKoTlgM65xaOaRODBX D1vW8tiOFttfWqimBOS5pox1SwnbaeqnbmXYXpZkGKn7bhcC+s0KpuD75Diw7asz/slG/1b2mTp 0IXhpQCWCOsDBqEiUlyO7HnK4Fbua5R3a1eL7UY8h0nAZAxjRnjz4JdHpjKD+4wau7iqjcPmN1Q HSNi3QzWxBc0b1MbSLme/A3mDN2eicDS/oq2Nnb8vqo+YPEaHsIJHSs1VBzbvZdN9iu+b0Wv0kz 2b2cMg90H1yQIQhumWtI1SxrL X-Google-Smtp-Source: AGHT+IFaCbmWw7h9Hyx9RtH0xVNwdZtVYq8fSFGx6RZIUDvewy3vZW2NZ7c5x8oEaH/AGYDc6qrtZA== X-Received: by 2002:a05:600c:3b1d:b0:453:69dc:2621 with SMTP id 5b1f17b1804b1-454db8d841cmr44684535e9.12.1752164406127; Thu, 10 Jul 2025 09:20:06 -0700 (PDT) Received: from [10.108.29.216] ([212.77.220.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454cd4f398csm58477105e9.2.2025.07.10.09.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jul 2025 09:20:05 -0700 (PDT) Message-ID: Date: Thu, 10 Jul 2025 17:20:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Mircea Cadariu Subject: Re: analyze-in-stages post upgrade questions To: Laurenz Albe , "Zechman, Derek S" , Adrian Klaver , "pgsql-general@lists.postgresql.org" References: <6add2a9a-7cf2-4d1b-8f3e-2e26a7ebe883@aklaver.com> <4d8122febd3007143504e4b6034b4253f7000761.camel@cybertec.at> <08d943a83590308cbb9be594d80b4e19ca80e08e.camel@cybertec.at> <2505eef1-b6aa-4518-baff-861a2e6a507b@gmail.com> Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Laurenz, Got it. I have only one suggestion for the patch. Consider adding a corresponding test in src/bin/scripts/t/100_vacuumdb.pl. Proposal (I used this to check the patch): $node->safe_psql('postgres',     "CREATE TABLE parent_table (a INT) PARTITION BY LIST (a);\n"       . "CREATE TABLE child_table PARTITION OF parent_table FOR VALUES IN (1);\n"       . "INSERT INTO parent_table VALUES (1);\n"); $node->issues_sql_like(     [         'vacuumdb', '--analyze-only', 'postgres'     ],     qr/statement:\s+ANALYZE\s+public\.parent_table/s,     '--analyze_only updates statistics for partitioned tables'); Kind regards, Mircea Cadariu